René's URL Explorer Experiment


Title: Computed properties do not type check when they could · Issue #18596 · microsoft/TypeScript · GitHub

Open Graph Title: Computed properties do not type check when they could · Issue #18596 · microsoft/TypeScript

X Title: Computed properties do not type check when they could · Issue #18596 · microsoft/TypeScript

Description: TypeScript Version: 2.4.2 Code type A = { a: number, b: string }; const a: A = { a: 1, b: 'foo' }; const b: A = { ...a, b: 123 }; // doesn't type check, b should be string (correct) const propB: 'b' = 'b'; const c: A = { ...a, [propB]: 1...

Open Graph Description: TypeScript Version: 2.4.2 Code type A = { a: number, b: string }; const a: A = { a: 1, b: 'foo' }; const b: A = { ...a, b: 123 }; // doesn't type check, b should be string (correct) const propB: 'b...

X Description: TypeScript Version: 2.4.2 Code type A = { a: number, b: string }; const a: A = { a: 1, b: 'foo' }; const b: A = { ...a, b: 123 }; // doesn't type check, b should be string (correct) con...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/18596

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Computed properties do not type check when they could","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n**TypeScript Version:**  2.4.2\r\n\r\n**Code**\r\n\r\n```ts\r\ntype A = { a: number, b: string };\r\n\r\nconst a: A = { a: 1, b: 'foo' };\r\n\r\nconst b: A = { ...a, b: 123 }; // doesn't type check, b should be string (correct)\r\n\r\nconst propB: 'b' = 'b';\r\nconst c: A = { ...a, [propB]: 123 }; // type checks even though i'm setting b to a number (incorrect)\r\n```\r\n\r\n**Expected behavior:**\r\n\r\nLast statement should be invalid, since `propB` is of type `'b'`, which should be enough information for TS to know that i'm setting the `b` property.\r\n\r\n**Actual behavior:**\r\n\r\nLast statement is valid for TS. This also happens for union types of string or number literals. When the types for the values in those keys are the same, and attempting to set a value using a computed property, TS allows invalid values.","author":{"url":"https://github.com/leoasis","@type":"Person","name":"leoasis"},"datePublished":"2017-09-20T13:52:54Z","url":"https://github.com/microsoft/TypeScript/issues/18596"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f12b2617-748a-200d-1288-e34f5fc96f7b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC534:157C65:13646A0:19E364A:6B012A25
html-safe-nonce05fd6c2743666746d28436b381d8749ca92f47d0a0b311fea871fe16be6db3ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTM0OjE1N0M2NToxMzY0NkEwOjE5RTM2NEE6NkIwMTJBMjUiLCJ2aXNpdG9yX2lkIjoiODUxODY1ODI2NzE5MzM1NDc5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9414d93425dfe1c5096aefb4e44e75aa473775f0243105ce1aae742f98d7f250
hovercard-subject-tagissue:259171627
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/18596/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ef53769aa7d41d9e72a1c5bb36965bbe31938b6e88f466637ac93ff61009509a/microsoft/TypeScript/issues/18596
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ef53769aa7d41d9e72a1c5bb36965bbe31938b6e88f466637ac93ff61009509a/microsoft/TypeScript/issues/18596
og:image:altTypeScript Version: 2.4.2 Code type A = { a: number, b: string }; const a: A = { a: 1, b: 'foo' }; const b: A = { ...a, b: 123 }; // doesn't type check, b should be string (correct) const propB: 'b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameleoasis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/18596#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F18596
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F18596
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/18596
Reloadhttps://github.com/microsoft/TypeScript/issues/18596
Reloadhttps://github.com/microsoft/TypeScript/issues/18596
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests311 (311)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18596
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18596
Computed properties do not type check when they couldhttps://github.com/microsoft/TypeScript/issues/18596#top
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
https://github.com/leoasis
Leonardo Garcia Crespo (leoasis)https://github.com/leoasis
on Sep 20, 2017https://github.com/microsoft/TypeScript/issues/18596#issue-259171627
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
on Sep 21, 2017https://github.com/microsoft/TypeScript/issues/18596#event-1258488364
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Oct 5, 2017https://github.com/microsoft/TypeScript/issues/18596#issuecomment-334549269
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 5, 2017https://github.com/microsoft/TypeScript/issues/18596#event-1280470515
microsofthttps://github.com/microsoft
on Jun 14, 2018https://github.com/microsoft/TypeScript/issues/18596#event-1682127048
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/18596
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18596
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.