René's URL Explorer Experiment


Title: Convert to ES6 Class Refactoring fails with empty catch clause · Issue #18541 · microsoft/TypeScript · GitHub

Open Graph Title: Convert to ES6 Class Refactoring fails with empty catch clause · Issue #18541 · microsoft/TypeScript

X Title: Convert to ES6 Class Refactoring fails with empty catch clause · Issue #18541 · microsoft/TypeScript

Description: TypeScript Version: nightly (2.6.0-dev.20170916) Try the refactoring on the following code: Code function MyClass() { } MyClass.prototype.foo = function() { try { doStuff(); } catch(e) {} } Expected behavior: The code is refactored Actua...

Open Graph Description: TypeScript Version: nightly (2.6.0-dev.20170916) Try the refactoring on the following code: Code function MyClass() { } MyClass.prototype.foo = function() { try { doStuff(); } catch(e) {} } Expecte...

X Description: TypeScript Version: nightly (2.6.0-dev.20170916) Try the refactoring on the following code: Code function MyClass() { } MyClass.prototype.foo = function() { try { doStuff(); } catch(e) {} } Expecte...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/18541

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Convert to ES6 Class Refactoring fails with empty catch clause","articleBody":"**TypeScript Version:**  nightly (2.6.0-dev.20170916)\r\n\r\nTry the refactoring on the following code:\r\n**Code**\r\n\r\n```js\r\nfunction MyClass() {\r\n}\r\nMyClass.prototype.foo = function() {\r\n    try { doStuff(); } catch(e) {}\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nThe code is refactored\r\n\r\n**Actual behavior:**\r\nTypescript throws an Error:\r\n```\r\n[Error  - 11:06:40] 'getEditsForRefactor' request failed with error.\r\nError processing request. Debug Failure. False expression.\r\nError: Debug Failure. False expression.\r\n    at getPos (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:72918:22)\r\n    at assignPositionsToNodeArray (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73354:29)\r\n    at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:43020:45)\r\n    at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73342:30)\r\n    at visitNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42792:23)\r\n    at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:43052:43)\r\n    at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73342:30)\r\n    at Object.visitNodes (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42829:48)\r\n    at assignPositionsToNodeArray (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73349:30)\r\n    at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:43020:45)\r\n    at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73342:30)\r\n    at visitNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42792:23)\r\n    at visitFunctionBody (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42875:23)\r\n    at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42914:510)\r\n    at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73342:30)\r\n    at Object.visitNodes (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42829:48)\r\n    at assignPositionsToNodeArray (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73349:30)\r\n    at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:43060:355)\r\n    at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73342:30)\r\n    at getNonformattedText (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73318:52)\r\n    at ChangeTracker.getFormattedTextOfNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73285:40)\r\n    at ChangeTracker.computeNewText (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73279:33)\r\n    at c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73254:44\r\n    at Map.forEach (native)\r\n    at ChangeTracker.getChanges (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73247:32)\r\n    at Object.getEditsForAction (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:75033:42)\r\n    at Object.getEditsForRefactor (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73512:41)\r\n    at Object.getEditsForRefactor (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:77543:32)\r\n    at IOSession.Session.getEditsForRefactor (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83445:59)\r\n    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:82407:61)\r\n    at c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83622:88\r\n    at IOSession.Session.executeWithRequestId (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83613:28)\r\n    at IOSession.Session.executeCommand (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83622:33)\r\n    at IOSession.Session.onMessage (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83642:35)\r\n    at Interface.\u003canonymous> (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:84789:27)\r\n    at emitOne (events.js:96:13)\r\n    at Interface.emit (events.js:191:7)\r\n    at Interface._onLine (readline.js:241:10)\r\n    at Interface._normalWrite (readline.js:384:12)\r\n    at Socket.ondata (readline.js:101:10)\r\n    at emitOne (events.js:96:13)\r\n    at Socket.emit (events.js:191:7)\r\n    at readableAddChunk (_stream_readable.js:178:18)\r\n    at Socket.Readable.push (_stream_readable.js:136:10)\r\n    at Pipe.onread (net.js:560:20)\r\n```\r\n\r\n@andy-ms this sounds very similar to #18437 which you fixed last week.\r\n","author":{"url":"https://github.com/hbenl","@type":"Person","name":"hbenl"},"datePublished":"2017-09-18T09:10:47Z","url":"https://github.com/microsoft/TypeScript/issues/18541"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5e454c41-e69a-69d1-9bbd-bd414f6bfeca
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8E28:882E2:DBA0F3:122F4E4:6B00F8AF
html-safe-nonce106c88ebb0902de1cc2120a6ae2e30b4251f365edb874e7cb523ad685180c31c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTI4Ojg4MkUyOkRCQTBGMzoxMjJGNEU0OjZCMDBGOEFGIiwidmlzaXRvcl9pZCI6IjQwODMyMTkzNTQxOTg1Mzg0MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfb2f6d9ec7c6e2d4f51d467702d1c231a36fca780b3c778244fa08cf7b9498bf
hovercard-subject-tagissue:258412187
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/18541/issue_layout
twitter:imagehttps://opengraph.githubassets.com/609404c9e4a25320a144b6b371defe675bbe98c854096b96e76b8b6054e258c7/microsoft/TypeScript/issues/18541
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/609404c9e4a25320a144b6b371defe675bbe98c854096b96e76b8b6054e258c7/microsoft/TypeScript/issues/18541
og:image:altTypeScript Version: nightly (2.6.0-dev.20170916) Try the refactoring on the following code: Code function MyClass() { } MyClass.prototype.foo = function() { try { doStuff(); } catch(e) {} } Expecte...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehbenl
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/18541#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F18541
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F18541
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/18541
Reloadhttps://github.com/microsoft/TypeScript/issues/18541
Reloadhttps://github.com/microsoft/TypeScript/issues/18541
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18541
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18541
#18547https://github.com/microsoft/TypeScript/pull/18547
Convert to ES6 Class Refactoring fails with empty catch clausehttps://github.com/microsoft/TypeScript/issues/18541#top
#18547https://github.com/microsoft/TypeScript/pull/18547
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.5.3https://github.com/microsoft/TypeScript/milestone/55
https://github.com/hbenl
Holger Benl (hbenl)https://github.com/hbenl
on Sep 18, 2017https://github.com/microsoft/TypeScript/issues/18541#issue-258412187
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
#18437https://github.com/microsoft/TypeScript/issues/18437
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Sep 18, 2017https://github.com/microsoft/TypeScript/issues/18541#event-1253814243
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Sep 18, 2017https://github.com/microsoft/TypeScript/issues/18541#event-1253814340
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.6https://github.com/microsoft/TypeScript/milestone/53
on Sep 18, 2017https://github.com/microsoft/TypeScript/issues/18541#event-1253814386
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#18547https://github.com/microsoft/TypeScript/pull/18547
on Sep 18, 2017https://github.com/microsoft/TypeScript/issues/18541#event-1253873660
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Sep 18, 2017https://github.com/microsoft/TypeScript/issues/18541#event-1253881499
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.6https://github.com/microsoft/TypeScript/milestone/53
TypeScript 2.5.3https://github.com/microsoft/TypeScript/milestone/55
on Sep 18, 2017https://github.com/microsoft/TypeScript/issues/18541#event-1253905625
microsofthttps://github.com/microsoft
on Jun 14, 2018https://github.com/microsoft/TypeScript/issues/18541#event-1682127595
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/18541
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18541
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.5.3https://github.com/microsoft/TypeScript/milestone/55
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.