Title: Convert to ES6 Class Refactoring fails with empty case statement · Issue #18437 · microsoft/TypeScript · GitHub
Open Graph Title: Convert to ES6 Class Refactoring fails with empty case statement · Issue #18437 · microsoft/TypeScript
X Title: Convert to ES6 Class Refactoring fails with empty case statement · Issue #18437 · microsoft/TypeScript
Description: TypeScript Version: nightly (2.6.0-dev.20170913) Try the refactoring on the following code: Code function MyClass() { } MyClass.prototype.foo = function(x) { switch(x) { case 0: } } Expected behavior: The refactoring is applied Actual be...
Open Graph Description: TypeScript Version: nightly (2.6.0-dev.20170913) Try the refactoring on the following code: Code function MyClass() { } MyClass.prototype.foo = function(x) { switch(x) { case 0: } } Expected behavi...
X Description: TypeScript Version: nightly (2.6.0-dev.20170913) Try the refactoring on the following code: Code function MyClass() { } MyClass.prototype.foo = function(x) { switch(x) { case 0: } } Expected behavi...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/18437
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Convert to ES6 Class Refactoring fails with empty case statement","articleBody":"**TypeScript Version:** nightly (2.6.0-dev.20170913)\r\n\r\nTry the refactoring on the following code:\r\n**Code**\r\n\r\n```js\r\nfunction MyClass() {\r\n}\r\nMyClass.prototype.foo = function(x) {\r\n switch(x) {\r\n case 0:\r\n }\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nThe refactoring is applied\r\n\r\n**Actual behavior:**\r\nThe code is unchanged, an error is thrown:\r\n```\r\n[Error - 13:34:21] 'getEditsForRefactor' request failed with error.\r\nError processing request. Debug Failure. False expression.\r\nError: Debug Failure. False expression.\r\n at getPos (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:72799:22)\r\n at assignPositionsToNodeArray (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73238:29)\r\n at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:43037:104)\r\n at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73226:30)\r\n at Object.visitNodes (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42752:48)\r\n at assignPositionsToNodeArray (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73233:30)\r\n at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42995:49)\r\n at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73226:30)\r\n at visitNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42715:23)\r\n at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42969:100)\r\n at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73226:30)\r\n at Object.visitNodes (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42752:48)\r\n at assignPositionsToNodeArray (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73233:30)\r\n at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42943:45)\r\n at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73226:30)\r\n at visitNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42715:23)\r\n at visitFunctionBody (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42798:23)\r\n at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42837:510)\r\n at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73226:30)\r\n at Object.visitNodes (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42752:48)\r\n at assignPositionsToNodeArray (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73233:30)\r\n at Object.visitEachChild (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:42983:355)\r\n at assignPositionsToNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73226:30)\r\n at getNonformattedText (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73202:52)\r\n at ChangeTracker.getFormattedTextOfNode (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73169:40)\r\n at ChangeTracker.computeNewText (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73163:33)\r\n at c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73138:44\r\n at Map.forEach (native)\r\n at ChangeTracker.getChanges (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73131:32)\r\n at Object.getEditsForAction (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:74917:42)\r\n at Object.getEditsForRefactor (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:73396:41)\r\n at Object.getEditsForRefactor (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:77392:32)\r\n at IOSession.Session.getEditsForRefactor (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83294:59)\r\n at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:82256:61)\r\n at c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83470:88\r\n at IOSession.Session.executeWithRequestId (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83461:28)\r\n at IOSession.Session.executeCommand (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83470:33)\r\n at IOSession.Session.onMessage (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:83490:35)\r\n at Interface.\u003canonymous> (c:\\GitTF\\Aktuell\\WebDispo\\node_modules\\typescript\\lib\\tsserver.js:84621:27)\r\n at emitOne (events.js:96:13)\r\n at Interface.emit (events.js:191:7)\r\n at Interface._onLine (readline.js:241:10)\r\n at Interface._normalWrite (readline.js:384:12)\r\n at Socket.ondata (readline.js:101:10)\r\n at emitOne (events.js:96:13)\r\n at Socket.emit (events.js:191:7)\r\n at readableAddChunk (_stream_readable.js:178:18)\r\n at Socket.Readable.push (_stream_readable.js:136:10)\r\n at Pipe.onread (net.js:560:20)\r\n```\r\n\r\nNote that it works in 2.5.2.\r\nIt also works in nightly if you add any statement after `case 0:`.\r\n","author":{"url":"https://github.com/hbenl","@type":"Person","name":"hbenl"},"datePublished":"2017-09-13T11:37:37Z","url":"https://github.com/microsoft/TypeScript/issues/18437"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3f18ed33-c5af-57cf-bf9b-8a39da4ffb2e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 896C:2270F4:C02E1A:1011919:6B00F6C5 |
| html-safe-nonce | 20d4b05e0b3d1ca3a3720bcefa1d6d1bbd3be2e5a8f1665c836cf410445a878b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTZDOjIyNzBGNDpDMDJFMUE6MTAxMTkxOTo2QjAwRjZDNSIsInZpc2l0b3JfaWQiOiI2NjMwNDI0ODIzNzc0Mzc3NjcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 54a11d8bd197635d82000c6bdbe085f24b09c9d91a665e6593767a74b91aba96 |
| hovercard-subject-tag | issue:257349092 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/18437/issue_layout |
| twitter:image | https://opengraph.githubassets.com/81b92279743e8b2b2a5b7b4a14591e80bbf3a0f641f421341199887df9ef00b3/microsoft/TypeScript/issues/18437 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/81b92279743e8b2b2a5b7b4a14591e80bbf3a0f641f421341199887df9ef00b3/microsoft/TypeScript/issues/18437 |
| og:image:alt | TypeScript Version: nightly (2.6.0-dev.20170913) Try the refactoring on the following code: Code function MyClass() { } MyClass.prototype.foo = function(x) { switch(x) { case 0: } } Expected behavi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hbenl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width