Title: Convert to ES6 Class Refactoring fails with function expressions within object literals · Issue #18434 · microsoft/TypeScript · GitHub
Open Graph Title: Convert to ES6 Class Refactoring fails with function expressions within object literals · Issue #18434 · microsoft/TypeScript
X Title: Convert to ES6 Class Refactoring fails with function expressions within object literals · Issue #18434 · microsoft/TypeScript
Description: TypeScript Version: 2.5.2 / nightly (2.6.0-dev.20170913) Try to apply the refactoring to the following code: Code function MyClass() { } MyClass.prototype.foo = function() { ({ bar: () => { } }) } Expected behavior: The code is refactore...
Open Graph Description: TypeScript Version: 2.5.2 / nightly (2.6.0-dev.20170913) Try to apply the refactoring to the following code: Code function MyClass() { } MyClass.prototype.foo = function() { ({ bar: () => { } }) } ...
X Description: TypeScript Version: 2.5.2 / nightly (2.6.0-dev.20170913) Try to apply the refactoring to the following code: Code function MyClass() { } MyClass.prototype.foo = function() { ({ bar: () => { } })...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/18434
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Convert to ES6 Class Refactoring fails with function expressions within object literals","articleBody":"**TypeScript Version:** 2.5.2 / nightly (2.6.0-dev.20170913)\r\n\r\nTry to apply the refactoring to the following code:\r\n**Code**\r\n```js\r\nfunction MyClass() {\r\n}\r\nMyClass.prototype.foo = function() {\r\n ({ bar: () => { } })\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nThe code is refactored\r\n\r\n**Actual behavior:**\r\nTypescript throws an Error:\r\n```\r\n[Error - 12:29:54] 'getEditsForRefactor' request failed with error.\r\nError processing request. Debug Failure. False expression: Token end is child end\r\nError: Debug Failure. False expression: Token end is child end\r\n at processChildNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71460:34)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71414:21\r\n at visitNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11402:24)\r\n at Object.forEachChild (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11480:21)\r\n at processNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71413:20)\r\n at processChildNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71466:21)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71414:21\r\n at visitNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11402:24)\r\n at Object.forEachChild (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11453:21)\r\n at processNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71413:20)\r\n at processChildNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71466:21)\r\n at processChildNodes (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71498:48)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71416:21\r\n at visitNodes (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11407:24)\r\n at Object.forEachChild (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11518:24)\r\n at processNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71413:20)\r\n at processChildNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71466:21)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71414:21\r\n at visitNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11402:24)\r\n at Object.forEachChild (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11537:24)\r\n at processNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71413:20)\r\n at processChildNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71466:21)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71414:21\r\n at visitNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11402:24)\r\n at Object.forEachChild (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11585:24)\r\n at processNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71413:20)\r\n at processChildNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71466:21)\r\n at processChildNodes (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71498:48)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71416:21\r\n at visitNodes (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11407:24)\r\n at Object.forEachChild (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11574:24)\r\n at processNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71413:20)\r\n at processChildNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71466:21)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71414:21\r\n at visitNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11402:24)\r\n at Object.forEachChild (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11481:21)\r\n at processNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71413:20)\r\n at processChildNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71466:21)\r\n at processChildNodes (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71498:48)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71416:21\r\n at visitNodes (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11407:24)\r\n at Object.forEachChild (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:11649:21)\r\n at processNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71413:20)\r\n at formatSpanWorker (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71268:17)\r\n at Object.formatNodeGivenIndentation (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:71235:20)\r\n at applyFormatting (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:72678:41)\r\n at ChangeTracker.getFormattedTextOfNode (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:72651:24)\r\n at ChangeTracker.computeNewText (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:72629:33)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:72604:44\r\n at Map.forEach (native)\r\n at ChangeTracker.getChanges (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:72597:32)\r\n at Object.getEditsForAction (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:74368:42)\r\n at Object.getEditsForRefactor (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:72859:41)\r\n at Object.getEditsForRefactor (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:76692:32)\r\n at IOSession.Session.getEditsForRefactor (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:82522:59)\r\n at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:81488:61)\r\n at c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:82698:88\r\n at IOSession.Session.executeWithRequestId (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:82689:28)\r\n at IOSession.Session.executeCommand (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:82698:33)\r\n at IOSession.Session.onMessage (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:82718:35)\r\n at Interface.\u003canonymous> (c:\\Program Files\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js:83804:27)\r\n at emitOne (events.js:96:13)\r\n at Interface.emit (events.js:191:7)\r\n at Interface._onLine (readline.js:241:10)\r\n at Interface._normalWrite (readline.js:384:12)\r\n at Socket.ondata (readline.js:101:10)\r\n at emitOne (events.js:96:13)\r\n at Socket.emit (events.js:191:7)\r\n at readableAddChunk (_stream_readable.js:178:18)\r\n at Socket.Readable.push (_stream_readable.js:136:10)\r\n at Pipe.onread (net.js:560:20)\r\n```\r\n\r\nThis stacktrace is from VS Code using its built-in typescript version (2.5.2). I also tried with the latest nightly version (2.6.0-dev.20170913) and got the same error.\r\nWhen you replace the lambda expression `() => { }` with a traditional `function() { }` the same error occurs.\r\nHowever, if you put the function expression outside of the object literal:\r\n```js\r\nfunction MyClass() {\r\n}\r\nMyClass.prototype.foo = function() {\r\n const baz = () => { };\r\n ({ bar: baz })\r\n}\r\n```\r\nthen the refactoring works as expected:\r\n```js\r\nclass MyClass {\r\n constructor() {\r\n }\r\n foo() {\r\n const baz = () => { };\r\n ({ bar: baz })\r\n }\r\n}\r\n```","author":{"url":"https://github.com/hbenl","@type":"Person","name":"hbenl"},"datePublished":"2017-09-13T10:43:01Z","url":"https://github.com/microsoft/TypeScript/issues/18434"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bd8d62e1-be9f-4544-2de5-68af9eab7ee9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 96C4:6DC60:CDE9E:10230C:6B00F6C9 |
| html-safe-nonce | 3b9324ba9d5a8804c89d3c0a1a5d93fc7f8ca83fd9b780dafc52cc931db0700b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkM0OjZEQzYwOkNERTlFOjEwMjMwQzo2QjAwRjZDOSIsInZpc2l0b3JfaWQiOiIzNzM1Nzk2MzAxNDE0MDY5OTYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c97f79dfe276ce675505fe92fcb1b4a33bc8ec8de5763bacab8bf79974ec6988 |
| hovercard-subject-tag | issue:257335701 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/18434/issue_layout |
| twitter:image | https://opengraph.githubassets.com/81b92279743e8b2b2a5b7b4a14591e80bbf3a0f641f421341199887df9ef00b3/microsoft/TypeScript/issues/18434 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/81b92279743e8b2b2a5b7b4a14591e80bbf3a0f641f421341199887df9ef00b3/microsoft/TypeScript/issues/18434 |
| og:image:alt | TypeScript Version: 2.5.2 / nightly (2.6.0-dev.20170913) Try to apply the refactoring to the following code: Code function MyClass() { } MyClass.prototype.foo = function() { ({ bar: () => { } }) } ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hbenl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width