Title: Generic Function with Indexed Type ignores readonly · Issue #18374 · microsoft/TypeScript · GitHub
Open Graph Title: Generic Function with Indexed Type ignores readonly · Issue #18374 · microsoft/TypeScript
X Title: Generic Function with Indexed Type ignores readonly · Issue #18374 · microsoft/TypeScript
Description: TypeScript Version: 2.4.2 Code function mapAssign
Open Graph Description: TypeScript Version: 2.4.2 Code function mapAssign
X Description: TypeScript Version: 2.4.2 Code function mapAssign<T, K extends keyof T>(obj: T, k: K, f: (v: T[K]) => T[K]) { obj[k] = f(obj[k]); } type NoChange = { readonly value: number } const obj: No...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/18374
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Generic Function with Indexed Type ignores readonly","articleBody":"\r\nTypeScript Version: 2.4.2\r\n\r\n**Code**\r\n\r\n```ts\r\nfunction mapAssign\u003cT, K extends keyof T>(obj: T, k: K, f: (v: T[K]) => T[K]) {\r\n obj[k] = f(obj[k]);\r\n}\r\n\r\ntype NoChange = {\r\n readonly value: number\r\n}\r\nconst obj: NoChange = {value: 5};\r\n\r\nmapAssign(obj, \"value\", x => x+1);\r\n```\r\n\r\n**Expected behavior:**\r\nSince `NoChange.value` is `readonly`, it should not be modifiable.\r\n\r\n**Actual behavior:**\r\nThe code compiles and runs, modifying `obj.value`.\r\n\r\nThis might just be a design limitation that can't be worked around.\r\n\r\nIf a stricter check was desirable, I could imagine it being something like this:\r\n\r\n* if `K extends keyof T` and `k: K` and `x: T`, then `x[k] = e` would fail, but `T = {readonly [k]: any}` would be okay\r\n* if `K extends !readonly keyof T` and `k: K` and `x: T` then `x[k] = e` would succeed, but `T = {readonly [k]: any}` would fail\r\n\r\nSo the above program would become\r\n\r\n```ts\r\nfunction mapAssign\u003cT, K extends !readonly keyof T>(obj: T, k: K, f: (v: T[K]) => T[K]) {\r\n obj[k] = f(obj[k]); // okay, since K extends !readonly keyof T\r\n}\r\nmapAssign(obj, \"value\", x => x+1); // error: Const.value is readonly\r\n```\r\n\r\nAn alternative change (which I think is much less ergonomic) would be the following:\r\n\r\n* if `K extends keyof T` and `k: K` and `x: T` then `x[k] = e` would succeed, but `T = {readonly [k]: any}` would fail\r\n* if `K extends readonly keyof T` and `k: K` and `x: T` then `x[k] = e` would fail but `T = {readonly [k]: any}` would succeed.\r\n\r\nSo the program would be\r\n```ts\r\nfunction mapAssign\u003cT, K extends keyof T>(obj: T, k: K, f: (v: T[K]) => T[K]) {\r\n obj[k] = f(obj[k]);\r\n}\r\nmapAssign(obj, \"value\", x => x+1); // error: Const.value is readonly\r\n```\r\n","author":{"url":"https://github.com/Nathan-Fenner","@type":"Person","name":"Nathan-Fenner"},"datePublished":"2017-09-11T02:44:02Z","url":"https://github.com/microsoft/TypeScript/issues/18374"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bc79829b-874e-1692-ca20-8b65be17e346 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E166:150E61:A3546:E1489:6AFBC8A9 |
| html-safe-nonce | ee2d657053e37265935efe279bd64a481bde7cdb0e7fc7f778d635c6b2d2127e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTY2OjE1MEU2MTpBMzU0NjpFMTQ4OTo2QUZCQzhBOSIsInZpc2l0b3JfaWQiOiI0OTgzODgxMjk3NjEzODAxNjQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a3e5f20b18265fe0fe1c103697bcdd3af0f7f0638d03b037b40440244f26d535 |
| hovercard-subject-tag | issue:256567020 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/18374/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bf55568d557dc9a4e5df68206f41e053b3221ef4d739d298c37659ba205bedf2/microsoft/TypeScript/issues/18374 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bf55568d557dc9a4e5df68206f41e053b3221ef4d739d298c37659ba205bedf2/microsoft/TypeScript/issues/18374 |
| og:image:alt | TypeScript Version: 2.4.2 Code function mapAssign |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Nathan-Fenner |
| hostname | github.com |
| expected-hostname | github.com |
| None | d440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2c43021aed8695990c86c0eaaedc600bfeffec36 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width