René's URL Explorer Experiment


Title: Generic Function with Indexed Type ignores readonly · Issue #18374 · microsoft/TypeScript · GitHub

Open Graph Title: Generic Function with Indexed Type ignores readonly · Issue #18374 · microsoft/TypeScript

X Title: Generic Function with Indexed Type ignores readonly · Issue #18374 · microsoft/TypeScript

Description: TypeScript Version: 2.4.2 Code function mapAssign(obj: T, k: K, f: (v: T[K]) => T[K]) { obj[k] = f(obj[k]); } type NoChange = { readonly value: number } const obj: NoChange = {value: 5}; mapAssign(obj, "value", x =>...

Open Graph Description: TypeScript Version: 2.4.2 Code function mapAssign(obj: T, k: K, f: (v: T[K]) => T[K]) { obj[k] = f(obj[k]); } type NoChange = { readonly value: number } const obj: NoChange = ...

X Description: TypeScript Version: 2.4.2 Code function mapAssign<T, K extends keyof T>(obj: T, k: K, f: (v: T[K]) => T[K]) { obj[k] = f(obj[k]); } type NoChange = { readonly value: number } const obj: No...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/18374

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Generic Function with Indexed Type ignores readonly","articleBody":"\r\nTypeScript Version: 2.4.2\r\n\r\n**Code**\r\n\r\n```ts\r\nfunction mapAssign\u003cT, K extends keyof T>(obj: T, k: K, f: (v: T[K]) => T[K]) {\r\n    obj[k] = f(obj[k]);\r\n}\r\n\r\ntype NoChange = {\r\n    readonly value: number\r\n}\r\nconst obj: NoChange = {value: 5};\r\n\r\nmapAssign(obj, \"value\", x => x+1);\r\n```\r\n\r\n**Expected behavior:**\r\nSince `NoChange.value` is `readonly`, it should not be modifiable.\r\n\r\n**Actual behavior:**\r\nThe code compiles and runs, modifying `obj.value`.\r\n\r\nThis might just be a design limitation that can't be worked around.\r\n\r\nIf a stricter check was desirable, I could imagine it being something like this:\r\n\r\n* if `K extends keyof T` and `k: K` and `x: T`, then `x[k] = e` would fail, but `T = {readonly [k]: any}` would be okay\r\n* if `K extends !readonly keyof T` and `k: K` and `x: T` then `x[k] = e` would succeed, but `T = {readonly [k]: any}` would fail\r\n\r\nSo the above program would become\r\n\r\n```ts\r\nfunction mapAssign\u003cT, K extends !readonly keyof T>(obj: T, k: K, f: (v: T[K]) => T[K]) {\r\n    obj[k] = f(obj[k]); // okay, since K extends !readonly keyof T\r\n}\r\nmapAssign(obj, \"value\", x => x+1); // error: Const.value is readonly\r\n```\r\n\r\nAn alternative change (which I think is much less ergonomic) would be the following:\r\n\r\n* if `K extends keyof T` and `k: K` and `x: T` then `x[k] = e` would succeed, but `T = {readonly [k]: any}` would fail\r\n* if `K extends readonly keyof T` and `k: K` and `x: T` then `x[k] = e` would fail but `T = {readonly [k]: any}` would succeed.\r\n\r\nSo the program would be\r\n```ts\r\nfunction mapAssign\u003cT, K extends keyof T>(obj: T, k: K, f: (v: T[K]) => T[K]) {\r\n    obj[k] = f(obj[k]);\r\n}\r\nmapAssign(obj, \"value\", x => x+1); // error: Const.value is readonly\r\n```\r\n","author":{"url":"https://github.com/Nathan-Fenner","@type":"Person","name":"Nathan-Fenner"},"datePublished":"2017-09-11T02:44:02Z","url":"https://github.com/microsoft/TypeScript/issues/18374"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bc79829b-874e-1692-ca20-8b65be17e346
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE166:150E61:A3546:E1489:6AFBC8A9
html-safe-nonceee2d657053e37265935efe279bd64a481bde7cdb0e7fc7f778d635c6b2d2127e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTY2OjE1MEU2MTpBMzU0NjpFMTQ4OTo2QUZCQzhBOSIsInZpc2l0b3JfaWQiOiI0OTgzODgxMjk3NjEzODAxNjQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca3e5f20b18265fe0fe1c103697bcdd3af0f7f0638d03b037b40440244f26d535
hovercard-subject-tagissue:256567020
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/18374/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bf55568d557dc9a4e5df68206f41e053b3221ef4d739d298c37659ba205bedf2/microsoft/TypeScript/issues/18374
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bf55568d557dc9a4e5df68206f41e053b3221ef4d739d298c37659ba205bedf2/microsoft/TypeScript/issues/18374
og:image:altTypeScript Version: 2.4.2 Code function mapAssign(obj: T, k: K, f: (v: T[K]) => T[K]) { obj[k] = f(obj[k]); } type NoChange = { readonly value: number } const obj: NoChange = ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNathan-Fenner
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/18374#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F18374
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F18374
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/18374
Reloadhttps://github.com/microsoft/TypeScript/issues/18374
Reloadhttps://github.com/microsoft/TypeScript/issues/18374
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests334 (334)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18374
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18374
Generic Function with Indexed Type ignores readonlyhttps://github.com/microsoft/TypeScript/issues/18374#top
Design LimitationConstraints of the existing architecture prevent this from being fixedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Limitation%22
https://github.com/Nathan-Fenner
Nathan Fenner (Nathan-Fenner)https://github.com/Nathan-Fenner
on Sep 11, 2017https://github.com/microsoft/TypeScript/issues/18374#issue-256567020
https://github.com/olegdunkan
olegdunkanhttps://github.com/olegdunkan
on Sep 11, 2017https://github.com/microsoft/TypeScript/issues/18374#issuecomment-328501705
#6532 (comment)https://github.com/microsoft/TypeScript/pull/6532#issuecomment-174356151
https://github.com/Nathan-Fenner
Nathan Fenner (Nathan-Fenner)https://github.com/Nathan-Fenner
on Sep 11, 2017https://github.com/microsoft/TypeScript/issues/18374#issuecomment-328508285
https://github.com/olegdunkan
olegdunkanhttps://github.com/olegdunkan
on Sep 11, 2017https://github.com/microsoft/TypeScript/issues/18374#issuecomment-328512078
https://github.com/Nathan-Fenner
Nathan Fenner (Nathan-Fenner)https://github.com/Nathan-Fenner
on Sep 11, 2017https://github.com/microsoft/TypeScript/issues/18374#issuecomment-328679870
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Design LimitationConstraints of the existing architecture prevent this from being fixedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Limitation%22
on Sep 12, 2017https://github.com/microsoft/TypeScript/issues/18374#event-1246002183
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Sep 12, 2017https://github.com/microsoft/TypeScript/issues/18374#issuecomment-328968718
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Oct 2, 2017https://github.com/microsoft/TypeScript/issues/18374#issuecomment-333687632
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 2, 2017https://github.com/microsoft/TypeScript/issues/18374#event-1275009917
microsofthttps://github.com/microsoft
on Jun 14, 2018https://github.com/microsoft/TypeScript/issues/18374#event-1682129401
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/18374
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18374
Design LimitationConstraints of the existing architecture prevent this from being fixedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Limitation%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.