René's URL Explorer Experiment


Title: two lines in an interface cause a build time explosion [strictGenericChecks] · Issue #18257 · microsoft/TypeScript · GitHub

Open Graph Title: two lines in an interface cause a build time explosion [strictGenericChecks] · Issue #18257 · microsoft/TypeScript

X Title: two lines in an interface cause a build time explosion [strictGenericChecks] · Issue #18257 · microsoft/TypeScript

Description: TypeScript Version: Tested on 2.5.2 and 2.6.0-dev.20170904 Code The code is there: https://github.com/emmanueltouzery/prelude.ts/tree/5c33c1eeeea7234506e54331d06590e2feb9b00d To build it you can just run npm install && tsc. It's about 18...

Open Graph Description: TypeScript Version: Tested on 2.5.2 and 2.6.0-dev.20170904 Code The code is there: https://github.com/emmanueltouzery/prelude.ts/tree/5c33c1eeeea7234506e54331d06590e2feb9b00d To build it you can ju...

X Description: TypeScript Version: Tested on 2.5.2 and 2.6.0-dev.20170904 Code The code is there: https://github.com/emmanueltouzery/prelude.ts/tree/5c33c1eeeea7234506e54331d06590e2feb9b00d To build it you can ju...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/18257

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"two lines in an interface cause a build time explosion [strictGenericChecks]","articleBody":"**TypeScript Version:** Tested on  2.5.2 and 2.6.0-dev.20170904\r\n\r\n**Code**\r\n\r\nThe code is there:\r\nhttps://github.com/emmanueltouzery/prelude.ts/tree/5c33c1eeeea7234506e54331d06590e2feb9b00d\r\n\r\nTo build it you can just run `npm install && tsc`. It's about 1800 LOCs of typescript.\r\n\r\nOn my (old) machine, if I build it as-is with 2.5 or 2.6-dev I get a ~5s build time. If I uncomment in `src/IMap.ts` [lines 29 and 30](https://github.com/emmanueltouzery/prelude.ts/blob/5c33c1eeeea7234506e54331d06590e2feb9b00d/src/IMap.ts#L28-L30), however, the build time explodes. On 2.5 I didn't bother waiting but it would be a long, long, long time. On 2.6-dev the speed is much better but the build time still explodes from 5 seconds to 35 seconds.\r\n\r\nThe two lines are:\r\n```typescript\r\n     mapValuesStruct\u003cV2>(fn:(v:V)=>V2): IMap\u003cK,V2>;\r\n     mapValues\u003cV2>(fn:(v:V)=>V2&WithEquality): IMap\u003cK,V2>;\r\n```\r\n\r\nAnd they are implemented in `src/HashMap.ts` with:\r\n\r\n```typescript\r\n    map\u003cK2,V2>(fn:(k:K&WithEquality, v:V)=>[K2&WithEquality,V2&WithEquality]): HashMap\u003cK2,V2> {\r\n        return this.mapStruct(fn);\r\n    }\r\n\r\n    mapValuesStruct\u003cV2>(fn:(v:V)=>V2): HashMap\u003cK,V2> {\r\n        return this.hamt.fold(\r\n            (acc: HashMap\u003cK,V2>, value: V, key: K&WithEquality) =>\r\n                acc.putStruct(key,fn(value)), HashMap.empty());\r\n    }\r\n```\r\n\r\nWhen I implement the interface, I change the return type to a more specific one, which is as far as I'm aware, legal.\r\n\r\n**Expected behavior:**\r\nUncommenting these two lines of code shouldn't cause the build time to increase sevenfold. Maybe the code is wrong, but then I should get a compilation error or a warning, not an increased build time.\r\n\r\nIf I put in the `tsconfig.json`:\r\n`\"noStrictGenericChecks\": true`\r\n\r\nthen the performance issue goes away completely even with the lines uncommented.","author":{"url":"https://github.com/emmanueltouzery","@type":"Person","name":"emmanueltouzery"},"datePublished":"2017-09-05T19:47:25Z","url":"https://github.com/microsoft/TypeScript/issues/18257"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d743e9ae-14b9-4482-86f5-a7699c56e565
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBDC0:1F44:15B929:1CBC52:6B00DEE7
html-safe-nonce9cd165809a625f3083616a30004adaa817c9806cc9482f798c7e3a16a09700d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREMwOjFGNDQ6MTVCOTI5OjFDQkM1Mjo2QjAwREVFNyIsInZpc2l0b3JfaWQiOiI3NDQ5NTE0NzU1NDM5NTE3NDE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9cba9da2c844bc151008839f0384966f3e184a57f584a4f61bc58858c0e7eec8
hovercard-subject-tagissue:255387981
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/18257/issue_layout
twitter:imagehttps://opengraph.githubassets.com/de6f2c6860a1c1da37ec78b7fc5be3206269285b9dede9d3d49e924497b4577d/microsoft/TypeScript/issues/18257
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de6f2c6860a1c1da37ec78b7fc5be3206269285b9dede9d3d49e924497b4577d/microsoft/TypeScript/issues/18257
og:image:altTypeScript Version: Tested on 2.5.2 and 2.6.0-dev.20170904 Code The code is there: https://github.com/emmanueltouzery/prelude.ts/tree/5c33c1eeeea7234506e54331d06590e2feb9b00d To build it you can ju...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameemmanueltouzery
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/18257#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F18257
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F18257
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/18257
Reloadhttps://github.com/microsoft/TypeScript/issues/18257
Reloadhttps://github.com/microsoft/TypeScript/issues/18257
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18257
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18257
two lines in an interface cause a build time explosion [strictGenericChecks]https://github.com/microsoft/TypeScript/issues/18257#top
https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.5.3https://github.com/microsoft/TypeScript/milestone/55
https://github.com/emmanueltouzery
emmanueltouzeryhttps://github.com/emmanueltouzery
on Sep 5, 2017https://github.com/microsoft/TypeScript/issues/18257#issue-255387981
https://github.com/emmanueltouzery/prelude.ts/tree/5c33c1eeeea7234506e54331d06590e2feb9b00dhttps://github.com/emmanueltouzery/prelude.ts/tree/5c33c1eeeea7234506e54331d06590e2feb9b00d
lines 29 and 30https://github.com/emmanueltouzery/prelude.ts/blob/5c33c1eeeea7234506e54331d06590e2feb9b00d/src/IMap.ts#L28-L30
emmanueltouzeryhttps://github.com/emmanueltouzery
on Sep 5, 2017https://github.com/microsoft/TypeScript/issues/18257#event-1235583094
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Sep 5, 2017https://github.com/microsoft/TypeScript/issues/18257#event-1235864852
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on Sep 5, 2017https://github.com/microsoft/TypeScript/issues/18257#event-1235864896
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Sep 6, 2017https://github.com/microsoft/TypeScript/issues/18257#event-1237273390
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.5.3https://github.com/microsoft/TypeScript/milestone/55
on Sep 6, 2017https://github.com/microsoft/TypeScript/issues/18257#event-1237433749
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#18279https://github.com/microsoft/TypeScript/pull/18279
on Sep 6, 2017https://github.com/microsoft/TypeScript/issues/18257#event-1237598254
microsofthttps://github.com/microsoft
on Jun 14, 2018https://github.com/microsoft/TypeScript/issues/18257#event-1682130482
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/18257
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/18257
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.5.3https://github.com/microsoft/TypeScript/milestone/55
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.