René's URL Explorer Experiment


Title: Better comment emit on tokens · Issue #17689 · microsoft/TypeScript · GitHub

Open Graph Title: Better comment emit on tokens · Issue #17689 · microsoft/TypeScript

X Title: Better comment emit on tokens · Issue #17689 · microsoft/TypeScript

Description: Carrying on from the work initiated in #17557, we should improve our retention of comments where possible. We should check that we retain comments inside: BinaryExpression (#16584) ReturnStatement (#17557) YieldExpression (#22141) AwaitE...

Open Graph Description: Carrying on from the work initiated in #17557, we should improve our retention of comments where possible. We should check that we retain comments inside: BinaryExpression (#16584) ReturnStatement ...

X Description: Carrying on from the work initiated in #17557, we should improve our retention of comments where possible. We should check that we retain comments inside: BinaryExpression (#16584) ReturnStatement ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/17689

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Better comment emit on tokens","articleBody":"Carrying on from the work initiated in #17557, we should improve our retention of comments where possible. We should check that we retain comments inside:\r\n- [x] `BinaryExpression` (#16584)\r\n- [x] `ReturnStatement` (#17557)\r\n- [x] `YieldExpression` (#22141)\r\n- [x] `AwaitExpression`  (#22141)\r\n- [x] `DeleteExpression`  (#22141)\r\n- [x] `TypeOfExpression`  (#22141)\r\n- [x] `VoidExpression`  (#22141)\r\n- [x] `NewExpression`  (#22141)\r\n- [x] `ElementAccessExpression`  (#22141)\r\n- [x] `PropertyAccessExpression`  (#22141)\r\n- [x] Block-level statements where the comments need to be considered attached to a parenthesis token, such as:  (#22141)\r\n  * [x] `IfStatement`  (#22141)\r\n  * [x] `WhileStatement`  (#22141)\r\n  * [x] `DoStatement` (#22141)\r\n  * [x] `ForStatement` (#22141)\r\n  * [x] `ForInStatement` (#22141)\r\n  * [x] `ForOfStatement` (#22141)\r\n  * [x] `SwitchStatement` (#22141)\r\n  * [x] `WithStatement` (#22141)\r\n  * [x] `ContinueStatement` (#22141)\r\n  * [x] `BreakStatement` (#22141)\r\n  * [x] `CaseStatement` (#22141)\r\n  * [x] `ThrowStatement` (#22141) (future: `ThrowExpression`)\r\n  * [x] `TryStatement` (see #11755)\r\n- [x] `VariableDeclaration` (#22141)\r\n- [ ] `AsExpression` (only visible for ts -> ts transforms)\r\n- [ ] `TypeAssertionExpression` (same as above)\r\n- [ ] `JSXExpression` (in all jsx emit modes) (#41754)\r\n- [x] All import and export kinds (#22141)\r\n- [ ] Literally all multitoken type nodes (that aren't within jsdoc)\r\n  * [ ] `TypePredicateNode`\r\n  * [ ] `TypeQueryNode`\r\n  * [ ] `ConstructorTypeNode`\r\n  * [ ] `FunctionTypeNode`\r\n  * [ ] `ConditionalTypeNode`\r\n  * [ ] `InferTypeNode`\r\n  * [ ] `ThisTypeNode`\r\n  * [ ] `MappedTypeNode`\r\n  * [ ] `IndexedAccessTypeNode`\r\n\r\nMore? I welcome examples of places where we do not preserve comments on tokens in the middle of nodes, as that is the general vein of comment preservation we're looking at with these.","author":{"url":"https://github.com/weswigham","@type":"Person","name":"weswigham"},"datePublished":"2017-08-09T02:52:50Z","url":"https://github.com/microsoft/TypeScript/issues/17689"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e9d8eff7-41da-d30d-1495-bc0ad9b84296
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C00:2E9831:120B02:17F83A:6B0184AE
html-safe-noncec9da23eb53de30e01f81ced3acd445d094a24db26bd560d86bbdca7065766c40
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzAwOjJFOTgzMToxMjBCMDI6MTdGODNBOjZCMDE4NEFFIiwidmlzaXRvcl9pZCI6IjcwNjkyODk0OTg3OTQ3MzMyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca1bc128c6f884dd3e7220521c8cfecc01aca95b3f63d1c8035693f5cad01e4d2
hovercard-subject-tagissue:248902459
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/17689/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c418f5e18dbbccee0c78bea986fb88963ac30664d0b6db85e247a747d26b810e/microsoft/TypeScript/issues/17689
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c418f5e18dbbccee0c78bea986fb88963ac30664d0b6db85e247a747d26b810e/microsoft/TypeScript/issues/17689
og:image:altCarrying on from the work initiated in #17557, we should improve our retention of comments where possible. We should check that we retain comments inside: BinaryExpression (#16584) ReturnStatement ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/17689#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F17689
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F17689
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/17689
Reloadhttps://github.com/microsoft/TypeScript/issues/17689
Reloadhttps://github.com/microsoft/TypeScript/issues/17689
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17689
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17689
Better comment emit on tokenshttps://github.com/microsoft/TypeScript/issues/17689#top
Domain: Comment EmitThe issue relates to the emission of comments when compilinghttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Comment%20Emit%22
Meta-IssueAn issue about the team, or the direction of TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Meta-Issue%22
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Aug 9, 2017https://github.com/microsoft/TypeScript/issues/17689#issue-248902459
#17557https://github.com/microsoft/TypeScript/pull/17557
[Master] fix 12985 emit leading and trailing comment around binary operator #16584https://github.com/microsoft/TypeScript/pull/16584
Retain comments inside return statements #17557https://github.com/microsoft/TypeScript/pull/17557
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Emit comment on catch clause #11755https://github.com/microsoft/TypeScript/issues/11755
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Comments within JSX Expressions are not preserved #41754https://github.com/microsoft/TypeScript/issues/41754
Much better comment preservation #22141https://github.com/microsoft/TypeScript/pull/22141
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Meta-IssueAn issue about the team, or the direction of TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Meta-Issue%22
on Aug 11, 2017https://github.com/microsoft/TypeScript/issues/17689#event-1202792861
Wesley Wigham (weswigham)https://github.com/weswigham
on Jan 10, 2018https://github.com/microsoft/TypeScript/issues/17689#event-1416823424
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Domain: Comment EmitThe issue relates to the emission of comments when compilinghttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Comment%20Emit%22
on Feb 23, 2018https://github.com/microsoft/TypeScript/issues/17689#event-1489787772
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Wesley Wigham (weswigham)https://github.com/weswigham
on Feb 11, 2022https://github.com/microsoft/TypeScript/issues/17689#event-6054125089
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Feb 11, 2022https://github.com/microsoft/TypeScript/issues/17689#issuecomment-1036648631
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 11, 2022https://github.com/microsoft/TypeScript/issues/17689#event-6054126258
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/17689
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17689
Domain: Comment EmitThe issue relates to the emission of comments when compilinghttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Comment%20Emit%22
Meta-IssueAn issue about the team, or the direction of TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Meta-Issue%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.