René's URL Explorer Experiment


Title: Synthesized ModuleDeclarations are missing the top level variable declaration in the emit · Issue #17596 · microsoft/TypeScript · GitHub

Open Graph Title: Synthesized ModuleDeclarations are missing the top level variable declaration in the emit · Issue #17596 · microsoft/TypeScript

X Title: Synthesized ModuleDeclarations are missing the top level variable declaration in the emit · Issue #17596 · microsoft/TypeScript

Description: TypeScript Version: 2.4.2 Context Needed by Angular / Tsickle for converting TypeScript types into closure type comments. Our workaround (see transformer_util.ts): copy the ts.Node.Symbol from the original node over to the synthetic node...

Open Graph Description: TypeScript Version: 2.4.2 Context Needed by Angular / Tsickle for converting TypeScript types into closure type comments. Our workaround (see transformer_util.ts): copy the ts.Node.Symbol from the ...

X Description: TypeScript Version: 2.4.2 Context Needed by Angular / Tsickle for converting TypeScript types into closure type comments. Our workaround (see transformer_util.ts): copy the ts.Node.Symbol from the ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/17596

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Synthesized ModuleDeclarations are missing the top level variable declaration in the emit","articleBody":"**TypeScript Version:**  2.4.2\r\n\r\n**Context**\r\nNeeded by Angular / Tsickle for converting TypeScript types into closure type comments.\r\n\r\nOur workaround (see [transformer_util.ts](https://github.com/angular/tsickle/blob/master/src/transformer_util.ts)):\r\n- copy the `ts.Node.Symbol` from the original node over to the synthetic node (note that this is an `@internal` field)\r\n\r\n**Code**\r\n\r\nPlunker is [here](https://plnkr.co/edit/Xg9s2gADI7AoEXLJ56CK?p=preview).\r\n\r\ncase.ts\r\n```ts\r\nmodule Reflect {\r\n  const x = 1;\r\n}\r\n```\r\n\r\ntransformer.ts:\r\n```\r\nfunction forceSyntheticModuleDeclaration(context: ts.TransformationContext) {\r\n  return (sourceFile: ts.SourceFile): ts.SourceFile => {\r\n    return visitNode(sourceFile);\r\n\r\n    function visitNode\u003cT extends ts.Node>(node: T) {\r\n      if (node.kind === ts.SyntaxKind.ModuleBlock) {\r\n        const md = node as ts.ModuleBlock;\r\n        return ts.updateModuleBlock(md, ts.setTextRange(ts.createNodeArray([...md.statements]));\r\n      }\r\n      return ts.visitEachChild(node, visitNode, context); \r\n    }\r\n  };\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nA top level variable statement should be emitted:\r\n```js\r\nvar Reflect;\r\n(function (Reflect) {\r\n    var x = 1;\r\n})(Reflect || (Reflect = {}));\r\n```\r\n\r\n**Actual behavior:**\r\nNo top level variable statement is emitted:\r\n```js\r\n(function (Reflect) {\r\n    var x = 1;\r\n})(Reflect || (Reflect = {}));\r\n```\r\n\r\n/cc @mprobst @evmar @alexeagle ","author":{"url":"https://github.com/tbosch","@type":"Person","name":"tbosch"},"datePublished":"2017-08-03T21:08:01Z","url":"https://github.com/microsoft/TypeScript/issues/17596"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b0e70841-4473-7920-6a00-b621dcea9a0f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBED8:4E0A:428918:54845C:6B00E6A1
html-safe-noncedcbb72686a965b2ef4026476145f7c2491917670ad434828a82dd1b3d0dddda1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUQ4OjRFMEE6NDI4OTE4OjU0ODQ1Qzo2QjAwRTZBMSIsInZpc2l0b3JfaWQiOiIyMDc1NDQ1NzM1Mjk3NDQzNDg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0bfccd05cfed786de7ed5d92c65546c092740bdee5fe0563517c09c0fe5592d0
hovercard-subject-tagissue:247835945
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/17596/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5facdde75544ab8a5841b001764746f287d3bf20c9a5b5eedbce423218dfcd75/microsoft/TypeScript/issues/17596
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5facdde75544ab8a5841b001764746f287d3bf20c9a5b5eedbce423218dfcd75/microsoft/TypeScript/issues/17596
og:image:altTypeScript Version: 2.4.2 Context Needed by Angular / Tsickle for converting TypeScript types into closure type comments. Our workaround (see transformer_util.ts): copy the ts.Node.Symbol from the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametbosch
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/17596#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F17596
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F17596
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/17596
Reloadhttps://github.com/microsoft/TypeScript/issues/17596
Reloadhttps://github.com/microsoft/TypeScript/issues/17596
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17596
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17596
Synthesized ModuleDeclarations are missing the top level variable declaration in the emithttps://github.com/microsoft/TypeScript/issues/17596#top
https://github.com/DanielRosenwasser
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.5.2https://github.com/microsoft/TypeScript/milestone/54
https://github.com/tbosch
Tobias Bosch (tbosch)https://github.com/tbosch
on Aug 3, 2017https://github.com/microsoft/TypeScript/issues/17596#issue-247835945
transformer_util.tshttps://github.com/angular/tsickle/blob/master/src/transformer_util.ts
herehttps://plnkr.co/edit/Xg9s2gADI7AoEXLJ56CK?p=preview
Martin Probst (@mprobst)https://github.com/mprobst
Evan Martin (@evmar)https://github.com/evmar
Alex Eagle (@alexeagle)https://github.com/alexeagle
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Aug 5, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1193974152
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Ron Buckton (rbuckton)https://github.com/rbuckton
on Aug 5, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1193974205
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Aug 5, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1193974265
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Ron Buckton (rbuckton)https://github.com/rbuckton
on Aug 5, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1194166670
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Aug 5, 2017https://github.com/microsoft/TypeScript/issues/17596#issuecomment-320437744
#17631https://github.com/microsoft/TypeScript/pull/17631
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 2.5https://github.com/microsoft/TypeScript/milestone/49
on Aug 5, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1194166761
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.5https://github.com/microsoft/TypeScript/milestone/49
on Aug 16, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1209118283
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Aug 16, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1209118384
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#17631https://github.com/microsoft/TypeScript/pull/17631
on Aug 17, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1209568339
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Aug 17, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1209576219
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 17, 2017https://github.com/microsoft/TypeScript/issues/17596#event-1210735863
microsofthttps://github.com/microsoft
on Jun 14, 2018https://github.com/microsoft/TypeScript/issues/17596#event-1682136679
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/17596
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17596
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.5.2https://github.com/microsoft/TypeScript/milestone/54
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.