René's URL Explorer Experiment


Title: Error using before transforms on files with decorators and class constructor parameter · Issue #17551 · microsoft/TypeScript · GitHub

Open Graph Title: Error using before transforms on files with decorators and class constructor parameter · Issue #17551 · microsoft/TypeScript

X Title: Error using before transforms on files with decorators and class constructor parameter · Issue #17551 · microsoft/TypeScript

Description: Description of the bug: When using any before transform on a file containing a class with both: a decorator a constructor parameter with a class type An error will be thrown (TypeError: Cannot read property 'exports' of undefined at reso...

Open Graph Description: Description of the bug: When using any before transform on a file containing a class with both: a decorator a constructor parameter with a class type An error will be thrown (TypeError: Cannot read...

X Description: Description of the bug: When using any before transform on a file containing a class with both: a decorator a constructor parameter with a class type An error will be thrown (TypeError: Cannot read...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/17551

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Error using before transforms on files with decorators and class constructor parameter","articleBody":"**Description of the bug:**  \r\n\r\nWhen using any before transform on a file containing a class with both:\r\n- a decorator\r\n- a constructor parameter with a class type\r\n\r\nAn error will be thrown (`TypeError: Cannot read property 'exports' of undefined at resolveNameHelper`).\r\n\r\nThis error goes away if:\r\n- the transform is removed\r\n- the transform is moved from `before` to `after`\r\n- the decorator is removed\r\n- the constructor type is changed from a class to a basic type (`boolean`, `number`, etc).\r\n\r\n**TypeScript Version:**  2.4.2\r\n\r\n**Code**\r\n\r\n```ts\r\nfunction classDecorator\u003cT extends { new(...args: any[]): {} }>(constructor: T) {\r\n  return class extends constructor { }\r\n}\r\n\r\nclass SomeClass {}\r\n\r\n@classDecorator\r\nexport class AppComponent {\r\n  constructor(test: SomeClass) { }\r\n}\r\n\r\n'change me';\r\n```\r\nReproduction of this bug requires using the transforms API.\r\n\r\nI have prepared a repository with a simple reproduction that runs this file: https://github.com/filipesilva/ts-transform-decorator-bug/blob/master/test.ts\r\n\r\n```\r\ngit clone https://github.com/filipesilva/ts-transform-decorator-bug\r\ncd ts-transform-decorator-bug\r\nnpm install\r\nnpm test\r\n```\r\n\r\n\r\n\r\n**Expected behavior:**\r\nFile is emitted without errors.\r\n\r\n**Actual behavior:**\r\nAn error is thrown:\r\n```\r\nD:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:27546\r\n                        var moduleExports = getSymbolOfNode(location).exports;\r\n                                                                     ^\r\nTypeError: Cannot read property 'exports' of undefined\r\n    at resolveNameHelper (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:27546:70)\r\n    at resolveName (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:27491:20)\r\n    at resolveEntityName (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:28152:26)\r\n    at Object.getTypeReferenceSerializationKind (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:47726:31)\r\n    at serializeTypeReferenceNode (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:52219:30)\r\n    at serializeTypeNode (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:52167:28)\r\n    at serializeTypeOfNode (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:52039:28)\r\n    at serializeParameterTypesOfNode (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:52074:42)\r\n    at addOldTypeMetadata (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:51962:98)\r\n    at addTypeMetadata (D:\\sandbox\\ts-transform-decorator-bug\\node_modules\\typescript\\lib\\typescript.js:51953:17)\r\n```\r\n\r\n/cc @rbuckton ","author":{"url":"https://github.com/filipesilva","@type":"Person","name":"filipesilva"},"datePublished":"2017-08-01T14:43:05Z","url":"https://github.com/microsoft/TypeScript/issues/17551"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9a83e605-6b55-5f07-2f01-6bc6262278f8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDD5C:154D88:1D57AA6:257CE23:6B01A206
html-safe-nonce5028880b0c1f432433cb2313bb8daf7af89bcc8675d14eb5125d8ffe044a2985
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDVDOjE1NEQ4ODoxRDU3QUE2OjI1N0NFMjM6NkIwMUEyMDYiLCJ2aXNpdG9yX2lkIjoiNjY3NTQyMTk3MjA2ODkzNDE1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7f2403c081725a20230848650afd1352f315be3dcee924ed50130b0a0db4bce5
hovercard-subject-tagissue:247093287
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/17551/issue_layout
twitter:imagehttps://opengraph.githubassets.com/86fba456a3a55f6998c2e5f455584bf381115869eeb2ab90e503079bf058a10a/microsoft/TypeScript/issues/17551
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/86fba456a3a55f6998c2e5f455584bf381115869eeb2ab90e503079bf058a10a/microsoft/TypeScript/issues/17551
og:image:altDescription of the bug: When using any before transform on a file containing a class with both: a decorator a constructor parameter with a class type An error will be thrown (TypeError: Cannot read...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefilipesilva
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/17551#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F17551
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F17551
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/17551
Reloadhttps://github.com/microsoft/TypeScript/issues/17551
Reloadhttps://github.com/microsoft/TypeScript/issues/17551
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17551
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17551
Error using before transforms on files with decorators and class constructor parameterhttps://github.com/microsoft/TypeScript/issues/17551#top
https://github.com/rbuckton
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
Domain: API: TransformsRelates to the public transform APIhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%3A%20Transforms%22
TypeScript 2.5.2https://github.com/microsoft/TypeScript/milestone/54
https://github.com/filipesilva
Filipe Silva (filipesilva)https://github.com/filipesilva
on Aug 1, 2017https://github.com/microsoft/TypeScript/issues/17551#issue-247093287
https://github.com/filipesilva/ts-transform-decorator-bug/blob/master/test.tshttps://github.com/filipesilva/ts-transform-decorator-bug/blob/master/test.ts
Ron Buckton (@rbuckton)https://github.com/rbuckton
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: API: TransformsRelates to the public transform APIhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%3A%20Transforms%22
on Aug 1, 2017https://github.com/microsoft/TypeScript/issues/17551#event-1188023740
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 2.5https://github.com/microsoft/TypeScript/milestone/49
on Aug 1, 2017https://github.com/microsoft/TypeScript/issues/17551#event-1188023874
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Ron Buckton (rbuckton)https://github.com/rbuckton
on Aug 1, 2017https://github.com/microsoft/TypeScript/issues/17551#event-1188024022
https://github.com/arciisine
Timothy Soehnlin (arciisine)https://github.com/arciisine
on Aug 14, 2017https://github.com/microsoft/TypeScript/issues/17551#issuecomment-322095786
https://github.com/arciisine
Timothy Soehnlin (arciisine)https://github.com/arciisine
on Aug 14, 2017https://github.com/microsoft/TypeScript/issues/17551#issuecomment-322172663
https://gist.github.com/arciisine/2ba754f561d3e28b138aeed686a800d3https://gist.github.com/arciisine/2ba754f561d3e28b138aeed686a800d3
https://github.com/clydin
Charles (clydin)https://github.com/clydin
on Aug 15, 2017https://github.com/microsoft/TypeScript/issues/17551#issuecomment-322521067
https://github.com/Microsoft/TypeScript/blob/master/src/compiler/transformers/ts.ts#L1875https://github.com/Microsoft/TypeScript/blob/master/src/compiler/transformers/ts.ts#L1875
https://github.com/clydin
Charles (clydin)https://github.com/clydin
on Aug 15, 2017https://github.com/microsoft/TypeScript/issues/17551#issuecomment-322521856
https://github.com/tbosch
Tobias Bosch (tbosch)https://github.com/tbosch
on Aug 15, 2017https://github.com/microsoft/TypeScript/issues/17551#issuecomment-322549177
#17384https://github.com/microsoft/TypeScript/issues/17384
https://github.com/clydin
Charles (clydin)https://github.com/clydin
on Aug 15, 2017https://github.com/microsoft/TypeScript/issues/17551#issuecomment-322571296
#17552https://github.com/microsoft/TypeScript/issues/17552
https://github.com/arciisine
Timothy Soehnlin (arciisine)https://github.com/arciisine
on Aug 16, 2017https://github.com/microsoft/TypeScript/issues/17551#issuecomment-322631100
Tobias Bosch (@tbosch)https://github.com/tbosch
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 2.5https://github.com/microsoft/TypeScript/milestone/49
on Aug 16, 2017https://github.com/microsoft/TypeScript/issues/17551#event-1209178549
Ron Buckton (rbuckton)https://github.com/rbuckton
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#18051https://github.com/microsoft/TypeScript/pull/18051
on Aug 25, 2017https://github.com/microsoft/TypeScript/issues/17551#event-1222222970
https://github.com/filipesilva
Filipe Silva (filipesilva)https://github.com/filipesilva
on Aug 25, 2017https://github.com/microsoft/TypeScript/issues/17551#issuecomment-325046558
Ron Buckton (@rbuckton)https://github.com/rbuckton
microsofthttps://github.com/microsoft
on Jun 14, 2018https://github.com/microsoft/TypeScript/issues/17551#event-1682137067
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/17551
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17551
Ron Buckton (rbuckton)https://github.com/rbuckton
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
Domain: API: TransformsRelates to the public transform APIhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%3A%20Transforms%22
TypeScript 2.5.2https://github.com/microsoft/TypeScript/milestone/54
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.