René's URL Explorer Experiment


Title: Use `Symbol.hasInstance` for `instanceof` narrowing, include constructor as part of class structural type · Issue #17360 · microsoft/TypeScript · GitHub

Open Graph Title: Use `Symbol.hasInstance` for `instanceof` narrowing, include constructor as part of class structural type · Issue #17360 · microsoft/TypeScript

X Title: Use `Symbol.hasInstance` for `instanceof` narrowing, include constructor as part of class structural type · Issue #17360 · microsoft/TypeScript

Description: My proposal: For instanceof expressions, if Symbol.hasInstance exists on the RHS, narrow the expression according to the method's return value. For classes, implicitly add a type-level constructor prototype property which is typeof class...

Open Graph Description: My proposal: For instanceof expressions, if Symbol.hasInstance exists on the RHS, narrow the expression according to the method's return value. For classes, implicitly add a type-level constructor ...

X Description: My proposal: For instanceof expressions, if Symbol.hasInstance exists on the RHS, narrow the expression according to the method's return value. For classes, implicitly add a type-level construc...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/17360

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Use `Symbol.hasInstance` for `instanceof` narrowing, include constructor as part of class structural type","articleBody":"My proposal:\r\n\r\n- For `instanceof` expressions, if `Symbol.hasInstance` exists on the RHS, narrow the expression according to the method's return value.\r\n- For classes, implicitly add a type-level `constructor` prototype property which is `typeof classConstructor`, if such a property was not defined in the class body.\r\n\r\n```ts\r\ninterface Foo { constructor: typeof Foo }\r\ndeclare const Foo: {\r\n    [Symbol.hasInstance](x: any): x is Foo\r\n}\r\n\r\ndeclare const Bar: {\r\n    [Symbol.hasInstance](x: any): x is number\r\n}\r\n\r\ndeclare const foo: any\r\ndeclare const bar: any\r\n\r\nif (foo instanceof Foo) {\r\n    // foo should be inferred as a Foo\r\n}\r\n\r\nif (bar instanceof Bar) {\r\n    // bar should be inferred as a number\r\n}\r\n```\r\n\r\nThe rationale of this is that you can then (via compiler flag) by default define `Symbol.hasInstance` on constructors to type check against their return type (like for `new () => T`, defining `[Symbol.hasInstance](x: any): x is T`). This would mostly mitigate a certain unsoundness issue with classes, making the workaround a bit more difficult to do:\r\n\r\n```ts\r\nclass Foo {\r\n    bar: number = 1;\r\n}\r\n\r\nconst foo1: Foo = new Foo() // Legal\r\nconst foo2: Foo = {bar: 2}  // No longer legal\r\n\r\n// Making these illegal are out of scope of this proposal\r\nconst foo3: Foo = {\r\n    constructor: Foo;\r\n    bar: 2,\r\n}\r\nconst foo4: Foo = new class {\r\n    bar: number = 1\r\n}\r\n```\r\n\r\n-----\r\n\r\nNotes:\r\n\r\n- This has no effect on emit.\r\n- This has no effect on JS compatibility.\r\n- This will create new type errors, and thus will be moderately breaking.\r\n- This brings type semantics more in line with JS runtime semantics.\r\n- This *shouldn't* have a substantial effect on compiler performance, since the default `Symbol.hasInstance` is equivalent to legacy `instanceof`.\r\n- This would largely fix the premise of #17344 and would reduce the need for nominal typing (#202) in a common use case.","author":{"url":"https://github.com/dead-claudia","@type":"Person","name":"dead-claudia"},"datePublished":"2017-07-22T18:01:35Z","url":"https://github.com/microsoft/TypeScript/issues/17360"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:63780f0f-68ac-6904-d033-95a491b9d45e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8934:2DBB21:26A855C:339C554:6B01AD30
html-safe-nonce2e6791c74521da7142d220cd422f39a24a8a8fbe767c39b2cbcce228d05d8a7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTM0OjJEQkIyMToyNkE4NTVDOjMzOUM1NTQ6NkIwMUFEMzAiLCJ2aXNpdG9yX2lkIjoiMjA0MDg3NjExMDQ2NzY3MzM5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac38690492ec3a01306e3dec9b6ce27274b62f5a22be6a22669a46e18edc17584d
hovercard-subject-tagissue:244861972
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/17360/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ef2ddd0da4ce3ec38e1ad30afb05dd18a72dbb03d4bbad341fd04be716f950fc/microsoft/TypeScript/issues/17360
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ef2ddd0da4ce3ec38e1ad30afb05dd18a72dbb03d4bbad341fd04be716f950fc/microsoft/TypeScript/issues/17360
og:image:altMy proposal: For instanceof expressions, if Symbol.hasInstance exists on the RHS, narrow the expression according to the method's return value. For classes, implicitly add a type-level constructor ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedead-claudia
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/17360#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F17360
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F17360
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/17360
Reloadhttps://github.com/microsoft/TypeScript/issues/17360
Reloadhttps://github.com/microsoft/TypeScript/issues/17360
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17360
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17360
#55052https://github.com/microsoft/TypeScript/pull/55052
Use Symbol.hasInstance for instanceof narrowing, include constructor as part of class structural typehttps://github.com/microsoft/TypeScript/issues/17360#top
#55052https://github.com/microsoft/TypeScript/pull/55052
Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Proposal%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com/dead-claudia
Claudia Meadows (dead-claudia)https://github.com/dead-claudia
on Jul 22, 2017https://github.com/microsoft/TypeScript/issues/17360#issue-244861972
instanceof should not exclude possible structural type #17344https://github.com/microsoft/TypeScript/issues/17344
Support some non-structural (nominal) type matching #202https://github.com/microsoft/TypeScript/issues/202
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Aug 29, 2017https://github.com/microsoft/TypeScript/issues/17360#event-1226590433
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Sep 16, 2017https://github.com/microsoft/TypeScript/issues/17360#event-1252258036
https://github.com/goodmind
andretshurotshka (goodmind)https://github.com/goodmind
on Apr 21, 2018https://github.com/microsoft/TypeScript/issues/17360#issuecomment-383303041
Wesley Wigham (weswigham)https://github.com/weswigham
Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Proposal%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on Nov 6, 2018https://github.com/microsoft/TypeScript/issues/17360#event-1950369256
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on Mar 7, 2019https://github.com/microsoft/TypeScript/issues/17360#event-2188809226
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
on Jun 9, 2019https://github.com/microsoft/TypeScript/issues/17360#issuecomment-500178105
this example in the playgroundhttps://www.typescriptlang.org/play/#src=declare%20class%20Foo%20%7B%0D%0A%20%20%20%20x%3A%20number%3B%0D%0A%20%20%20%20constructor(x%3A%20number)%3B%0D%0A%7D%0D%0A%0D%0A%2F%2F%20perfectly%20legal%0D%0Adeclare%20class%20Bar%20extends%20Foo%20%7B%0D%0A%20%20%20%20y%3A%20string%3B%0D%0A%20%20%20%20constructor(y%3A%20string%2C%20x%3A%20number)%3B%0D%0A%7D%0D%0A%0D%0Ainterface%20IFoo%20%7B%0D%0A%20%20%20%20x%3A%20number%3B%0D%0A%20%20%20%20constructor%3A%20typeof%20Foo%3B%0D%0A%7D%0D%0A%0D%0Ainterface%20IBar%20extends%20IFoo%20%7B%0D%0A%2F%2F%20error%3A%20%5E%5E%5E%5E%0D%0A%2F%2F%20%20%20Interface%20'IBar'%20incorrectly%20extends%20interface%20'IFoo'.%0D%0A%2F%2F%20%20%20%20%20Types%20of%20property%20'constructor'%20are%20incompatible.%0D%0A%2F%2F%20%20%20%20%20%20%20Type%20'typeof%20Bar'%20is%20not%20assignable%20to%20type%20'typeof%20Foo'.%0D%0A%0D%0A%20%20%20%20y%3A%20string%3B%0D%0A%20%20%20%20constructor%3A%20typeof%20Bar%3B%0D%0A%7D
https://github.com/monolithed
AA (monolithed)https://github.com/monolithed
on Apr 22, 2020https://github.com/microsoft/TypeScript/issues/17360#issuecomment-618027122
Ron Buckton (rbuckton)https://github.com/rbuckton
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#55052https://github.com/microsoft/TypeScript/pull/55052
on Sep 29, 2023https://github.com/microsoft/TypeScript/issues/17360#event-10513907960
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/17360
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/17360
Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Proposal%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.