Title: Type inference algorithm depends on function argument order? (bug?) · Issue #17237 · microsoft/TypeScript · GitHub
Open Graph Title: Type inference algorithm depends on function argument order? (bug?) · Issue #17237 · microsoft/TypeScript
X Title: Type inference algorithm depends on function argument order? (bug?) · Issue #17237 · microsoft/TypeScript
Description: TypeScript Version: 2.4.1 I have a function that has 3 parameters: function f(a: A, b: B, c: C) { // ... } I was surprised to discover that my program suddenly breaks (fails to compile) if I reorder the parameters: function f(a: A, c: C,...
Open Graph Description: TypeScript Version: 2.4.1 I have a function that has 3 parameters: function f(a: A, b: B, c: C) { // ... } I was surprised to discover that my program suddenly breaks (fails to compile) if I reorde...
X Description: TypeScript Version: 2.4.1 I have a function that has 3 parameters: function f(a: A, b: B, c: C) { // ... } I was surprised to discover that my program suddenly breaks (fails to compile) if I reorde...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/17237
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type inference algorithm depends on function argument order? (bug?)","articleBody":"**TypeScript Version:** 2.4.1\r\n\r\nI have a function that has 3 parameters:\r\n\r\n```typescript\r\nfunction f(a: A, b: B, c: C) {\r\n // ...\r\n}\r\n```\r\n\r\nI was surprised to discover that my program suddenly breaks (fails to compile) if I reorder the parameters:\r\n\r\n```typescript\r\nfunction f(a: A, c: C, b: B) {\r\n // Body is completely identical\r\n}\r\n```\r\n\r\nOf course the arguments were swapped at the call site of `f` as well. The failure is due to type inference working differently.\r\n\r\nBelow is a complete example showing the issue.\r\n\r\n`leftJoin1` and `leftJoin2` are identical functions, but with their parameter order swapped.\r\n\r\n`test1` and `test2` call `leftJoin1` and `leftJoin2` respectively (with the appropriate argument ordering).\r\n\r\nNotice that the pair of `leftJoin1` + `test1` functions works fine, while the pair of `leftJoin2` + `test2` functions is broken.\r\n\r\nTo really let this sink in: delete the functions `leftJoin2` and `test2`. Then manually swap the parameters of `leftJoin1` together with swapping the arguments to it in `test1`, and observe how the program will have changed from valid to broken.\r\n\r\n```typescript\r\n// test1 + leftJoin1\r\n//\r\n// Both these functions compile great!\r\n//\r\nexport function leftJoin1\u003cs, a extends object>(\r\n q: Q\u003cs>,\r\n s: (q: Q\u003cInner\u003cs>>) => MakeCols\u003cInner\u003cs>, a>,\r\n pred: (p: MakeCols\u003cs, a>) => Col\u003cs, boolean>\r\n ): LeftCols\u003cs, a> {\r\n q;\r\n pred;\r\n throw new Error(\"not implemented\");\r\n}\r\nexport function test1\u003cs>(q: Q\u003cs>) {\r\n leftJoin1(q,\r\n q => select(q, addressTable),\r\n address => stub(address.name) // Works fine! address: MakeCols\u003cs, Address>\r\n );\r\n}\r\n\r\n// test2 + leftJoin2\r\n//\r\n// Swap the parameters and now there is an error!\r\n//\r\nexport function leftJoin2\u003cs, a extends object>(\r\n q: Q\u003cs>,\r\n pred: (p: MakeCols\u003cs, a>) => Col\u003cs, boolean>,\r\n s: (q: Q\u003cInner\u003cs>>) => MakeCols\u003cInner\u003cs>, a>\r\n ): LeftCols\u003cs, a> {\r\n q;\r\n pred;\r\n throw new Error(\"not implemented\");\r\n}\r\nexport function test2\u003cs>(q: Q\u003cs>) {\r\n leftJoin2(q,\r\n address => stub(address.name), // Error here! address: MakeCols\u003cs, {}>\r\n q => select(q, addressTable)\r\n );\r\n}\r\n\r\n// --------------------------------------------------------------------\r\n\r\nexport class Q\u003cs> {\r\n private constructor() { }\r\n \"Q\": Q\u003cs>;\r\n s: s;\r\n}\r\n\r\nexport interface Table\u003ca> {\r\n \"Table\": Table\u003ca>\r\n a: a;\r\n}\r\n\r\nexport class Inner\u003cs> {\r\n private constructor() { }\r\n \"Inner\": Inner\u003cs>;\r\n s: s;\r\n}\r\n\r\nexport type MakeCols\u003cs, T extends object> = {\r\n [P in keyof T]: Col\u003cs, T[P]>;\r\n}\r\n\r\nexport class Col\u003cs, a> {\r\n private constructor() { }\r\n \"Col\": Col\u003cs, a>;\r\n private s: s;\r\n private a: a;\r\n}\r\n\r\nexport type LeftCols\u003cS, A> = {\r\n [P in keyof A]: Col\u003cS, A[P] | null>;\r\n}\r\n\r\n\r\nexport interface Address {\r\n readonly name: string;\r\n readonly city: string;\r\n}\r\n\r\nexport const addressTable = declareTable\u003cAddress>(\"address\");\r\n\r\nexport function declareTable\u003ca>(tableName: string): Table\u003ca> {\r\n tableName;\r\n throw new Error(\"not implemented\");\r\n}\r\n\r\nexport function select\u003cs, a extends object>(q: Q\u003cs>, table: Table\u003ca>): MakeCols\u003cs, a> {\r\n q;\r\n table;\r\n throw new Error(\"not implemented\");\r\n}\r\n\r\nexport function stub\u003cs, a>(e: Col\u003cs, a>): Col\u003cs, boolean> {\r\n e;\r\n throw new Error(\"not implemented\"); \r\n}\r\n```\r\n\r\ntsconfig.json\r\n```json\r\n{\r\n \"compilerOptions\": {\r\n \"sourceMap\": true,\r\n \"inlineSources\": true,\r\n \"declaration\": false,\r\n \"removeComments\": false,\r\n \"newLine\": \"LF\",\r\n \"preserveConstEnums\": false,\r\n \"allowUnreachableCode\": false,\r\n \"allowUnusedLabels\": false,\r\n \"forceConsistentCasingInFileNames\": true,\r\n \"noFallthroughCasesInSwitch\": true,\r\n \"noImplicitAny\": true,\r\n \"noImplicitReturns\": true,\r\n \"noImplicitThis\": true,\r\n \"noUnusedLocals\": true,\r\n \"noUnusedParameters\": true,\r\n \"strictNullChecks\": true,\r\n \"suppressExcessPropertyErrors\": false,\r\n \"suppressImplicitAnyIndexErrors\": false,\r\n \"lib\": [\r\n \"dom\",\r\n \"es2015.collection\",\r\n \"es2015.promise\",\r\n \"es2015.symbol\",\r\n \"es5\",\r\n \"es6\"\r\n ],\r\n \"noLib\": false,\r\n \"target\": \"es2015\",\r\n \"module\": \"commonjs\",\r\n \"moduleResolution\": \"node\",\r\n \"isolatedModules\": false\r\n }\r\n}\r\n```","author":{"url":"https://github.com/benny-medflyt","@type":"Person","name":"benny-medflyt"},"datePublished":"2017-07-17T00:55:20Z","url":"https://github.com/microsoft/TypeScript/issues/17237"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b2fb44cd-b473-e2b4-0053-3221904d0e54 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8CC2:3C21B:BAF7F2:F27286:6B00EB70 |
| html-safe-nonce | f8e7c7c31ddf9e76b5adcf34609a013ac5e2908bfcc17f7b77e1189929b13709 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0MyOjNDMjFCOkJBRjdGMjpGMjcyODY6NkIwMEVCNzAiLCJ2aXNpdG9yX2lkIjoiODk4MzgxOTI3NTY0MjkyMzg4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6f21bfd1a3f0f2823fd3af7f7b5e69a3d5d2b4ef2cba0dbc3372bccd629fb28c |
| hovercard-subject-tag | issue:243278950 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/17237/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d0ddc7d5e783e2f533107d93afdce04818a4a38f83f5446e6ff6b19ed4f9767d/microsoft/TypeScript/issues/17237 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d0ddc7d5e783e2f533107d93afdce04818a4a38f83f5446e6ff6b19ed4f9767d/microsoft/TypeScript/issues/17237 |
| og:image:alt | TypeScript Version: 2.4.1 I have a function that has 3 parameters: function f(a: A, b: B, c: C) { // ... } I was surprised to discover that my program suddenly breaks (fails to compile) if I reorde... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benny-medflyt |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width