Title: ProxyHandler no longer implementable in TS 2.4 · Issue #16933 · microsoft/TypeScript · GitHub
Open Graph Title: ProxyHandler no longer implementable in TS 2.4 · Issue #16933 · microsoft/TypeScript
X Title: ProxyHandler no longer implementable in TS 2.4 · Issue #16933 · microsoft/TypeScript
Description: TypeScript Version: 2.4.1 Code I have a 3rd party component that requires occasionally to think it is receiving an object like an array but with keys as the string indexes of the window of the grid it represents and the values being the ...
Open Graph Description: TypeScript Version: 2.4.1 Code I have a 3rd party component that requires occasionally to think it is receiving an object like an array but with keys as the string indexes of the window of the grid...
X Description: TypeScript Version: 2.4.1 Code I have a 3rd party component that requires occasionally to think it is receiving an object like an array but with keys as the string indexes of the window of the grid...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/16933
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ProxyHandler no longer implementable in TS 2.4","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n**TypeScript Version:** 2.4.1\r\n\r\n**Code**\r\n\r\nI have a 3rd party component that requires occasionally to think it is receiving an object like an array but with keys as the string indexes of the window of the grid it represents and the values being the row objects. (IE: if I want to pass the grid rows 5-9 of my data source I need to send it \r\n\r\n```json\r\n{ \"5\":{\"id\":5}, \"6\":{\"id\":6}, \"7\":{\"id\":7}, \"8\":{\"id\":8}, \"9\":{\"id\":9} }\r\n```\r\n\r\nI had a proxy handler that allowed me to pass in an array and a start index (so a 5 element array, and a start index of 5 in this example) and the proxy would be seen as this object by the grid.\r\n\r\nBut the code no longer compiles.\r\n\r\n```ts\r\nexport class DataProxyHandler implements ProxyHandler\u003c{}> {\r\n private static readonly descriptor: PropertyDescriptor = { configurable: true, enumerable: true, writable: false };\r\n\r\n constructor(public readonly startIndex: number, public readonly data: any[]) {\r\n }\r\n\r\n\r\n enumerate(target: {}) {\r\n return this.ownKeys(target);\r\n }\r\n\r\n get(target: {}, property: PropertyKey) {\r\n if (typeof property !== 'string') {\r\n return undefined;\r\n }\r\n const { startIndex, data } = this, index = parseInt(property);\r\n return isNaN(index) ? undefined : data[index - startIndex];\r\n }\r\n\r\n getOwnPropertyDescriptor(target: {}, p: PropertyKey) {\r\n return typeof p !== 'string' || !this.has(target, p) ? undefined : DataProxyHandler.descriptor;\r\n }\r\n\r\n getPrototypeOf(target: {}) {\r\n return Reflect.getPrototypeOf(target);\r\n }\r\n\r\n has(target: {}, property: PropertyKey) {\r\n if (typeof property !== 'string') {\r\n return false;\r\n }\r\n const { startIndex, data } = this, index = parseInt(property);\r\n return !isNaN(index) && index >= startIndex && index \u003c startIndex + data.length;\r\n }\r\n\r\n isExtensible(target: {}) {\r\n return false;\r\n }\r\n\r\n ownKeys(target: {}) {\r\n const { startIndex, data } = this;\r\n return data.map((item, index) => (startIndex + index).toString());\r\n }\r\n\r\n set(target: {}, property: PropertyKey, value: any): boolean {\r\n throw new Error('Can not set');\r\n }\r\n}\r\n\r\n```\r\n\r\n**Expected behavior:**\r\n\r\nCode would compile\r\n\r\n**Actual behavior:**\r\n\r\nTypes of property 'getOwnPropertyDescriptor' are incompatible.\r\n Type '(target: {}, p: PropertyKey) => PropertyDescriptor | undefined' is not assignable to type '((target: {}, p: PropertyKey) => PropertyDescriptor) | undefined'.\r\n Type '(target: {}, p: PropertyKey) => PropertyDescriptor | undefined' is not assignable to type '(target: {}, p: PropertyKey) => PropertyDescriptor'.\r\n Type 'PropertyDescriptor | undefined' is not assignable to type 'PropertyDescriptor'.\r\n Type 'undefined' is not assignable to type 'PropertyDescriptor'.\r\n\r\nI can get it to compile by specifying the return type of the method getOwnPropertyDescriptor as any.\r\n\r\n```ts\r\ngetOwnPropertyDescriptor(target: {}, p: PropertyKey): any {\r\n return typeof p !== 'string' || !this.has(target, p) ? undefined : DataProxyHandler.descriptor;\r\n }\r\n```\r\n","author":{"url":"https://github.com/amirburbea","@type":"Person","name":"amirburbea"},"datePublished":"2017-07-04T22:29:44Z","url":"https://github.com/microsoft/TypeScript/issues/16933"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8bd86099-00e5-21ca-1901-ecfeee214f6d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E3D4:34EA7D:3D1A7F:508F3C:6B00C607 |
| html-safe-nonce | 14fd8ec67d3907db68bcfad84679a87ff2c5f36417419cdfc24301d0efbbfe7f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0Q0OjM0RUE3RDozRDFBN0Y6NTA4RjNDOjZCMDBDNjA3IiwidmlzaXRvcl9pZCI6IjM3NzMyODI5MTc3MDc0NjYyNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c820562cfe3abccd87fa8e34b60cf0b0744a31b4694928a169e57ad402e41afb |
| hovercard-subject-tag | issue:240505157 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/16933/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1e8266351e07e2afd7f7c862822e5952b45ae3b9a0dd44d2e17a1cc613915a4c/microsoft/TypeScript/issues/16933 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1e8266351e07e2afd7f7c862822e5952b45ae3b9a0dd44d2e17a1cc613915a4c/microsoft/TypeScript/issues/16933 |
| og:image:alt | TypeScript Version: 2.4.1 Code I have a 3rd party component that requires occasionally to think it is receiving an object like an array but with keys as the string indexes of the window of the grid... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | amirburbea |
| hostname | github.com |
| expected-hostname | github.com |
| None | 98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ef013399cf0a3c324bea644a685d7c1e0f06b5b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width