Title: TypeScript 2.4.1 - TS2345 - "Property 'push' is missing in type · Issue #16802 · microsoft/TypeScript · GitHub
Open Graph Title: TypeScript 2.4.1 - TS2345 - "Property 'push' is missing in type · Issue #16802 · microsoft/TypeScript
X Title: TypeScript 2.4.1 - TS2345 - "Property 'push' is missing in type · Issue #16802 · microsoft/TypeScript
Description: TypeScript Version: 2.4.1 I will preface this with me being unclear whether this is a bug or my misunderstanding of the error (more likely), but I hope I can get some traction on it here nevertheless, please. And, thank you! Code This co...
Open Graph Description: TypeScript Version: 2.4.1 I will preface this with me being unclear whether this is a bug or my misunderstanding of the error (more likely), but I hope I can get some traction on it here neverthele...
X Description: TypeScript Version: 2.4.1 I will preface this with me being unclear whether this is a bug or my misunderstanding of the error (more likely), but I hope I can get some traction on it here neverthele...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/16802
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TypeScript 2.4.1 - TS2345 - \"Property 'push' is missing in type","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n**TypeScript Version:** 2.4.1\r\n\r\nI will preface this with me being unclear whether this is a bug or my misunderstanding of the error (more likely), but I hope I can get some traction on it here nevertheless, please. And, thank you!\r\n\r\n**Code**\r\n\r\nThis code used to work with 2.3.4 but fails in 2.4.1\r\n```ts\r\n// A *self-contained* demonstration of the problem follows...\r\nmodule app {\r\n class TypeScript24Controller {\r\n static $inject = ['$log'];\r\n\r\n constructor(private $log: ng.ILogService) {\r\n $log.debug('TypeScript24Controller constructor called.');\r\n }\r\n }\r\n\r\n angular.module('app').controller('TypeScript24Controller', TypeScript24Controller);\r\n}\r\n```\r\n\r\nStripping `private` in my constructor eliminates the error, but I do want the private property created.\r\n```ts\r\nmodule app {\r\n class TypeScript24Controller {\r\n static $inject = ['$log'];\r\n\r\n constructor($log: ng.ILogService) {\r\n $log.debug('TypeScript24Controller constructor called.');\r\n }\r\n }\r\n\r\n angular.module('app').controller('TypeScript24Controller', TypeScript24Controller);\r\n}\r\n```\r\n\r\n\r\n","author":{"url":"https://github.com/simonua","@type":"Person","name":"simonua"},"datePublished":"2017-06-28T15:01:18Z","url":"https://github.com/microsoft/TypeScript/issues/16802"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6225f831-6890-7a90-0919-ab003f70ee66 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8912:238913:2A3C6B:37DC9A:6B00C190 |
| html-safe-nonce | 747e13bf849c600bb9cc910f9a26745e7d222c31e185e6f01e13201f33b00dcc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTEyOjIzODkxMzoyQTNDNkI6MzdEQzlBOjZCMDBDMTkwIiwidmlzaXRvcl9pZCI6IjQ0ODQzNTk5NDk1MDExMjA5MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 72006b40c23a98c6ac363bf4275a30261949c360459100f5d64668629409f0be |
| hovercard-subject-tag | issue:239194338 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/16802/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1d445cc2963b07d7a618ad7c327da129452f5bd87c1171dc9da3a872ce5fece8/microsoft/TypeScript/issues/16802 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1d445cc2963b07d7a618ad7c327da129452f5bd87c1171dc9da3a872ce5fece8/microsoft/TypeScript/issues/16802 |
| og:image:alt | TypeScript Version: 2.4.1 I will preface this with me being unclear whether this is a bug or my misunderstanding of the error (more likely), but I hope I can get some traction on it here neverthele... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simonua |
| hostname | github.com |
| expected-hostname | github.com |
| None | 93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fee81a280ea86312b69448e261b418189bfd5b5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width