Title: Previous implementations of Redux reducers using combineReducers broken in 2.4.1 · Issue #16795 · microsoft/TypeScript · GitHub
Open Graph Title: Previous implementations of Redux reducers using combineReducers broken in 2.4.1 · Issue #16795 · microsoft/TypeScript
X Title: Previous implementations of Redux reducers using combineReducers broken in 2.4.1 · Issue #16795 · microsoft/TypeScript
Description: TypeScript Version: 2.4.1 Code // From Redux declaration file interface Action { type: any; } type Reducer = (state: S, action: A) => S; interface ReducersMapObject { [key: string]: Reducer
Open Graph Description: TypeScript Version: 2.4.1 Code // From Redux declaration file interface Action { type: any; } type Reducer = (state: S, action: A) => S; interface ReducersMapObject { [key: str...
X Description: TypeScript Version: 2.4.1 Code // From Redux declaration file interface Action { type: any; } type Reducer<S> = <A extends Action>(state: S, action: A) => S; interface ReducersMapObj...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/16795
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Previous implementations of Redux reducers using combineReducers broken in 2.4.1","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n**TypeScript Version:** 2.4.1\r\n**Code**\r\n\r\n```ts\r\n// From Redux declaration file\r\ninterface Action {\r\n type: any;\r\n}\r\ntype Reducer\u003cS> = \u003cA extends Action>(state: S, action: A) => S;\r\ninterface ReducersMapObject {\r\n [key: string]: Reducer\u003cany>;\r\n}\r\ndeclare function combineReducers\u003cS>(reducers: ReducersMapObject): Reducer\u003cS>;\r\n\r\n// User code\r\ninterface BsDmBaseAction extends Action {\r\n type: string; // override to a string type\r\n payload: number;\r\n}\r\n\r\ninterface State1 {\r\n id: string;\r\n data: number;\r\n}\r\n\r\nfunction statesById(state: State1[] = [], action: BsDmBaseAction): State1[] {\r\n switch (action.type) {\r\n case 'STOP': return [{id: 'status', data: action.payload}];\r\n }\r\n return state;\r\n}\r\n\r\nfunction allIds(state: string[] = [], action: BsDmBaseAction): string[] {\r\n switch (action.type) {\r\n case 'STOP': return ['status'];\r\n }\r\n return state;\r\n}\r\n\r\nconst bigReducer = combineReducers({\r\n statesById,\r\n allIds,\r\n});\r\n```\r\n\r\n**Expected behavior:**\r\nNo errors. This has been working since Typescript 1.8, and works in 2.3.4.\r\n\r\n**Actual behavior:**\r\nStarting with Typescript 2.4.1, the following error is emitted for the combineReducers call:\r\nError:(40, 36) TS2345:Argument of type '{ statesById: (state: State1[], action: BsDmBaseAction) => State1[]; allIds: (state: string[], ac...' is not assignable to parameter of type 'ReducersMapObject'.\r\n Property 'statesById' is incompatible with index signature.\r\n Type '(state: State1[], action: BsDmBaseAction) => State1[]' is not assignable to type 'Reducer\u003cany>'.\r\n Types of parameters 'action' and 'action' are incompatible.\r\n Type 'A' is not assignable to type 'BsDmBaseAction'.\r\n Type 'Action' is not assignable to type 'BsDmBaseAction'.\r\n Property 'payload' is missing in type 'Action'.\r\n\r\n**Notes**\r\nI do not see any explanation in the various notes on 'breaking changes' to explain this. There are no weak types here, which was involved in the main 'breaking change' description.\r\n","author":{"url":"https://github.com/jimsugg","@type":"Person","name":"jimsugg"},"datePublished":"2017-06-28T08:57:06Z","url":"https://github.com/microsoft/TypeScript/issues/16795"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8d2e7a36-e3ef-9e9f-d315-1b361ad8ea7e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 96DE:7A60E:D213AD:1100FEE:6B00F52B |
| html-safe-nonce | 89213ded0eec69e062d46c35d0f6e5cf4bca5a42ce5e6c5455c99470ca473f33 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkRFOjdBNjBFOkQyMTNBRDoxMTAwRkVFOjZCMDBGNTJCIiwidmlzaXRvcl9pZCI6IjExNTA1NjM2MDI2OTM0NjA5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2106ae7332d3cfc753986e99a0496b24c537db1fd3c17f52f101fd602460f261 |
| hovercard-subject-tag | issue:239096484 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/16795/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5b642e6939b7d1561be37e49947fb74111ead528b8fa7e25b99b12b66b19d898/microsoft/TypeScript/issues/16795 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5b642e6939b7d1561be37e49947fb74111ead528b8fa7e25b99b12b66b19d898/microsoft/TypeScript/issues/16795 |
| og:image:alt | TypeScript Version: 2.4.1 Code // From Redux declaration file interface Action { type: any; } type Reducer |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jimsugg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width