René's URL Explorer Experiment


Title: Previous implementations of Redux reducers using combineReducers broken in 2.4.1 · Issue #16795 · microsoft/TypeScript · GitHub

Open Graph Title: Previous implementations of Redux reducers using combineReducers broken in 2.4.1 · Issue #16795 · microsoft/TypeScript

X Title: Previous implementations of Redux reducers using combineReducers broken in 2.4.1 · Issue #16795 · microsoft/TypeScript

Description: TypeScript Version: 2.4.1 Code // From Redux declaration file interface Action { type: any; } type Reducer = (state: S, action: A) => S; interface ReducersMapObject { [key: string]: Reducer; } declare function c...

Open Graph Description: TypeScript Version: 2.4.1 Code // From Redux declaration file interface Action { type: any; } type Reducer = (state: S, action: A) => S; interface ReducersMapObject { [key: str...

X Description: TypeScript Version: 2.4.1 Code // From Redux declaration file interface Action { type: any; } type Reducer<S> = <A extends Action>(state: S, action: A) => S; interface ReducersMapObj...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/16795

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Previous implementations of Redux reducers using combineReducers broken in 2.4.1","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n**TypeScript Version:**  2.4.1\r\n**Code**\r\n\r\n```ts\r\n// From Redux declaration file\r\ninterface Action {\r\n  type: any;\r\n}\r\ntype Reducer\u003cS> = \u003cA extends Action>(state: S, action: A) => S;\r\ninterface ReducersMapObject {\r\n  [key: string]: Reducer\u003cany>;\r\n}\r\ndeclare function combineReducers\u003cS>(reducers: ReducersMapObject): Reducer\u003cS>;\r\n\r\n// User code\r\ninterface BsDmBaseAction extends Action {\r\n  type: string;  // override to a string type\r\n  payload: number;\r\n}\r\n\r\ninterface State1 {\r\n  id: string;\r\n  data: number;\r\n}\r\n\r\nfunction statesById(state: State1[] = [], action: BsDmBaseAction): State1[] {\r\n  switch (action.type) {\r\n    case 'STOP': return [{id: 'status', data: action.payload}];\r\n  }\r\n  return state;\r\n}\r\n\r\nfunction allIds(state: string[] = [], action: BsDmBaseAction): string[] {\r\n  switch (action.type) {\r\n    case 'STOP': return ['status'];\r\n  }\r\n  return state;\r\n}\r\n\r\nconst bigReducer = combineReducers({\r\n  statesById,\r\n  allIds,\r\n});\r\n```\r\n\r\n**Expected behavior:**\r\nNo errors. This has been working since Typescript 1.8, and works in 2.3.4.\r\n\r\n**Actual behavior:**\r\nStarting with Typescript 2.4.1, the following error is emitted for the combineReducers call:\r\nError:(40, 36) TS2345:Argument of type '{ statesById: (state: State1[], action: BsDmBaseAction) => State1[]; allIds: (state: string[], ac...' is not assignable to parameter of type 'ReducersMapObject'.\r\n  Property 'statesById' is incompatible with index signature.\r\n    Type '(state: State1[], action: BsDmBaseAction) => State1[]' is not assignable to type 'Reducer\u003cany>'.\r\n      Types of parameters 'action' and 'action' are incompatible.\r\n        Type 'A' is not assignable to type 'BsDmBaseAction'.\r\n          Type 'Action' is not assignable to type 'BsDmBaseAction'.\r\n            Property 'payload' is missing in type 'Action'.\r\n\r\n**Notes**\r\nI do not see any explanation in the various notes on 'breaking changes' to explain this. There are no weak types here, which was involved in the main 'breaking change' description.\r\n","author":{"url":"https://github.com/jimsugg","@type":"Person","name":"jimsugg"},"datePublished":"2017-06-28T08:57:06Z","url":"https://github.com/microsoft/TypeScript/issues/16795"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8d2e7a36-e3ef-9e9f-d315-1b361ad8ea7e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id96DE:7A60E:D213AD:1100FEE:6B00F52B
html-safe-nonce89213ded0eec69e062d46c35d0f6e5cf4bca5a42ce5e6c5455c99470ca473f33
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkRFOjdBNjBFOkQyMTNBRDoxMTAwRkVFOjZCMDBGNTJCIiwidmlzaXRvcl9pZCI6IjExNTA1NjM2MDI2OTM0NjA5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2106ae7332d3cfc753986e99a0496b24c537db1fd3c17f52f101fd602460f261
hovercard-subject-tagissue:239096484
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/16795/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5b642e6939b7d1561be37e49947fb74111ead528b8fa7e25b99b12b66b19d898/microsoft/TypeScript/issues/16795
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b642e6939b7d1561be37e49947fb74111ead528b8fa7e25b99b12b66b19d898/microsoft/TypeScript/issues/16795
og:image:altTypeScript Version: 2.4.1 Code // From Redux declaration file interface Action { type: any; } type Reducer = (state: S, action: A) => S; interface ReducersMapObject { [key: str...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejimsugg
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/16795#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F16795
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F16795
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/16795
Reloadhttps://github.com/microsoft/TypeScript/issues/16795
Reloadhttps://github.com/microsoft/TypeScript/issues/16795
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/16795
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/16795
Previous implementations of Redux reducers using combineReducers broken in 2.4.1https://github.com/microsoft/TypeScript/issues/16795#top
ExternalRelates to another program, environment, or user action which we cannot control.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22External%22
https://github.com/jimsugg
Jim Sugg (jimsugg)https://github.com/jimsugg
on Jun 28, 2017https://github.com/microsoft/TypeScript/issues/16795#issue-239096484
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Jun 28, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-311601067
strict contravariance for callback parametershttps://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#strict-contravariance-for-callback-parameters
https://github.com/jimsugg
Jim Sugg (jimsugg)https://github.com/jimsugg
on Jun 28, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-311604693
https://github.com/HerringtonDarkholme
Herrington Darkholme (HerringtonDarkholme)https://github.com/HerringtonDarkholme
on Jun 28, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-311611388
Wesley Wigham (@weswigham)https://github.com/weswigham
https://github.com/jimsugg
Jim Sugg (jimsugg)https://github.com/jimsugg
on Jun 28, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-311617282
https://github.com/jimsugg
Jim Sugg (jimsugg)https://github.com/jimsugg
on Jun 28, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-311624377
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Jun 28, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-311694677
open PRhttps://github.com/reactjs/redux/pull/2467
https://github.com/jimsugg
Jim Sugg (jimsugg)https://github.com/jimsugg
on Jun 28, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-311711848
https://github.com/DonikaV
Valerii Donika (DonikaV)https://github.com/DonikaV
on Jul 4, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-312866277
Jim Sugg (@jimsugg)https://github.com/jimsugg
https://github.com/willisplummer
willis plummer (willisplummer)https://github.com/willisplummer
on Jul 20, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-316661870
reduxjs/redux#2467https://github.com/reduxjs/redux/pull/2467
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
ExternalRelates to another program, environment, or user action which we cannot control.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22External%22
on Aug 22, 2017https://github.com/microsoft/TypeScript/issues/16795#event-1216747181
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Sep 6, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-327582282
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 6, 2017https://github.com/microsoft/TypeScript/issues/16795#event-1237462243
https://github.com/lenguyenthanh
Thanh Le (lenguyenthanh)https://github.com/lenguyenthanh
on Nov 12, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-343718621
https://github.com/jhalborg
jhalborghttps://github.com/jhalborg
on Nov 22, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-346320389
Thanh Le (@lenguyenthanh)https://github.com/lenguyenthanh
https://github.com/lenguyenthanh
Thanh Le (lenguyenthanh)https://github.com/lenguyenthanh
on Nov 22, 2017https://github.com/microsoft/TypeScript/issues/16795#issuecomment-346341838
jhalborghttps://github.com/jhalborg
reduxjs/redux#2709https://github.com/reduxjs/redux/issues/2709
microsofthttps://github.com/microsoft
on Jun 14, 2018https://github.com/microsoft/TypeScript/issues/16795#event-1682144345
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/16795
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/16795
ExternalRelates to another program, environment, or user action which we cannot control.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22External%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.