Title: Lib files leak "support" types into global namespace · Issue #15529 · microsoft/TypeScript · GitHub
Open Graph Title: Lib files leak "support" types into global namespace · Issue #15529 · microsoft/TypeScript
X Title: Lib files leak "support" types into global namespace · Issue #15529 · microsoft/TypeScript
Description: TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx) Description Core ECMAScript lib declaration files (e.g. lib.es5.d.ts) leak "internal" interface types into the global namespace. A common pattern employed in the lib files is that ...
Open Graph Description: TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx) Description Core ECMAScript lib declaration files (e.g. lib.es5.d.ts) leak "internal" interface types into the global namespace. A common pa...
X Description: TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx) Description Core ECMAScript lib declaration files (e.g. lib.es5.d.ts) leak "internal" interface types into the global namespace. A...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/15529
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Lib files leak \"support\" types into global namespace","articleBody":"\u003c!-- BUGS: Please use this template. --\u003e\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript --\u003e\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md --\u003e\r\n**TypeScript Version:** 2.2.1 / nightly (2.2.0-dev.201xxxxx)\r\n# Description\r\nCore ECMAScript lib declaration files (e.g. [lib.es5.d.ts](https://github.com/Microsoft/TypeScript/blob/master/lib/lib.es5.d.ts)) leak \"internal\" interface types into the global namespace. A common pattern employed in the lib files is that \"class\"-static features are placed in a `[TypeName]Constructor` interface and then a `const` variable of that type is declared with the same TypeName as the `[TypeName]` interface. Example:\r\n\r\n```ts\r\ninterface Object {\r\n constructor: Function;\r\n // ...\r\n}\r\n\r\ninterface ObjectConstructor {\r\n new (value?: any): Object;\r\n (): any;\r\n (value: any): any;\r\n // ...\r\n}\r\n\r\ndeclare const Object: ObjectConstructor;\r\n```\r\nThe problem is that the `ObjectConstructor` type is leaked into the global namespace. No such type is defined in the [ECMAScript 5.1 language spec](https://www.ecma-international.org/ecma-262/5.1/index.html), and yet it clutters up auto-complete suggestions.\r\n\r\nThe `[TypeName]Constructor` pattern seems like a workaround to enable certain features to be expressed in the lib files. The leaking of these types seems to be a side-effect of this construction.\r\n\r\n# Expected Behavior\r\nIncluding a core ECMAScript lib file into a project (whether by default or compilerOption) only adds types found in the associated ECMAScript specifications into the global namespace.\r\n\r\n# Actual Behavior\r\n`[TypeName]Constructor` types end up in the global namespace for any project that includes a library utilizing such a pattern.","author":{"url":"https://github.com/ericdrobinson","@type":"Person","name":"ericdrobinson"},"datePublished":"2017-05-02T15:54:27.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/15529/TypeScript/issues/15529"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bdc0f523-ef77-5e72-c2c2-c37460f28359 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA6C:2623CE:14AFD0:1D1CC0:6A621A02 |
| html-safe-nonce | fd36e652f609ee428bbea9697012507606207c0a66f3a7daa303d15a60f60d8a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTZDOjI2MjNDRToxNEFGRDA6MUQxQ0MwOjZBNjIxQTAyIiwidmlzaXRvcl9pZCI6IjgyNzcxMzk2Njc1Nzk3MDU4NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7f9641bf5a1137e7aee1998f7b16c9a364306d46e0d2d245434949fbffc09ac2 |
| hovercard-subject-tag | issue:225739811 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/15529/issue_layout |
| twitter:image | https://opengraph.githubassets.com/af9b6f00e2398e60048cec96c427af8ffe88e01c25039b8e1b6af6d9409e49d2/microsoft/TypeScript/issues/15529 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/af9b6f00e2398e60048cec96c427af8ffe88e01c25039b8e1b6af6d9409e49d2/microsoft/TypeScript/issues/15529 |
| og:image:alt | TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx) Description Core ECMAScript lib declaration files (e.g. lib.es5.d.ts) leak "internal" interface types into the global namespace. A common pa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ericdrobinson |
| hostname | github.com |
| expected-hostname | github.com |
| None | ccf61cb7ab435725b916ed640f57c45b2c4721db9469bc32656080efc5214b3e |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a7585b3d2ee639495a70ce464d0a18bad88ea12c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width