René's URL Explorer Experiment


Title: Provide a disciminated union of all available Node types · Issue #13634 · microsoft/TypeScript · GitHub

Open Graph Title: Provide a disciminated union of all available Node types · Issue #13634 · microsoft/TypeScript

X Title: Provide a disciminated union of all available Node types · Issue #13634 · microsoft/TypeScript

Description: TypeScript Version: 2.1.5 Recently in tslint development there was the idea to create a discriminated union of all ts.Nodes available in the AST. That would make it easier to switch on Node.kind and avoid the need of type assertions. It ...

Open Graph Description: TypeScript Version: 2.1.5 Recently in tslint development there was the idea to create a discriminated union of all ts.Nodes available in the AST. That would make it easier to switch on Node.kind an...

X Description: TypeScript Version: 2.1.5 Recently in tslint development there was the idea to create a discriminated union of all ts.Nodes available in the AST. That would make it easier to switch on Node.kind an...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/13634

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Provide a disciminated union of all available Node types","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n**TypeScript Version:**  2.1.5\r\n\r\nRecently in `tslint` development there was the idea to create a discriminated union of all `ts.Node`s available in the AST. That would make it easier to switch on `Node.kind` and avoid the need of type assertions. It would also simplify some of `TypeScript`'s own code like `forEachChild` in parser.ts.\r\n\r\nBefore we start to create and maintain such a union ourselves, the question is if typescript can provide anything for this use case? Given there are already unions for things like `BlockLike`, `CallLikeExpression`, etc., would it be possible to have more of them, maybe even auto generated?\r\n\r\nUnfortunately that would ultimately result in the demand for more unions for `Expression`, `Statement`, ...\r\n\r\n**Code**\r\n\r\n```ts\r\nts.forEachChild(someNode, visitNode);\r\nfunction visitNode(node: ts.Node) {\r\n  switch (node.kind) {\r\n    case ts.SyntaxKind.Identifier:\r\n      doStuff((node as ts.Identifier).text);\r\n    case ts.SyntaxKind.PropertyAssignment:\r\n      if ((node as ts.PropertyAssignment).initializer.kind === ts.SyntaxKind.Identifier)\r\n        doStuff(((node as ts.PropertyAssignment).initializer as ts.Identifier).text);\r\n     // ... to be continued\r\n  }\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\n\r\n```ts\r\nts.forEachChild(someNode, visitNode);\r\nfunction visitNode(node: ts.AllNodes) { // discriminated union of all subtypes of ts.Node\r\n  switch (node.kind) {\r\n    case ts.SyntaxKind.Identifier:\r\n      doStuff(node.text); // type can be inferred\r\n    case ts.SyntaxKind.PropertyAssignment:\r\n      if (node.initializer.kind === ts.SyntaxKind.Identifier) // node is inferred as ts.PropertyAssignment\r\n        doStuff(node.initializer.text); // node.initializer could be inferred to be ts.Identifier, would require another union for all subtypes of ts.Expression\r\n  }\r\n}\r\n```\r\n\r\n//cc  @nchen63\r\n","author":{"url":"https://github.com/ajafff","@type":"Person","name":"ajafff"},"datePublished":"2017-01-23T13:14:28Z","url":"https://github.com/microsoft/TypeScript/issues/13634"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:21b19b32-bc80-2a5f-d409-26ebc06ebc62
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8A8E:842EC:F40F06:146B1DD:6B010E8F
html-safe-nonce1f88fb155ababf8e107bbde1cba444d25acc7947314e740ada517e336d3da061
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QThFOjg0MkVDOkY0MEYwNjoxNDZCMUREOjZCMDEwRThGIiwidmlzaXRvcl9pZCI6IjY0Mjg1MDIzMjU1MTQxMTM0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacde7b31d99c1fac5b63c404ac535bca885101ed9094c962a5822b44df77b6904c
hovercard-subject-tagissue:202530478
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/13634/issue_layout
twitter:imagehttps://opengraph.githubassets.com/98d399a2de38dc054d1d4474d127c306f5053119df2d5005914d70730b41f28c/microsoft/TypeScript/issues/13634
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/98d399a2de38dc054d1d4474d127c306f5053119df2d5005914d70730b41f28c/microsoft/TypeScript/issues/13634
og:image:altTypeScript Version: 2.1.5 Recently in tslint development there was the idea to create a discriminated union of all ts.Nodes available in the AST. That would make it easier to switch on Node.kind an...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameajafff
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/13634#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F13634
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F13634
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/13634
Reloadhttps://github.com/microsoft/TypeScript/issues/13634
Reloadhttps://github.com/microsoft/TypeScript/issues/13634
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/13634
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/13634
Provide a disciminated union of all available Node typeshttps://github.com/microsoft/TypeScript/issues/13634#top
DeclinedThe issue was declined as something which matches the TypeScript visionhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Declined%22
InfrastructureIssue relates to TypeScript team infrastructurehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Infrastructure%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
on Jan 23, 2017https://github.com/microsoft/TypeScript/issues/13634#issue-202530478
Noah Chen (@nchen63)https://github.com/nchen63
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
InfrastructureIssue relates to TypeScript team infrastructurehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Infrastructure%22
on Jan 23, 2017https://github.com/microsoft/TypeScript/issues/13634#event-933187961
https://github.com/jwbay
jwbayhttps://github.com/jwbay
on Jan 24, 2017https://github.com/microsoft/TypeScript/issues/13634#issuecomment-274670488
https://github.com/babel/babel/tree/master/packages/babel-typeshttps://github.com/babel/babel/tree/master/packages/babel-types
https://github.com/adidahiya
Adi Dahiya (adidahiya)https://github.com/adidahiya
on Feb 3, 2017https://github.com/microsoft/TypeScript/issues/13634#issuecomment-277172548
generic type guard for thishttps://github.com/palantir/tslint-react/blob/70090ce4d9550d17ecf85301b3b627b67914ee17/src/guards.ts#L20
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
on Feb 3, 2017https://github.com/microsoft/TypeScript/issues/13634#issuecomment-277206545
Adi Dahiya (@adidahiya)https://github.com/adidahiya
https://github.com/rozzzly
Patrick Lienau (rozzzly)https://github.com/rozzzly
on Aug 21, 2017https://github.com/microsoft/TypeScript/issues/13634#issuecomment-323660832
Adi Dahiya (@adidahiya)https://github.com/adidahiya
[gcanti/typelevel-ts]https://github.com/gcanti/typelevel-ts
Giulio Canti (@gcanti)https://github.com/gcanti
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
https://github.com/KiaraGrouwstra
kiara (KiaraGrouwstra)https://github.com/KiaraGrouwstra
on Aug 21, 2017https://github.com/microsoft/TypeScript/issues/13634#issuecomment-323669094
#2214https://github.com/microsoft/TypeScript/issues/2214
#4183https://github.com/microsoft/TypeScript/issues/4183
#6606 (comment)https://github.com/microsoft/TypeScript/issues/6606#issuecomment-317664772
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
DeclinedThe issue was declined as something which matches the TypeScript visionhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Declined%22
on Aug 15, 2018https://github.com/microsoft/TypeScript/issues/13634#event-1790656980
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Aug 15, 2018https://github.com/microsoft/TypeScript/issues/13634#issuecomment-413289616
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 15, 2018https://github.com/microsoft/TypeScript/issues/13634#event-1790659442
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/13634
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/13634
DeclinedThe issue was declined as something which matches the TypeScript visionhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Declined%22
InfrastructureIssue relates to TypeScript team infrastructurehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Infrastructure%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.