Title: Design Meeting Notes, 11/30/2016 · Issue #12622 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 11/30/2016 · Issue #12622 · microsoft/TypeScript
X Title: Design Meeting Notes, 11/30/2016 · Issue #12622 · microsoft/TypeScript
Description: __extends and static methods / accessors skatejs reported issue Previously reported issues: Why are TS get/set definedProperties in a class transpiled as enumerable/writable? PR from @vvakame to change __extends impementation the for loo...
Open Graph Description: __extends and static methods / accessors skatejs reported issue Previously reported issues: Why are TS get/set definedProperties in a class transpiled as enumerable/writable? PR from @vvakame to ch...
X Description: __extends and static methods / accessors skatejs reported issue Previously reported issues: Why are TS get/set definedProperties in a class transpiled as enumerable/writable? PR from @vvakame to ch...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/12622
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 11/30/2016","articleBody":"# `__extends` and static methods / accessors\r\n\r\n* [skatejs reported issue](https://github.com/skatejs/skatejs/issues/936)\r\n* Previously reported issues:\r\n * [Why are TS get/set definedProperties in a class transpiled as enumerable/writable?](https://github.com/Microsoft/TypeScript/issues/3610)\r\n* [PR from @vvakame to change `__extends` impementation](https://github.com/Microsoft/TypeScript/pull/12488)\r\n\r\n* the `for` loop is there to support browsers pre `__proto__`, e.g. IE8, IE9, and IE10\r\n * if we remove it IE10 and below will be broken\r\n* Condition it:\r\n * seems like a good solution\r\n * proposal:\r\n\r\n ```ts\r\nvar __extendStatics = (this && this.__extendStatics) ||\r\n Object.setPrototypeOf || \r\n ({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) || \r\n function (d, b) { for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p]; };\r\n\r\nvar __extends = (this && this.__extends) || function (d, b) {\r\n __extendStatics(d, b);\r\n function __() { this.constructor = d; }\r\n d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());\r\n};\r\n ```\r\n\r\n * What about the other side of the issue, emitting methods and accessors as `enumrable: false`?\r\n * we have to do it for `--target ES5` and not `--target ES3`\r\n * if we do this we break the static inheritance for IE10, \r\n * concolusion:\r\n * wait on more feedback for this\r\n\r\n# `Promise` in lib.d.ts\r\n\r\n* Issues:\r\n * [[lib.d.ts BUG] navigator.mediaDevices.getUserMedia returns `PromiseLike` (actually returns a `Promise`)](https://github.com/Microsoft/TypeScript/issues/10242)\r\n * [Vague error message with async functions](https://github.com/Microsoft/TypeScript/issues/11396)\r\n\r\n* DOM keeps moving forward, but the lib.d.ts does not\r\n* Resolution:\r\n * split the DOM into multiple definitions as well, and have the parts depend on what version they need of the library\r\n * this is a large effort, not clear when or how it can be done\r\n * No conclusion here, leave it open\r\n\r\n# Extensibility (@RyanCavanaugh)\r\n\r\n* PR: [Language service proxy](https://github.com/Microsoft/TypeScript/pull/12231)\r\n* Follow up with the experement and see what APIs are needed to be exposed","author":{"url":"https://github.com/mhegazy","@type":"Person","name":"mhegazy"},"datePublished":"2016-12-02T22:47:25Z","url":"https://github.com/microsoft/TypeScript/issues/12622"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:be761567-b781-516f-3dad-f9eb17f182c9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A17E:3DF0BE:619ADA:80B0BB:6B00D26E |
| html-safe-nonce | 9c74eb969a229ce29a0461e8c377544c9014b53fa214ebee522401166268691c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTdFOjNERjBCRTo2MTlBREE6ODBCMEJCOjZCMDBEMjZFIiwidmlzaXRvcl9pZCI6IjU0NTc1MzA3NTkxNjg0NDcwODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 465af2ffb722c4b81327779e058265101e41df233c134fe3a2cfb24af27d5041 |
| hovercard-subject-tag | issue:193236486 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/12622/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ad9dbceecca4e00c2307ba273a7d3bfb561986e0ba0986f216151735ddf902d8/microsoft/TypeScript/issues/12622 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ad9dbceecca4e00c2307ba273a7d3bfb561986e0ba0986f216151735ddf902d8/microsoft/TypeScript/issues/12622 |
| og:image:alt | __extends and static methods / accessors skatejs reported issue Previously reported issues: Why are TS get/set definedProperties in a class transpiled as enumerable/writable? PR from @vvakame to ch... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhegazy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4943239a6d2c591325dad6e5c313e1cafda877f6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width