Title: Enums inconsistency · Issue #11559 · microsoft/TypeScript · GitHub
Open Graph Title: Enums inconsistency · Issue #11559 · microsoft/TypeScript
X Title: Enums inconsistency · Issue #11559 · microsoft/TypeScript
Description: In general I thought that using enums is "compatible" with using literal types - (where enums give better support for refactoring, Find all references, intellisense etc.), but seems it's not the case: Consider the code: enum S { A, B, C ...
Open Graph Description: In general I thought that using enums is "compatible" with using literal types - (where enums give better support for refactoring, Find all references, intellisense etc.), but seems it's not the ca...
X Description: In general I thought that using enums is "compatible" with using literal types - (where enums give better support for refactoring, Find all references, intellisense etc.), but seems it...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/11559
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Enums inconsistency","articleBody":"In general I thought that using enums is \"compatible\" with using literal types - (where enums give better support for refactoring, Find all references, intellisense etc.), but seems it's not the case:\n\nConsider the code:\n\n``` ts\n enum S {\n A, B, C\n }\n\n type T = 0 | 1 | 2\n\n\n function aTest(a: S) {}\n function aTest2(a: S.A | S.B) {}\n\n function bTest(b: T) {}\n function bTest2(b: 0|1) {}\n\n aTest(5) // BAD: Does not throw an error\n aTest2(S.C) // GOOD: Throws an error\n aTest2(5) // BAD: Does not throw an error\n\n bTest(5) // GOOD: Throws an error\n bTest2(5) // GOOD: Throws an error\n\n const a:S = 5 // BAD: Does not throw an error\n const b:T = 5 // GOOD: Throws an error\n```\n\nSomewhere deep in the search one can find this explanation (not in the docs) https://github.com/Microsoft/TypeScript/issues/8020#issuecomment-208717449 that TS does not distinguish between flag and non-flag enums - that's why no errors where one would expect\n\nMaybe it would be worth introducing it ? - because I guess a lot of people would prefer enums to be used as unions and have TS throw an error if someone tries to assign wrong values.\n\nIt will be even more inconsistent if string enums will make it to TS: https://github.com/Microsoft/TypeScript/issues/1206#issuecomment-240581743\n\nThe same example then:\n\n``` ts\nenum S: string {\n A,\n B = \"X\",\n C\n}\n\ntype T = 'A' | 'X' | 'C'\n\n\nfunction aTest(a: S) {}\nfunction aTest2(a: S.A | S.B) {}\n\nfunction bTest(b: T) {}\nfunction bTest2(b: 0|1) {}\n\naTest('W') // GOOD: Error\naTest2(S.C) // GOOD: Error\naTest2('W') // GOOD: Error\n\nbTest(5) // GOOD: Error\nbTest2(5) // GOOD: Error\n\nconst a:S = \"W\" // GOOD: Error\nconst b:T = \"W\" // GOOD: Error\n```\n","author":{"url":"https://github.com/normalser","@type":"Person","name":"normalser"},"datePublished":"2016-10-12T14:26:09Z","url":"https://github.com/microsoft/TypeScript/issues/11559"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:78ccef0c-243f-af73-f03d-d5e26214592c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C314:14ECB:2B826C1:3756DB2:6B01AF87 |
| html-safe-nonce | 1f515c82b4bd4fe05610893d44fe59cfe36f8d5e349b555aa226ba4b61c38b68 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzE0OjE0RUNCOjJCODI2QzE6Mzc1NkRCMjo2QjAxQUY4NyIsInZpc2l0b3JfaWQiOiIxNjQ5MzAwNjA0OTAxNzY0OTk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 735b2db2878166c5b5ad7cc70788ff9c6936ae68069c9eace363ad466226d35c |
| hovercard-subject-tag | issue:182539988 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/11559/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2bbe02a6afaf01b673ed29ae52eff0ba8035d422d4ddb0e07ca2f4217b7b88d3/microsoft/TypeScript/issues/11559 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2bbe02a6afaf01b673ed29ae52eff0ba8035d422d4ddb0e07ca2f4217b7b88d3/microsoft/TypeScript/issues/11559 |
| og:image:alt | In general I thought that using enums is "compatible" with using literal types - (where enums give better support for refactoring, Find all references, intellisense etc.), but seems it's not the ca... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | normalser |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width