René's URL Explorer Experiment


Title: ``: Fix `from_chars()` `float` tiebreaking by StephanTLavavej · Pull Request #2366 · microsoft/STL · GitHub

Open Graph Title: ``: Fix `from_chars()` `float` tiebreaking by StephanTLavavej · Pull Request #2366 · microsoft/STL

X Title: ``: Fix `from_chars()` `float` tiebreaking by StephanTLavavej · Pull Request #2366 · microsoft/STL

Description: MSVC's implementation of the C++ Standard Library. - ``: Fix `from_chars()` `float` tiebreaking by StephanTLavavej · Pull Request #2366 · microsoft/STL

Open Graph Description: Fixes #2363. from_chars() is complicated, but this root cause was simple, in isolation. It involved our only call to bignum division: STL/stl/inc/charconv Lines 158...

X Description: Fixes #2363. from_chars() is complicated, but this root cause was simple, in isolation. It involved our only call to bignum division: STL/stl/inc/charconv Lines 158...

Opengraph URL: https://github.com/microsoft/STL/pull/2366

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7e398e10-28d5-e8d9-c823-9dbc95e8d911
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA58:228C61:10B3C03:17A623F:6AF65CF8
html-safe-nonce5c6a818f3ff4da90fe87e2ee8e19a54091e980b2cf3de7a9d48a5cbf394f90d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTU4OjIyOEM2MToxMEIzQzAzOjE3QTYyM0Y6NkFGNjVDRjgiLCJ2aXNpdG9yX2lkIjoiMzMwMzc3NTA5MzExNjAwMTUyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd128075cb39736c065a430295035f2bb3adccfe3f796ebcd4ad506b719c5ecc9
hovercard-subject-tagpull_request:791602678
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/STL/2366/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1340990a0c03a523739f3eeac1124231deed43141ebeb62d3afdb64e7aeb2ac8/microsoft/STL/pull/2366
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1340990a0c03a523739f3eeac1124231deed43141ebeb62d3afdb64e7aeb2ac8/microsoft/STL/pull/2366
og:image:altFixes #2363. from_chars() is complicated, but this root cause was simple, in isolation. It involved our only call to bignum division: STL/stl/inc/charconv Lines 158...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameStephanTLavavej
hostnamegithub.com
expected-hostnamegithub.com
Nonefded9ab97d594702a6a4ebcef0ee4f94c91fb16da7c62cac91ee0125e9c2d58c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/STL git https://github.com/microsoft/STL.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id204593825
octolytics-dimension-repository_nwomicrosoft/STL
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id204593825
octolytics-dimension-repository_network_root_nwomicrosoft/STL
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39cd7745159797c426e62ba2199c584d653d4b32
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/STL/pull/2366#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FSTL%2Fpull%2F2366
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FSTL%2Fpull%2F2366
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FSTL
Reloadhttps://github.com/microsoft/STL/pull/2366
Reloadhttps://github.com/microsoft/STL/pull/2366
Reloadhttps://github.com/microsoft/STL/pull/2366
microsofthttps://github.com/microsoft
STLhttps://github.com/microsoft/STL
Codehttps://github.com/microsoft/STL
Issues556 (556)https://github.com/microsoft/STL/issues
Pull requests26 (26)https://github.com/microsoft/STL/pulls
Discussionshttps://github.com/microsoft/STL/discussions
Actionshttps://github.com/microsoft/STL/actions
Projectshttps://github.com/microsoft/STL/projects
Wikihttps://github.com/microsoft/STL/wiki
Security and qualityhttps://github.com/microsoft/STL/security
Insightshttps://github.com/microsoft/STL/pulse
https://github.com/microsoft/STL
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
microsoft:mainhttps://github.com/microsoft/STL/tree/main
StephanTLavavej:tiebreak_to_evenhttps://github.com/StephanTLavavej/STL/tree/tiebreak_to_even
Conversationhttps://github.com/microsoft/STL/pull/2366
Commits3 (3)https://github.com/microsoft/STL/pull/2366/commits
Checkshttps://github.com/microsoft/STL/pull/2366/checks
Files changedhttps://github.com/microsoft/STL/pull/2366/files
: Fix from_chars() float tiebreakinghttps://github.com/microsoft/STL/pull/2366#top
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
microsoft:mainhttps://github.com/microsoft/STL/tree/main
StephanTLavavej:tiebreak_to_evenhttps://github.com/StephanTLavavej/STL/tree/tiebreak_to_even
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
Nov 30, 2021https://github.com/microsoft/STL/pull/2366#issue-1067133528
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
#2363https://github.com/microsoft/STL/issues/2363
STL/stl/inc/charconvhttps://github.com/microsoft/STL/blob/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5/stl/inc/charconv#L1582-L1584
3c2fd04https://github.com/microsoft/STL/commit/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5
STL/stl/inc/charconvhttps://github.com/microsoft/STL/blob/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5/stl/inc/charconv#L881-L885
3c2fd04https://github.com/microsoft/STL/commit/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5
STL/stl/inc/charconvhttps://github.com/microsoft/STL/blob/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5/stl/inc/charconv#L933-L936
3c2fd04https://github.com/microsoft/STL/commit/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5
statementreplyhttps://github.com/statementreply
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/StephanTLavavej
Fix GH 2363 ": from_chars() incorrectly tiebreaks floats".https://github.com/microsoft/STL/pull/2366/commits/369619f2ea9efbdcf08f7ae10de4952aa6777ed6
369619fhttps://github.com/microsoft/STL/pull/2366/commits/369619f2ea9efbdcf08f7ae10de4952aa6777ed6
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
bug https://github.com/microsoft/STL/issues?q=state%3Aopen%20label%3Abug
Nov 30, 2021https://github.com/microsoft/STL/pull/2366#event-5691372679
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
code ownerhttps://github.com/microsoft/STL/blob/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5/.github/CODEOWNERS#L3
November 30, 2021 11:40https://github.com/microsoft/STL/pull/2366#event-5691372759
https://github.com/CaseyCarter
Casey Carter (CaseyCarter)https://github.com/CaseyCarter
Dec 1, 2021https://github.com/microsoft/STL/pull/2366#event-5702141149
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
Miya Natsuhara (mnatsuhara)https://github.com/mnatsuhara
Dec 1, 2021https://github.com/microsoft/STL/pull/2366#event-5702147407
https://github.com/AlexGuteniev
Alex Guteniev (AlexGuteniev)https://github.com/AlexGuteniev
Dec 2, 2021https://github.com/microsoft/STL/pull/2366#issuecomment-984207273
STL/stl/inc/charconvhttps://github.com/microsoft/STL/blob/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5/stl/inc/charconv#L881-L885
3c2fd04https://github.com/microsoft/STL/commit/3c2fd04d441d46ec9d914d9cbb621a3bac96c3a5
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/CaseyCarter
Casey Carter (CaseyCarter)https://github.com/CaseyCarter
Dec 2, 2021 https://github.com/microsoft/STL/pull/2366#pullrequestreview-820996706
View reviewed changes https://github.com/microsoft/STL/pull/2366/files/369619f2ea9efbdcf08f7ae10de4952aa6777ed6
tests/std/tests/P0067R5_charconv/float_from_chars_test_cases.hpphttps://github.com/microsoft/STL/pull/2366/files/369619f2ea9efbdcf08f7ae10de4952aa6777ed6#diff-25c9a9b92d028f2f422f7e54ac62821e9b5ef02bd41ca90218478d5f91cd4da0
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/CaseyCarter
Casey Carter (CaseyCarter)https://github.com/CaseyCarter
Dec 2, 2021https://github.com/microsoft/STL/pull/2366#event-5703012468
https://github.com/statementreply
statementreplyhttps://github.com/statementreply
Dec 2, 2021https://github.com/microsoft/STL/pull/2366#issuecomment-984275076
STL/stl/inc/charconvhttps://github.com/microsoft/STL/blob/369619f2ea9efbdcf08f7ae10de4952aa6777ed6/stl/inc/charconv#L439-L463
369619fhttps://github.com/microsoft/STL/commit/369619f2ea9efbdcf08f7ae10de4952aa6777ed6
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/CaseyCarter
Casey Carter (CaseyCarter)https://github.com/CaseyCarter
Dec 2, 2021https://github.com/microsoft/STL/pull/2366#issuecomment-984844235
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
Dec 4, 2021https://github.com/microsoft/STL/pull/2366#issuecomment-985949632
Alex Guteniev (@AlexGuteniev)https://github.com/AlexGuteniev
statementreplyhttps://github.com/statementreply
MSVC-PR-140796https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/140796
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
December 3, 2021 18:22https://github.com/microsoft/STL/pull/2366#commits-pushed-11c6564
https://github.com/StephanTLavavej
Remove newline.https://github.com/microsoft/STL/pull/2366/commits/11c656460df8b63285c85151d2d4c1beb8b35afd
11c6564https://github.com/microsoft/STL/pull/2366/commits/11c656460df8b63285c85151d2d4c1beb8b35afd
https://github.com/StephanTLavavej
Remove unused functions.https://github.com/microsoft/STL/pull/2366/commits/c74fbe7b4598476cfebe2902c45d5def7028c416
c74fbe7https://github.com/microsoft/STL/pull/2366/commits/c74fbe7b4598476cfebe2902c45d5def7028c416
https://github.com/CaseyCarter
Casey Carter (CaseyCarter)https://github.com/CaseyCarter
Dec 4, 2021 https://github.com/microsoft/STL/pull/2366#pullrequestreview-823298328
View reviewed changes https://github.com/microsoft/STL/pull/2366/files/c74fbe7b4598476cfebe2902c45d5def7028c416
https://github.com/chrisd-work
Christopher D (chrisd-work)https://github.com/chrisd-work
Dec 7, 2021https://github.com/microsoft/STL/pull/2366#issuecomment-987624565
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/AlexGuteniev
Alex Guteniev (AlexGuteniev)https://github.com/AlexGuteniev
Feb 4, 2022 https://github.com/microsoft/STL/pull/2366#ref-pullrequest-1123858797
Move and into C++20 #2518 https://github.com/microsoft/STL/pull/2518
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
high priority https://github.com/microsoft/STL/issues?q=state%3Aopen%20label%3A%22high%20priority%22
Feb 8, 2022https://github.com/microsoft/STL/pull/2366#event-6030313051
https://github.com/mnatsuhara
Miya Natsuhara (mnatsuhara)https://github.com/mnatsuhara
Feb 22, 2022 https://github.com/microsoft/STL/pull/2366#pullrequestreview-890265819
View reviewed changes https://github.com/microsoft/STL/pull/2366/files/c74fbe7b4598476cfebe2902c45d5def7028c416
https://github.com/mnatsuhara
Miya Natsuhara (mnatsuhara)https://github.com/mnatsuhara
Feb 22, 2022https://github.com/microsoft/STL/pull/2366#event-6120458461
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
Feb 22, 2022https://github.com/microsoft/STL/pull/2366#event-6121055151
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
Feb 22, 2022https://github.com/microsoft/STL/pull/2366#issuecomment-1048227211
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
89d50c5https://github.com/microsoft/STL/commit/89d50c5996215989516139f95e5d9f8e4037fba1
Feb 23, 2022https://github.com/microsoft/STL/pull/2366#event-6121735029
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
February 23, 2022 00:12https://github.com/microsoft/STL/pull/2366#event-6121735414
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej)https://github.com/StephanTLavavej
Mar 29, 2022 https://github.com/microsoft/STL/pull/2366#ref-pullrequest-1184226192
: _Divide can trim _Big_integer_flt more efficiently #2623 https://github.com/microsoft/STL/pull/2623
https://github.co/hiddenchars
https://github.com/microsoft/STL/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FSTL%2Fpull%2F2366
https://github.com/CaseyCarter
Casey Carter (CaseyCarter) https://github.com/CaseyCarter
https://github.com/microsoft/STL/pull/2366/files/c74fbe7b4598476cfebe2902c45d5def7028c416
https://github.com/mnatsuhara
Miya Natsuhara (mnatsuhara) https://github.com/mnatsuhara
https://github.com/microsoft/STL/pull/2366/files/c74fbe7b4598476cfebe2902c45d5def7028c416
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) https://github.com/StephanTLavavej
bug https://github.com/microsoft/STL/issues?q=state%3Aopen%20label%3Abug
high priority https://github.com/microsoft/STL/issues?q=state%3Aopen%20label%3A%22high%20priority%22
: from_chars() incorrectly tiebreaks floats https://github.com/microsoft/STL/issues/2363
Please reload this pagehttps://github.com/microsoft/STL/pull/2366
https://github.com/StephanTLavavej
https://github.com/AlexGuteniev
https://github.com/statementreply
https://github.com/CaseyCarter
https://github.com/chrisd-work
https://github.com/mnatsuhara
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.