| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:070e7c8e-b590-c3c5-ad0d-b10be393e6ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A124:363CE5:D2B47:10B5CF:698E6954 |
| html-safe-nonce | eaf629cdc46d355becd1cf12d09d838bdd711ca8fe213931357b3e2a5e263112 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTI0OjM2M0NFNTpEMkI0NzoxMEI1Q0Y6Njk4RTY5NTQiLCJ2aXNpdG9yX2lkIjoiMjkzOTc0MTEzODMyNjU0Njc3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c2c27ef9d2b52b61bcc351850a60ad62cf20171363aa675a92514b27100d1563 |
| hovercard-subject-tag | pull_request:2224716930 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
| twitter:image | https://avatars.githubusercontent.com/u/141655842?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/141655842?s=400&v=4 |
| og:image:alt | Why this PR?
Support recurrence for time window filter. Also renamed some files to follow the naming convention.
Time window filter schema: https://github.com/microsoft/FeatureManagement/blob/main/... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 666e30cc1de8ebdf458084bf731e95deba4f074a5008f91b50803aa9a71e3725 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/microsoft/FeatureManagement-JavaScript git https://github.com/microsoft/FeatureManagement-JavaScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 738639264 |
| octolytics-dimension-repository_nwo | microsoft/FeatureManagement-JavaScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 738639264 |
| octolytics-dimension-repository_network_root_nwo | microsoft/FeatureManagement-JavaScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c5daa44975c44e187dd9ea0d761c37973489d508 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FFeatureManagement-JavaScript%2Fpull%2F73%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FFeatureManagement-JavaScript%2Fpull%2F73%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FFeatureManagement-JavaScript |
| Reload | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
| Reload | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
| Reload | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
|
microsoft
| https://github.com/microsoft |
| FeatureManagement-JavaScript | https://github.com/microsoft/FeatureManagement-JavaScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FFeatureManagement-JavaScript |
|
Fork
5
| https://github.com/login?return_to=%2Fmicrosoft%2FFeatureManagement-JavaScript |
|
Star
17
| https://github.com/login?return_to=%2Fmicrosoft%2FFeatureManagement-JavaScript |
|
Code
| https://github.com/microsoft/FeatureManagement-JavaScript |
|
Issues
9
| https://github.com/microsoft/FeatureManagement-JavaScript/issues |
|
Pull requests
2
| https://github.com/microsoft/FeatureManagement-JavaScript/pulls |
|
Actions
| https://github.com/microsoft/FeatureManagement-JavaScript/actions |
|
Projects
0
| https://github.com/microsoft/FeatureManagement-JavaScript/projects |
|
Models
| https://github.com/microsoft/FeatureManagement-JavaScript/models |
|
Security
0
| https://github.com/microsoft/FeatureManagement-JavaScript/security |
|
Insights
| https://github.com/microsoft/FeatureManagement-JavaScript/pulse |
|
Code
| https://github.com/microsoft/FeatureManagement-JavaScript |
|
Issues
| https://github.com/microsoft/FeatureManagement-JavaScript/issues |
|
Pull requests
| https://github.com/microsoft/FeatureManagement-JavaScript/pulls |
|
Actions
| https://github.com/microsoft/FeatureManagement-JavaScript/actions |
|
Projects
| https://github.com/microsoft/FeatureManagement-JavaScript/projects |
|
Models
| https://github.com/microsoft/FeatureManagement-JavaScript/models |
|
Security
| https://github.com/microsoft/FeatureManagement-JavaScript/security |
|
Insights
| https://github.com/microsoft/FeatureManagement-JavaScript/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmicrosoft%2FFeatureManagement-JavaScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmicrosoft%2FFeatureManagement-JavaScript%2Fissues%2Fnew%2Fchoose |
| zhiyuanliang-ms | https://github.com/zhiyuanliang-ms |
| main | https://github.com/microsoft/FeatureManagement-JavaScript/tree/main |
| zhiyuanliang/recurring-time-window | https://github.com/microsoft/FeatureManagement-JavaScript/tree/zhiyuanliang/recurring-time-window |
|
Conversation
9
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73 |
|
Commits
13
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits |
|
Checks
5
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/checks |
|
Files changed
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
| Please reload this page | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
|
Recurring time window filter
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#top |
|
Show all changes
13 commits
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
|
f9e510a
WIP: validation finished
zhiyuanliang-ms Dec 9, 2024
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/f9e510a614d1d08a50436927d794d2cdb188fa51 |
|
92f7456
update filename
zhiyuanliang-ms Dec 9, 2024
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/92f7456cef3ce897773a8ed05911444c5c764633 |
|
b767a4c
WIP: evaluation done
zhiyuanliang-ms Dec 10, 2024
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/b767a4c8b7f345040f342f328a75fb2f1e5eb949 |
|
dae9569
add testcases
zhiyuanliang-ms Dec 10, 2024
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/dae956920cd655cd0637519680b3be076c1cc643 |
|
00bc029
fix lint
zhiyuanliang-ms Dec 10, 2024
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/00bc029b672be7b13fcb08f6c55f331b5929fc63 |
|
28d27ce
update method name
zhiyuanliang-ms Dec 12, 2024
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/28d27ce6054b6c1cd25ece403889aafa4bea03e7 |
|
1c3733e
merge main
zhiyuanliang-ms Dec 20, 2024
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/1c3733e422ce5a9f24145a01498a51f3d567cec6 |
|
aa72297
update
zhiyuanliang-ms Dec 20, 2024
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/aa722977344e61322bc314e561b5bc8460a1ef76 |
|
2448642
Merge branch 'main' of https://github.com/microsoft/FeatureManagement…
zhiyuanliang-ms Apr 18, 2025
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/244864216c0dda79f2f97f26b4f6f8b32d1a0b14 |
|
147083e
Merge branch 'main' of https://github.com/microsoft/FeatureManagement…
zhiyuanliang-ms May 13, 2025
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/147083eb1bfd74b40ce257fb30c04fd1f2b4689d |
|
101eef5
Merge branch 'main' of https://github.com/microsoft/FeatureManagement…
zhiyuanliang-ms Aug 11, 2025
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/101eef54762db54c46e176f05c16944863160b43 |
|
e7b1bd4
Merge branch 'main' of https://github.com/microsoft/FeatureManagement…
zhiyuanliang-ms Aug 11, 2025
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/e7b1bd41723095d71f69dfe7037fc5d7ee8206bd |
|
224d72c
revert change
zhiyuanliang-ms Aug 12, 2025
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/commits/224d72c9dabb7d3960d12dd270375a3095ec93a7 |
|
Clear filters
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
| Please reload this page | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
| Please reload this page | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
|
package-lock.json
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-4e5827636d0a512741a3fe68f8ce006bba32f2880fef6b9ad62c4b60bc4d3915 |
|
package.json
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-6940298ae0dc24a1907b7e0d98773a93cf9b62cc7dbd40676068611fd5bc45df |
|
evaluator.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-9a45db213826c87f7ce4e62a0ee9b5645a2c2245aabc6d6170c5c160a8fc13d4 |
|
model.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-5e5db038417293799c5812bb22bba39074a87e1a07088b76557c0e447c64d65d |
|
utils.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-1a2546523de5f1948aefe5b792bc4d26f404371d13fd36f2d138f40465078ded |
|
validator.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-6405f5a3b1762138bf470ed50ec10bbdaffbbf9f34261cd25499b418705a97b9 |
|
timeWindowFilter.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-355c6f7a85cd8ace3a76beb7f8bdd404e04c1cdfa91a1bb9b99ca8c968dd6ec7 |
|
utils.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-8276c75f030fb64916357bb7e1715ff5705c351dfcef9a09991f535fdb767aa5 |
|
featureEvaluation.test.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-deca5de42e40a2dbb474aa121217652bef1965581dbe7eb9da33888a4aed1a47 |
|
featureManager.test.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-a42a708e14bb7594a0748b447da202603e2b1f27fa549806048abc82c9921c3a |
|
noFilters.test.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-0fa22e8443521071498ca1c7f56f3c8b22e089d153e2635c0dde38f8b8db921e |
|
recurrence.test.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-a5532e925a4dba162873d60d4710d98b1090f9e0f9ec95911aef26ad05a68931 |
|
targetingFilter.test.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-a7a24272640b20ed5363312a4279e7a03974509db60e1868fb445d48e6667203 |
|
timeWindowFilter.test.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-9ee3ce0752b3cec0fb3cc500bcc5d307c726d26f365e5c7c153e1eb6722af37e |
|
variant.test.ts
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-394fcc823701adc87119f730790771ab14c46d0197f2526ad0415df2216a29ae |
| src/feature-management/package-lock.json | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-4e5827636d0a512741a3fe68f8ce006bba32f2880fef6b9ad62c4b60bc4d3915 |
|
View file
| https://github.com/microsoft/FeatureManagement-JavaScript/blob/224d72c9dabb7d3960d12dd270375a3095ec93a7/src/feature-management/package-lock.json |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
| src/feature-management/package.json | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-6940298ae0dc24a1907b7e0d98773a93cf9b62cc7dbd40676068611fd5bc45df |
|
View file
| https://github.com/microsoft/FeatureManagement-JavaScript/blob/224d72c9dabb7d3960d12dd270375a3095ec93a7/src/feature-management/package.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/{{ revealButtonHref }} |
|
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-6940298ae0dc24a1907b7e0d98773a93cf9b62cc7dbd40676068611fd5bc45df |
|
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-6940298ae0dc24a1907b7e0d98773a93cf9b62cc7dbd40676068611fd5bc45df |
|
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-6940298ae0dc24a1907b7e0d98773a93cf9b62cc7dbd40676068611fd5bc45df |
|
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-6940298ae0dc24a1907b7e0d98773a93cf9b62cc7dbd40676068611fd5bc45df |
| src/feature-management/src/filter/recurrence/evaluator.ts | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files#diff-9a45db213826c87f7ce4e62a0ee9b5645a2c2245aabc6d6170c5c160a8fc13d4 |
|
View file
| https://github.com/microsoft/FeatureManagement-JavaScript/blob/224d72c9dabb7d3960d12dd270375a3095ec93a7/src/feature-management/src/filter/recurrence/evaluator.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/{{ revealButtonHref }} |
| Please reload this page | https://github.com/microsoft/FeatureManagement-JavaScript/pull/73/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |