René's URL Explorer Experiment


Title: fix evaluation: FeatureFlag.enabled defaults to false by Eskibear · Pull Request #11 · microsoft/FeatureManagement-JavaScript · GitHub

Open Graph Title: fix evaluation: FeatureFlag.enabled defaults to false by Eskibear · Pull Request #11 · microsoft/FeatureManagement-JavaScript

X Title: fix evaluation: FeatureFlag.enabled defaults to false by Eskibear · Pull Request #11 · microsoft/FeatureManagement-JavaScript

Description: This library provides standardized APIs for enabling feature flags within JavaScript applications. Utilize this library to secure a consistent experience when developing applications that use patterns such as beta access, rollout, dark deployments, and more. - fix evaluation: FeatureFlag.enabled defaults to false by Eskibear · Pull Request #11 · microsoft/FeatureManagement-JavaScript

Open Graph Description: According to latest schema, FeatureFlag.enabled should be false by default. This PR fixes the evaluation logic and adds test cases. Schema: https://github.com/Azure/AppConfiguration/blob/d0ef7d5507...

X Description: According to latest schema, FeatureFlag.enabled should be false by default. This PR fixes the evaluation logic and adds test cases. Schema: https://github.com/Azure/AppConfiguration/blob/d0ef7d5507...

Opengraph URL: https://github.com/microsoft/FeatureManagement-JavaScript/pull/11

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1433ac94-823e-a4f4-72f1-568a19504979
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0AC:13C44A:7E1EE4:9FC841:69907BFC
html-safe-nonce426fc44aed7f03e5097a176faa56967b8587f13efa0758a5f470e481bdbeda39
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEFDOjEzQzQ0QTo3RTFFRTQ6OUZDODQxOjY5OTA3QkZDIiwidmlzaXRvcl9pZCI6IjM1NzIxMDQzNjAzMjExMjEyNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac142d66ec684d4b4c8dcfc8336511b890fe748210afcf903ba7b93d62335cbba2
hovercard-subject-tagpull_request:1879429201
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/FeatureManagement-JavaScript/11/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4cdfba3a62f0c239de6d00ea3315d93119644e7f2b5611b4602a39aa6138c08f/microsoft/FeatureManagement-JavaScript/pull/11
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4cdfba3a62f0c239de6d00ea3315d93119644e7f2b5611b4602a39aa6138c08f/microsoft/FeatureManagement-JavaScript/pull/11
og:image:altAccording to latest schema, FeatureFlag.enabled should be false by default. This PR fixes the evaluation logic and adds test cases. Schema: https://github.com/Azure/AppConfiguration/blob/d0ef7d5507...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEskibear
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/microsoft/FeatureManagement-JavaScript git https://github.com/microsoft/FeatureManagement-JavaScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id738639264
octolytics-dimension-repository_nwomicrosoft/FeatureManagement-JavaScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id738639264
octolytics-dimension-repository_network_root_nwomicrosoft/FeatureManagement-JavaScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FFeatureManagement-JavaScript%2Fpull%2F11
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FFeatureManagement-JavaScript%2Fpull%2F11
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FFeatureManagement-JavaScript
Reloadhttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11
Reloadhttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11
Reloadhttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11
microsoft https://github.com/microsoft
FeatureManagement-JavaScripthttps://github.com/microsoft/FeatureManagement-JavaScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FFeatureManagement-JavaScript
Fork 5 https://github.com/login?return_to=%2Fmicrosoft%2FFeatureManagement-JavaScript
Star 17 https://github.com/login?return_to=%2Fmicrosoft%2FFeatureManagement-JavaScript
Code https://github.com/microsoft/FeatureManagement-JavaScript
Issues 9 https://github.com/microsoft/FeatureManagement-JavaScript/issues
Pull requests 2 https://github.com/microsoft/FeatureManagement-JavaScript/pulls
Actions https://github.com/microsoft/FeatureManagement-JavaScript/actions
Projects 0 https://github.com/microsoft/FeatureManagement-JavaScript/projects
Models https://github.com/microsoft/FeatureManagement-JavaScript/models
Security 0 https://github.com/microsoft/FeatureManagement-JavaScript/security
Insights https://github.com/microsoft/FeatureManagement-JavaScript/pulse
Code https://github.com/microsoft/FeatureManagement-JavaScript
Issues https://github.com/microsoft/FeatureManagement-JavaScript/issues
Pull requests https://github.com/microsoft/FeatureManagement-JavaScript/pulls
Actions https://github.com/microsoft/FeatureManagement-JavaScript/actions
Projects https://github.com/microsoft/FeatureManagement-JavaScript/projects
Models https://github.com/microsoft/FeatureManagement-JavaScript/models
Security https://github.com/microsoft/FeatureManagement-JavaScript/security
Insights https://github.com/microsoft/FeatureManagement-JavaScript/pulse
Eskibearhttps://github.com/Eskibear
mainhttps://github.com/microsoft/FeatureManagement-JavaScript/tree/main
yanzh/fix-evaluationhttps://github.com/microsoft/FeatureManagement-JavaScript/tree/yanzh/fix-evaluation
Conversationhttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11
Commits2 (2)https://github.com/microsoft/FeatureManagement-JavaScript/pull/11/commits
Checkshttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11/checks
Files changedhttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files
fix evaluation: FeatureFlag.enabled defaults to falsehttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11#top
Eskibearhttps://github.com/Eskibear
mainhttps://github.com/microsoft/FeatureManagement-JavaScript/tree/main
yanzh/fix-evaluationhttps://github.com/microsoft/FeatureManagement-JavaScript/tree/yanzh/fix-evaluation
https://github.com/Eskibear
Eskibearhttps://github.com/Eskibear
May 21, 2024https://github.com/microsoft/FeatureManagement-JavaScript/pull/11#issue-2307166505
https://github.com/Azure/AppConfiguration/blob/d0ef7d5507b9cee15893eead5861e3b1a82d3efd/docs/FeatureManagement/FeatureFlag.v2.0.0.schema.json#L43-L49https://github.com/Azure/AppConfiguration/blob/d0ef7d5507b9cee15893eead5861e3b1a82d3efd/docs/FeatureManagement/FeatureFlag.v2.0.0.schema.json#L43-L49
Please reload this pagehttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11
https://github.com/Eskibear
fix evaluation: enabled default to falsehttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11/commits/7e0874df63db436a66aac4a52c67c39736fe9e02
7e0874dhttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11/commits/7e0874df63db436a66aac4a52c67c39736fe9e02
https://github.com/Eskibear
Eskibearhttps://github.com/Eskibear
avaniguptahttps://github.com/avanigupta
juniwanghttps://github.com/juniwang
rossgrambohttps://github.com/rossgrambo
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
May 21, 2024 03:02https://github.com/microsoft/FeatureManagement-JavaScript/pull/11#event-12873150305
https://github.com/zhiyuanliang-ms
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
May 21, 2024 https://github.com/microsoft/FeatureManagement-JavaScript/pull/11#pullrequestreview-2069035292
View reviewed changes https://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files/7e0874df63db436a66aac4a52c67c39736fe9e02
https://github.com/avanigupta
avaniguptahttps://github.com/avanigupta
May 21, 2024 https://github.com/microsoft/FeatureManagement-JavaScript/pull/11#pullrequestreview-2069123884
View reviewed changes https://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files/7e0874df63db436a66aac4a52c67c39736fe9e02
test/noFilters.test.tshttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files/7e0874df63db436a66aac4a52c67c39736fe9e02#diff-84f92fa6b2bf1ace65769f98f5952151229c02b7ca05767e6a3f8642e5073cc7
Please reload this pagehttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11
https://github.com/Eskibear
chore: Add feature flag format validation in FeatureManagerhttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11/commits/1de025d24419fa71a1be2548347d38e407ac47fd
1de025dhttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11/commits/1de025d24419fa71a1be2548347d38e407ac47fd
https://github.com/avanigupta
avaniguptahttps://github.com/avanigupta
May 22, 2024 https://github.com/microsoft/FeatureManagement-JavaScript/pull/11#pullrequestreview-2072072293
View reviewed changes https://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files/1de025d24419fa71a1be2548347d38e407ac47fd
src/featureManager.tshttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files/1de025d24419fa71a1be2548347d38e407ac47fd#diff-1e2dc403e59412cbe33ce19ad12ccc11ab42d28d9e569bbb213c44ae88710839
Please reload this pagehttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11
https://github.com/avanigupta
avaniguptahttps://github.com/avanigupta
May 23, 2024 https://github.com/microsoft/FeatureManagement-JavaScript/pull/11#pullrequestreview-2072648602
View reviewed changes https://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files/1de025d24419fa71a1be2548347d38e407ac47fd
https://github.com/Eskibear
Eskibearhttps://github.com/Eskibear
c541c29https://github.com/microsoft/FeatureManagement-JavaScript/commit/c541c29ea4339f1f7c78a245ec66a741d87df40c
May 23, 2024https://github.com/microsoft/FeatureManagement-JavaScript/pull/11#event-12902672103
https://github.com/Eskibear
Eskibearhttps://github.com/Eskibear
May 23, 2024 02:46https://github.com/microsoft/FeatureManagement-JavaScript/pull/11#event-12902672158
https://github.co/hiddenchars
https://github.com/microsoft/FeatureManagement-JavaScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FFeatureManagement-JavaScript%2Fpull%2F11
https://github.com/avanigupta
avanigupta https://github.com/avanigupta
https://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files/1de025d24419fa71a1be2548347d38e407ac47fd
https://github.com/zhiyuanliang-ms
zhiyuanliang-ms https://github.com/zhiyuanliang-ms
https://github.com/microsoft/FeatureManagement-JavaScript/pull/11/files/7e0874df63db436a66aac4a52c67c39736fe9e02
https://github.com/juniwang
juniwang https://github.com/juniwang
https://github.com/rossgrambo
rossgrambo https://github.com/rossgrambo
Please reload this pagehttps://github.com/microsoft/FeatureManagement-JavaScript/pull/11
https://github.com/Eskibear
https://github.com/avanigupta
https://github.com/zhiyuanliang-ms
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.