Title: Missing await causes true evaluation · Issue #22 · microsoft/FeatureManagement-JavaScript · GitHub
Open Graph Title: Missing await causes true evaluation · Issue #22 · microsoft/FeatureManagement-JavaScript
X Title: Missing await causes true evaluation · Issue #22 · microsoft/FeatureManagement-JavaScript
Description: if (temp.isEnabled("foo")) { button.className = "cool"; button.textContent = "Cool Button"; } else { button.className = "lame"; button.textContent = "Lame Button"; } We will always run the "cool" path here, because I didn't put an await ...
Open Graph Description: if (temp.isEnabled("foo")) { button.className = "cool"; button.textContent = "Cool Button"; } else { button.className = "lame"; button.textContent = "Lame Button"; } We will always run the "cool" p...
X Description: if (temp.isEnabled("foo")) { button.className = "cool"; button.textContent = "Cool Button"; } else { button.className = "lame"; button.textContent = "La...
Opengraph URL: https://github.com/microsoft/FeatureManagement-JavaScript/issues/22
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Missing await causes true evaluation","articleBody":"```javascript\r\nif (temp.isEnabled(\"foo\")) {\r\n button.className = \"cool\";\r\n button.textContent = \"Cool Button\";\r\n} else {\r\n button.className = \"lame\";\r\n button.textContent = \"Lame Button\";\r\n}\r\n```\r\n\r\nWe will always run the \"cool\" path here, because I didn't put an await on the isEnabled call. I think this is bad.","author":{"url":"https://github.com/rossgrambo","@type":"Person","name":"rossgrambo"},"datePublished":"2024-08-16T18:18:04.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/22/FeatureManagement-JavaScript/issues/22"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:115e13e6-04f1-3026-b22b-53d1e98f1fcf |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DABE:5C51C:157ED4B:1C65D52:698D85CF |
| html-safe-nonce | a5be23afd297f3d98d9d2a821d51ed8d5157ebbef0e1b94d98600c7888649ba1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUJFOjVDNTFDOjE1N0VENEI6MUM2NUQ1Mjo2OThEODVDRiIsInZpc2l0b3JfaWQiOiI0ODM0OTY1MzkxMzk3MDQyNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d7973775a884bf8530c5d201210d018b80acf625c201bcf338ccd702766a694b |
| hovercard-subject-tag | issue:2470743260 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/FeatureManagement-JavaScript/22/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8049ddc8f37e6b38257e13f702ac2a4936a3e653c2a52ab1bf9309754b5ef851/microsoft/FeatureManagement-JavaScript/issues/22 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8049ddc8f37e6b38257e13f702ac2a4936a3e653c2a52ab1bf9309754b5ef851/microsoft/FeatureManagement-JavaScript/issues/22 |
| og:image:alt | if (temp.isEnabled("foo")) { button.className = "cool"; button.textContent = "Cool Button"; } else { button.className = "lame"; button.textContent = "Lame Button"; } We will always run the "cool" p... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rossgrambo |
| hostname | github.com |
| expected-hostname | github.com |
| None | c0818105fa276287e9369cfdefa0a0fa7953719791ceff9b94d69623c0a4fe8a |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/FeatureManagement-JavaScript git https://github.com/microsoft/FeatureManagement-JavaScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 738639264 |
| octolytics-dimension-repository_nwo | microsoft/FeatureManagement-JavaScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 738639264 |
| octolytics-dimension-repository_network_root_nwo | microsoft/FeatureManagement-JavaScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4c8f4bd0b67d7f1472d0ab3f49827eaae062a36b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width