René's URL Explorer Experiment


Title: Debugging and throttling enhancements for directline-js by swagatmishra2007 · Pull Request #247 · microsoft/BotFramework-DirectLineJS · GitHub

Open Graph Title: Debugging and throttling enhancements for directline-js by swagatmishra2007 · Pull Request #247 · microsoft/BotFramework-DirectLineJS

X Title: Debugging and throttling enhancements for directline-js by swagatmishra2007 · Pull Request #247 · microsoft/BotFramework-DirectLineJS

Description: JavaScript client library for Microsoft Bot Framework's Direct Line protocol - Debugging and throttling enhancements for directline-js by swagatmishra2007 · Pull Request #247 · microsoft/BotFramework-DirectLineJS

Open Graph Description: Added support for retry-after header and version information for directline-js to the useragent. Interfaced out dependencies with side effects (like Ajax) to make the main code more unit testable a...

X Description: Added support for retry-after header and version information for directline-js to the useragent. Interfaced out dependencies with side effects (like Ajax) to make the main code more unit testable a...

Opengraph URL: https://github.com/microsoft/BotFramework-DirectLineJS/pull/247

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:01eb97e0-e133-ca5d-c306-73bff40f149b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCC6:EF8DE:200DF2E:2BFA7BD:6A4EC2ED
html-safe-nonce3cc02a7e4af0876910c982f22b7fc2df255365c3459d3c0a9c91f6cd50a8841b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0M2OkVGOERFOjIwMERGMkU6MkJGQTdCRDo2QTRFQzJFRCIsInZpc2l0b3JfaWQiOiI5MDk4NzA5ODMxMTg3ODc0NTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc84a09621ab98bc92c7ad6262f8bee4bb5b9effcef8f72e5243b6d118121823d
hovercard-subject-tagpull_request:344214540
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/BotFramework-DirectLineJS/247/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/42f8411d8fd636b6d9e2ca717939344a13b06a89228cd9c8e511f3c37afcd97d/microsoft/BotFramework-DirectLineJS/pull/247
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/42f8411d8fd636b6d9e2ca717939344a13b06a89228cd9c8e511f3c37afcd97d/microsoft/BotFramework-DirectLineJS/pull/247
og:image:altAdded support for retry-after header and version information for directline-js to the useragent. Interfaced out dependencies with side effects (like Ajax) to make the main code more unit testable a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameswagatmishra2007
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/BotFramework-DirectLineJS git https://github.com/microsoft/BotFramework-DirectLineJS.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id79851706
octolytics-dimension-repository_nwomicrosoft/BotFramework-DirectLineJS
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id79851706
octolytics-dimension-repository_network_root_nwomicrosoft/BotFramework-DirectLineJS
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FBotFramework-DirectLineJS%2Fpull%2F247
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FBotFramework-DirectLineJS%2Fpull%2F247
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FBotFramework-DirectLineJS
Reloadhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
Reloadhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
Reloadhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
microsoft https://github.com/microsoft
BotFramework-DirectLineJShttps://github.com/microsoft/BotFramework-DirectLineJS
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FBotFramework-DirectLineJS
Fork 131 https://github.com/login?return_to=%2Fmicrosoft%2FBotFramework-DirectLineJS
Star 200 https://github.com/login?return_to=%2Fmicrosoft%2FBotFramework-DirectLineJS
Code https://github.com/microsoft/BotFramework-DirectLineJS
Issues 69 https://github.com/microsoft/BotFramework-DirectLineJS/issues
Pull requests 5 https://github.com/microsoft/BotFramework-DirectLineJS/pulls
Actions https://github.com/microsoft/BotFramework-DirectLineJS/actions
Projects https://github.com/microsoft/BotFramework-DirectLineJS/projects
Models https://github.com/microsoft/BotFramework-DirectLineJS/models
Wiki https://github.com/microsoft/BotFramework-DirectLineJS/wiki
Security and quality 0 https://github.com/microsoft/BotFramework-DirectLineJS/security
Insights https://github.com/microsoft/BotFramework-DirectLineJS/pulse
Code https://github.com/microsoft/BotFramework-DirectLineJS
Issues https://github.com/microsoft/BotFramework-DirectLineJS/issues
Pull requests https://github.com/microsoft/BotFramework-DirectLineJS/pulls
Actions https://github.com/microsoft/BotFramework-DirectLineJS/actions
Projects https://github.com/microsoft/BotFramework-DirectLineJS/projects
Models https://github.com/microsoft/BotFramework-DirectLineJS/models
Wiki https://github.com/microsoft/BotFramework-DirectLineJS/wiki
Security and quality https://github.com/microsoft/BotFramework-DirectLineJS/security
Insights https://github.com/microsoft/BotFramework-DirectLineJS/pulse
swagatmishra2007https://github.com/swagatmishra2007
masterhttps://github.com/microsoft/BotFramework-DirectLineJS/tree/master
wportnoy/DLJS-Testshttps://github.com/microsoft/BotFramework-DirectLineJS/tree/wportnoy/DLJS-Tests
Conversationhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
Commits35 (35)https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits
Checkshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/checks
Files changedhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files
Debugging and throttling enhancements for directline-jshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247#top
swagatmishra2007https://github.com/swagatmishra2007
masterhttps://github.com/microsoft/BotFramework-DirectLineJS/tree/master
wportnoy/DLJS-Testshttps://github.com/microsoft/BotFramework-DirectLineJS/tree/wportnoy/DLJS-Tests
https://github.com/swagatmishra2007
swagatmishra2007https://github.com/swagatmishra2007
Nov 21, 2019https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#issue-526818502
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
willportnoyhttps://github.com/willportnoy
November 1, 2019 12:25https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#commits-pushed-05e3228
https://github.com/willportnoy
injectable IScheduler, WebSocket, ajax serviceshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/05e32287b4b4fa7914a393c085336a7b3f629b58
05e3228https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/05e32287b4b4fa7914a393c085336a7b3f629b58
https://github.com/willportnoy
basic test with mockshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/7335badc7b12df1a7cabfc6d93e7718190ca1e1a
7335badhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/7335badc7b12df1a7cabfc6d93e7718190ca1e1a
https://github.com/willportnoy
enable auto attach for VSCode debugging:https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/410b05a60a59b153f1c3eb28625885f472a5fef6
410b05ahttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/410b05a60a59b153f1c3eb28625885f472a5fef6
https://github.com/willportnoy
default to async schedulerhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/2b7a4fcff6e8924208dcdd908f34fc4cdf488cac
2b7a4fchttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/2b7a4fcff6e8924208dcdd908f34fc4cdf488cac
https://github.com/willportnoy
log verbs for ajax requestshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/76f52aac6d11f1979d20615da0a208ebaa3d0858
76f52aahttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/76f52aac6d11f1979d20615da0a208ebaa3d0858
https://github.com/willportnoy
implement watermarks and replay on reconnecthttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/b776757fbe6857cfc00504879c00f8e03bed834f
b776757https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/b776757fbe6857cfc00504879c00f8e03bed834f
https://github.com/willportnoy
mock Math.random for repeatable testshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/26530c72a323a2c696e20c87aa4a414bde5ac48d
26530c7https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/26530c72a323a2c696e20c87aa4a414bde5ac48d
https://github.com/willportnoy
mock conversation token supporthttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/8b4b02e6a93a08e9335ddf5ae8319ce6e26192fa
8b4b02ehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/8b4b02e6a93a08e9335ddf5ae8319ce6e26192fa
https://github.com/willportnoy
refactor mocks to separate modulehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/0a2d637354f9696289e018186f037191a7e913e0
0a2d637https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/0a2d637354f9696289e018186f037191a7e913e0
https://github.com/willportnoy
factor out mockActivityhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/e24d915d8316200ad12ae070dd98a53de2e41bd6
e24d915https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/e24d915d8316200ad12ae070dd98a53de2e41bd6
https://github.com/willportnoy
move into suitehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/0d1b3755e266d6027388a17d2e503c26aaaee1eb
0d1b375https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/0d1b3755e266d6027388a17d2e503c26aaaee1eb
https://github.com/willportnoy
factor out mockServerhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/d8f86b551f3e20405d1ddc5c9ba86127324ee61d
d8f86b5https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/d8f86b551f3e20405d1ddc5c9ba86127324ee61d
https://github.com/willportnoy
factor out mockServiceshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/0f3b2a07562a71ab768e88340d404d879e9bf8ca
0f3b2a0https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/0f3b2a07562a71ab768e88340d404d879e9bf8ca
https://github.com/willportnoy
lazy concat for observable generatorhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/d5a689b79ffa60353036d84e6dd039ad51b20e87
d5a689bhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/d5a689b79ffa60353036d84e6dd039ad51b20e87
https://github.com/willportnoy
handle errors in pumphttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/087781563442934dcd0b0a6fccd136070e29fe8e
0877815https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/087781563442934dcd0b0a6fccd136070e29fe8e
https://github.com/willportnoy
factor out injectClosehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/88d653d9bdecfe504f5a97f59ce6d2b14d7d7ef7
88d653dhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/88d653d9bdecfe504f5a97f59ce6d2b14d7d7ef7
https://github.com/willportnoy
factor out beforeEach and afterEachhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/7fa4a80c8aa2f1fe10b62364cb8376bb7f5acccd
7fa4a80https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/7fa4a80c8aa2f1fe10b62364cb8376bb7f5acccd
https://github.com/willportnoy
share test datahttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/6773bb24f36bf4482f9214168c56ebc449ce8a45
6773bb2https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/6773bb24f36bf4482f9214168c56ebc449ce8a45
https://github.com/willportnoy
simple happy path testhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/2a96aabf4d4c4ae2d70a36d071f64e562ce02a9c
2a96aabhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/2a96aabf4d4c4ae2d70a36d071f64e562ce02a9c
https://github.com/willportnoy
rearrange mocks to logical orderhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/31cfa759a27cf08db967984973e8175a2492a468
31cfa75https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/31cfa759a27cf08db967984973e8175a2492a468
https://github.com/willportnoy
factor out conversation statehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/f3cfc9f5354c461cf1f0959cf5255267d4d91151
f3cfc9fhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/f3cfc9f5354c461cf1f0959cf5255267d4d91151
add version info to useragent in dljshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/264faaa11bce92478f28190a69848428fb663195
264faaahttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/264faaa11bce92478f28190a69848428fb663195
https://github.com/willportnoy
injectNewToken for mock serverhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/c197cb8c2ab1ec36d62f4bb988b7bb1a455deaa3
c197cb8https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/c197cb8c2ab1ec36d62f4bb988b7bb1a455deaa3
untested:support retry-after header for 429https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/657feecbb1a0bde3045f14dda4c5e8c2346b99da
657feechttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/657feecbb1a0bde3045f14dda4c5e8c2346b99da
https://github.com/swagatmishra2007
found bug in start conversation. failing test for retry after addedhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/1d4afd58e0fd2bfb527905f3e7e92da122fb1521
1d4afd5https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/1d4afd58e0fd2bfb527905f3e7e92da122fb1521
https://github.com/willportnoy
use proper casing of async schedulerhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/fe3588a224f3b3e3d2bd8da151d22bdb0a06ba61
fe3588ahttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/fe3588a224f3b3e3d2bd8da151d22bdb0a06ba61
https://github.com/swagatmishra2007
almost got retries to workhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/bcc5aac31d39e999dbb33934089f87ee80322657
bcc5aachttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/bcc5aac31d39e999dbb33934089f87ee80322657
https://github.com/willportnoy
use scheduler and return on all paths from wrapWithRetryhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/b8c2151d7a93854427c79b7a691adbf745de814f
b8c2151https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/b8c2151d7a93854427c79b7a691adbf745de814f
https://github.com/willportnoy
catch expected failure from post activityhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/42695bf83a50358808db20a0dbeba6652cf314f5
42695bfhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/42695bf83a50358808db20a0dbeba6652cf314f5
https://github.com/willportnoy
extra commentshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/57f3bb005c4403695b95ad17c87d0c7470c6d869
57f3bb0https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/57f3bb005c4403695b95ad17c87d0c7470c6d869
November 7, 2019 16:46https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#commits-pushed-4b2603f
added debug header support and happy path test for it. Tests pass sep…https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/4b2603fb8af9e5b2e649bae12cc0f0cefb84c3a2
4b2603fhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/4b2603fb8af9e5b2e649bae12cc0f0cefb84c3a2
fixing retry after test. (work in progress)https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/7eb8afce6372af562d33f8cb80f9f4ec76f30116
7eb8afchttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/7eb8afce6372af562d33f8cb80f9f4ec76f30116
have all test cases passhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/1a4df49b7546b72326875dcd145ef2d92c38e17e
1a4df49https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/1a4df49b7546b72326875dcd145ef2d92c38e17e
https://github.com/swagatmishra2007
swagatmishra2007https://github.com/swagatmishra2007
compulimhttps://github.com/compulim
willportnoyhttps://github.com/willportnoy
November 21, 2019 20:16https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#event-2821026811
https://github.com/compulim
compulimhttps://github.com/compulim
Dec 5, 2019 https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#pullrequestreview-327889984
View reviewed changes https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e
src/directLine.test.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-3634e0ef72dd34de4935c7469445a1a01b262c3d8fa262603a8b8cc676e63106
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.test.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-3634e0ef72dd34de4935c7469445a1a01b262c3d8fa262603a8b8cc676e63106
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.test.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-3634e0ef72dd34de4935c7469445a1a01b262c3d8fa262603a8b8cc676e63106
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.test.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-3634e0ef72dd34de4935c7469445a1a01b262c3d8fa262603a8b8cc676e63106
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.test.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-3634e0ef72dd34de4935c7469445a1a01b262c3d8fa262603a8b8cc676e63106
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-9c0a10cba439fb31624eba7be37cf2600d947f62d7d634daff3d607ea81036c7
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-9c0a10cba439fb31624eba7be37cf2600d947f62d7d634daff3d607ea81036c7
compulimhttps://github.com/compulim
Dec 5, 2019https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#discussion_r354583145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-9c0a10cba439fb31624eba7be37cf2600d947f62d7d634daff3d607ea81036c7
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-9c0a10cba439fb31624eba7be37cf2600d947f62d7d634daff3d607ea81036c7
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
src/directLine.tshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e#diff-9c0a10cba439fb31624eba7be37cf2600d947f62d7d634daff3d607ea81036c7
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
swagatmishra2007https://github.com/swagatmishra2007
December 10, 2019 16:19https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#commits-pushed-506c918
https://github.com/swagatmishra2007
https://github.com/compulim
Apply suggestions from code reviewhttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/506c918dc72266f7cd5f14ec28b849197b03d466
506c918https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/506c918dc72266f7cd5f14ec28b849197b03d466
address more commentshttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/bef233e1560b68a076aa571293ea003f3c988381
bef233ehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247/commits/bef233e1560b68a076aa571293ea003f3c988381
https://github.com/swagatmishra2007
swagatmishra2007https://github.com/swagatmishra2007
41f5df3https://github.com/microsoft/BotFramework-DirectLineJS/commit/41f5df397a413d8878b9d570dffad2d50a3bc87e
Dec 11, 2019https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#event-2872542882
https://github.com/swagatmishra2007
swagatmishra2007https://github.com/swagatmishra2007
December 11, 2019 00:30https://github.com/microsoft/BotFramework-DirectLineJS/pull/247#event-2872543150
https://github.co/hiddenchars
https://github.com/microsoft/BotFramework-DirectLineJS/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FBotFramework-DirectLineJS%2Fpull%2F247
https://github.com/compulim
compulim https://github.com/compulim
https://github.com/microsoft/BotFramework-DirectLineJS/pull/247/files/1a4df49b7546b72326875dcd145ef2d92c38e17e
https://github.com/willportnoy
willportnoy https://github.com/willportnoy
Please reload this pagehttps://github.com/microsoft/BotFramework-DirectLineJS/pull/247
https://github.com/swagatmishra2007
https://github.com/compulim
https://github.com/willportnoy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.