Title: Bug: bottom beam height is not correctly calculated · Issue #5 · matthewcpp/ABCUnity · GitHub
Open Graph Title: Bug: bottom beam height is not correctly calculated · Issue #5 · matthewcpp/ABCUnity
X Title: Bug: bottom beam height is not correctly calculated · Issue #5 · matthewcpp/ABCUnity
Description: Consider system M:4/4 L:1/4 V:1 V:2 clef=bass K:C [V:1] z1/2z1/2z1/2[EAC]1/2[EF]1/2[EF]1/2z | [V:2] z1/2z1/2z1/2[E,A,C]1/2[G,A,]1/2[G,A,]1/2z| Result: If I change ABCUnity/Runtime/Scripts/NoteCreator.cs Line 668 in 279e5ac stemHeight = M...
Open Graph Description: Consider system M:4/4 L:1/4 V:1 V:2 clef=bass K:C [V:1] z1/2z1/2z1/2[EAC]1/2[EF]1/2[EF]1/2z | [V:2] z1/2z1/2z1/2[E,A,C]1/2[G,A,]1/2[G,A,]1/2z| Result: If I change ABCUnity/Runtime/Scripts/NoteCreat...
X Description: Consider system M:4/4 L:1/4 V:1 V:2 clef=bass K:C [V:1] z1/2z1/2z1/2[EAC]1/2[EF]1/2[EF]1/2z | [V:2] z1/2z1/2z1/2[E,A,C]1/2[G,A,]1/2[G,A,]1/2z| Result: If I change ABCUnity/Runtime/Scripts/NoteCreat...
Opengraph URL: https://github.com/matthewcpp/ABCUnity/issues/5
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: bottom beam height is not correctly calculated","articleBody":"Consider system\r\n```\r\nM:4/4\r\nL:1/4\r\nV:1\r\nV:2 clef=bass\r\nK:C\r\n[V:1] z1/2z1/2z1/2[EAC]1/2[EF]1/2[EF]1/2z |\r\n[V:2] z1/2z1/2z1/2[E,A,C]1/2[G,A,]1/2[G,A,]1/2z|\r\n```\r\n\r\nResult:\r\n\r\n\r\nIf I change https://github.com/matthewcpp/ABCUnity/blob/279e5ac1aa0c4ecfbebf53706082048b425260ff/Runtime/Scripts/NoteCreator.cs#L668\r\nto \r\n```\r\nelse if (beam.stemHeight != Beam.unspecifiedStemHeight)\r\n{\r\n // beam contains notes at different heights, used the calculated stem height\r\n stemHeight = Mathf.Abs(stemHeight);\r\n}\r\n```\r\nthen it changes to \r\n\r\nNot sure if the Mathf.Abs is needed there anymore. Also, simple notes do not seem to have this problem. I tested various systems after this change and it seems to work correctly now (although bottom stems are tiny bit longer). \r\nI am not going to create PR because I have too many modifications.","author":{"url":"https://github.com/EpsilonD3lta","@type":"Person","name":"EpsilonD3lta"},"datePublished":"2024-12-08T10:56:40.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/5/ABCUnity/issues/5"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:27079380-13c5-7b7f-f213-3c544ae65b4f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A350:6A6D7:E3D715:139EEEF:6A4C9DB1 |
| html-safe-nonce | 6f40a198da9cada3685aad79b055718d8c2af41c9c79042967fc1772cbb859ea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzUwOjZBNkQ3OkUzRDcxNToxMzlFRUVGOjZBNEM5REIxIiwidmlzaXRvcl9pZCI6Ijg3NDg3MzczMjQ0NzEwNjYwMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5c43971a4dcf09f84f6b6faddeca452ccfc7be0ef2547c7e42a7371830c97c00 |
| hovercard-subject-tag | issue:2725118535 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matthewcpp/ABCUnity/5/issue_layout |
| twitter:image | https://opengraph.githubassets.com/13cfb22b8b5bad282420ca5bb32e64eb4bc7a6c60f72ca0131066f86be597ea2/matthewcpp/ABCUnity/issues/5 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/13cfb22b8b5bad282420ca5bb32e64eb4bc7a6c60f72ca0131066f86be597ea2/matthewcpp/ABCUnity/issues/5 |
| og:image:alt | Consider system M:4/4 L:1/4 V:1 V:2 clef=bass K:C [V:1] z1/2z1/2z1/2[EAC]1/2[EF]1/2[EF]1/2z | [V:2] z1/2z1/2z1/2[E,A,C]1/2[G,A,]1/2[G,A,]1/2z| Result: If I change ABCUnity/Runtime/Scripts/NoteCreat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | EpsilonD3lta |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| go-import | github.com/matthewcpp/ABCUnity git https://github.com/matthewcpp/ABCUnity.git |
| octolytics-dimension-user_id | 2367648 |
| octolytics-dimension-user_login | matthewcpp |
| octolytics-dimension-repository_id | 253341741 |
| octolytics-dimension-repository_nwo | matthewcpp/ABCUnity |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 253341741 |
| octolytics-dimension-repository_network_root_nwo | matthewcpp/ABCUnity |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ae90d426644ca15e89bacceb72e51f4e9dbf85f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width