René's URL Explorer Experiment


Title: FIX: clabel manual spacing was incorrect by jklymak · Pull Request #9989 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: clabel manual spacing was incorrect by jklymak · Pull Request #9989 · matplotlib/matplotlib

X Title: FIX: clabel manual spacing was incorrect by jklymak · Pull Request #9989 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary Fixes #9988. This fails some tests, but I'd argue it fails them correctly. Certainly the situation in #9988 is not acceptable. The tests weren't catching this error because the...

X Description: PR Summary Fixes #9988. This fails some tests, but I'd argue it fails them correctly. Certainly the situation in #9988 is not acceptable. The tests weren't catching this error bec...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/9989

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b9942e1d-f5e7-8f04-8874-d035174432c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A22:19730C:4F442A:6B3B6A:6A51C82B
html-safe-nonce22c73c1160b7743ee446279c2fc3f57802ea6121b5342be6484b41b745d6f3cc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTIyOjE5NzMwQzo0RjQ0MkE6NkIzQjZBOjZBNTFDODJCIiwidmlzaXRvcl9pZCI6IjEyNzExMjgzODY1ODUwODU5OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccceb81b54894bf0e2be577680f7f9ebc1814556a5ede06a8794e5d8071009fec
hovercard-subject-tagpull_request:157966239
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/9989/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a3d016301c7f3a226dfc04790022e944aab8e4f4ae26ab485741bec84fb31811/matplotlib/matplotlib/pull/9989
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a3d016301c7f3a226dfc04790022e944aab8e4f4ae26ab485741bec84fb31811/matplotlib/matplotlib/pull/9989
og:image:altPR Summary Fixes #9988. This fails some tests, but I'd argue it fails them correctly. Certainly the situation in #9988 is not acceptable. The tests weren't catching this error because the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejklymak
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/9989#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F9989
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F9989
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/9989
Reloadhttps://github.com/matplotlib/matplotlib/pull/9989
Reloadhttps://github.com/matplotlib/matplotlib/pull/9989
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
dstansbyhttps://github.com/dstansby
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:Fix-clabel-manual-spacehttps://github.com/jklymak/matplotlib/tree/Fix-clabel-manual-space
Conversationhttps://github.com/matplotlib/matplotlib/pull/9989
Commits2 (2)https://github.com/matplotlib/matplotlib/pull/9989/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/9989/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/9989/files
FIX: clabel manual spacing was incorrecthttps://github.com/matplotlib/matplotlib/pull/9989#top
dstansbyhttps://github.com/dstansby
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:Fix-clabel-manual-spacehttps://github.com/jklymak/matplotlib/tree/Fix-clabel-manual-space
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 12, 2017https://github.com/matplotlib/matplotlib/pull/9989#issue-281573071
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
#9988https://github.com/matplotlib/matplotlib/issues/9988
#9988https://github.com/matplotlib/matplotlib/issues/9988
https://user-images.githubusercontent.com/1562854/33914030-12356f0c-df51-11e7-9513-cf48d5d36fee.png
https://user-images.githubusercontent.com/1562854/33913965-ca430a42-df50-11e7-9f1b-ae2bae0f7d40.png
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/jklymak
FIX: clabel manual spacing was incorrecthttps://github.com/matplotlib/matplotlib/pull/9989/commits/326b4711d877cfef71b9708a2f822c04a4a65683
326b471https://github.com/matplotlib/matplotlib/pull/9989/commits/326b4711d877cfef71b9708a2f822c04a4a65683
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 12, 2017 https://github.com/matplotlib/matplotlib/pull/9989#ref-issue-281568091
Contours are not removed correctly when using clabel with manual #9988 https://github.com/matplotlib/matplotlib/issues/9988
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 12, 2017https://github.com/matplotlib/matplotlib/pull/9989#event-1384652931
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/67a45dcdccbc264b35c98766dfd1cdffbcd46b53..ec24f95e7725f4dbe0ef6e34dab17b0eefd2932d
67a45dchttps://github.com/matplotlib/matplotlib/commit/67a45dcdccbc264b35c98766dfd1cdffbcd46b53
ec24f95https://github.com/matplotlib/matplotlib/commit/ec24f95e7725f4dbe0ef6e34dab17b0eefd2932d
Compare https://github.com/matplotlib/matplotlib/compare/67a45dcdccbc264b35c98766dfd1cdffbcd46b53..ec24f95e7725f4dbe0ef6e34dab17b0eefd2932d
December 13, 2017 00:18https://github.com/matplotlib/matplotlib/pull/9989#event-1384696531
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 13, 2017 https://github.com/matplotlib/matplotlib/pull/9989#pullrequestreview-83041153
View reviewed changes https://github.com/matplotlib/matplotlib/pull/9989/files
lib/matplotlib/tests/test_contour.pyhttps://github.com/matplotlib/matplotlib/pull/9989/files#diff-56298727b96c2c05776fa59f72ae5f189bb16d046d5452cf8379a1fe55906bdc
tacaswellhttps://github.com/tacaswell
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#discussion_r156546138
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
jklymakhttps://github.com/jklymak
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#discussion_r156546659
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
jklymakhttps://github.com/jklymak
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#discussion_r156548181
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
tacaswellhttps://github.com/tacaswell
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#discussion_r156548962
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#issuecomment-351256402
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#issuecomment-351257396
@tacaswellhttps://github.com/tacaswell
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/d9ea3295244441e9ac12ad339b81e96496e0d5e4..39019660835f3570cbb3ad6cf872357a2ef442c1
d9ea329https://github.com/matplotlib/matplotlib/commit/d9ea3295244441e9ac12ad339b81e96496e0d5e4
3901966https://github.com/matplotlib/matplotlib/commit/39019660835f3570cbb3ad6cf872357a2ef442c1
Compare https://github.com/matplotlib/matplotlib/compare/d9ea3295244441e9ac12ad339b81e96496e0d5e4..39019660835f3570cbb3ad6cf872357a2ef442c1
December 13, 2017 02:05https://github.com/matplotlib/matplotlib/pull/9989#event-1384798360
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 13, 2017 https://github.com/matplotlib/matplotlib/pull/9989#pullrequestreview-83044129
View reviewed changes https://github.com/matplotlib/matplotlib/pull/9989/files
lib/matplotlib/contour.pyhttps://github.com/matplotlib/matplotlib/pull/9989/files#diff-b3f136a845ae5b7383fbc2be280c64af12352a6583ace9658cc4f6e2479df4a3
tacaswellhttps://github.com/tacaswell
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#discussion_r156548723
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
jklymakhttps://github.com/jklymak
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#discussion_r156549187
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
tacaswellhttps://github.com/tacaswell
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#discussion_r156550287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
jklymakhttps://github.com/jklymak
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#discussion_r156555938
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#issuecomment-351259553
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#issuecomment-351261485
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#issuecomment-351262180
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/39019660835f3570cbb3ad6cf872357a2ef442c1..934b936099f0797f859acbbfa2247caae8a6ff2c
3901966https://github.com/matplotlib/matplotlib/commit/39019660835f3570cbb3ad6cf872357a2ef442c1
934b936https://github.com/matplotlib/matplotlib/commit/934b936099f0797f859acbbfa2247caae8a6ff2c
Compare https://github.com/matplotlib/matplotlib/compare/39019660835f3570cbb3ad6cf872357a2ef442c1..934b936099f0797f859acbbfa2247caae8a6ff2c
December 13, 2017 03:15https://github.com/matplotlib/matplotlib/pull/9989#event-1384858323
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#issuecomment-351270307
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/jklymak
TST: updated test imageshttps://github.com/matplotlib/matplotlib/pull/9989/commits/815601d41fc813d64241f70147179169d95217ff
815601dhttps://github.com/matplotlib/matplotlib/pull/9989/commits/815601d41fc813d64241f70147179169d95217ff
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/934b936099f0797f859acbbfa2247caae8a6ff2c..815601d41fc813d64241f70147179169d95217ff
934b936https://github.com/matplotlib/matplotlib/commit/934b936099f0797f859acbbfa2247caae8a6ff2c
815601dhttps://github.com/matplotlib/matplotlib/commit/815601d41fc813d64241f70147179169d95217ff
Compare https://github.com/matplotlib/matplotlib/compare/934b936099f0797f859acbbfa2247caae8a6ff2c..815601d41fc813d64241f70147179169d95217ff
December 13, 2017 03:24https://github.com/matplotlib/matplotlib/pull/9989#event-1384865305
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 13, 2017https://github.com/matplotlib/matplotlib/pull/9989#issuecomment-351271471
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 13, 2017 https://github.com/matplotlib/matplotlib/pull/9989#pullrequestreview-83055135
View reviewed changes https://github.com/matplotlib/matplotlib/pull/9989/files/815601d41fc813d64241f70147179169d95217ff
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Dec 14, 2017 https://github.com/matplotlib/matplotlib/pull/9989#pullrequestreview-83488051
View reviewed changes https://github.com/matplotlib/matplotlib/pull/9989/files/815601d41fc813d64241f70147179169d95217ff
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
49d5cedhttps://github.com/matplotlib/matplotlib/commit/49d5ced86c4dd3b8ce4ec8db235a1c49b9ae2f0f
Dec 14, 2017https://github.com/matplotlib/matplotlib/pull/9989#event-1387588645
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v2.2.0https://github.com/matplotlib/matplotlib/milestone/31
Feb 12, 2018https://github.com/matplotlib/matplotlib/pull/9989#event-1470633159
https://github.com/jklymak
jklymakhttps://github.com/jklymak
March 5, 2019 16:10https://github.com/matplotlib/matplotlib/pull/9989#event-2181438491
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F9989
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/9989/files/815601d41fc813d64241f70147179169d95217ff
https://github.com/dstansby
dstansby https://github.com/dstansby
https://github.com/matplotlib/matplotlib/pull/9989/files/815601d41fc813d64241f70147179169d95217ff
v2.2.0 https://github.com/matplotlib/matplotlib/milestone/31
Contours are not removed correctly when using clabel with manual https://github.com/matplotlib/matplotlib/issues/9988
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9989
https://github.com/jklymak
https://github.com/tacaswell
https://github.com/dstansby
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.