Title: Explicit tool registration. by anntzer · Pull Request #9941 · matplotlib/matplotlib · GitHub
Open Graph Title: Explicit tool registration. by anntzer · Pull Request #9941 · matplotlib/matplotlib
X Title: Explicit tool registration. by anntzer · Pull Request #9941 · matplotlib/matplotlib
Description: @fariza This is more or less how I would bikeshed the thing... The advantage is that if someone wants to override some other tool for their backend (say, Quit), they don't have to go fiddle with the global dictionary. Plus other arguments listed in #8712. Perhaps an even better way to do this would be to store the tool classes as attribiutes (subclasses) of the respective FigureManager classes, as this will make inheritance automatic (i.e. gtk3agg will know to go find the tools on the gtk3 figuremanager). PR Summary PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: @fariza This is more or less how I would bikeshed the thing... The advantage is that if someone wants to override some other tool for their backend (say, Quit), they don't have to go fiddle wit...
X Description: @fariza This is more or less how I would bikeshed the thing... The advantage is that if someone wants to override some other tool for their backend (say, Quit), they don't have to go fiddle...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/9941
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:14ac9dd5-7df4-b526-4dc8-4bf385cc6767 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E820:23AA91:1D1B406:27BB286:6A548836 |
| html-safe-nonce | d2da90b2ae61c83183d2dc767ae3064e529c75f251dbaff5415dcabe7c1daffe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODIwOjIzQUE5MToxRDFCNDA2OjI3QkIyODY6NkE1NDg4MzYiLCJ2aXNpdG9yX2lkIjoiODg2NDEzMDkwMjMwMjk1MTQ3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c763a1d994e4c153a49f0ad6b791f6e157ee126ebcab081c9f5112e5eaa2f1af |
| hovercard-subject-tag | pull_request:156611404 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/9941/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | @fariza This is more or less how I would bikeshed the thing... The advantage is that if someone wants to override some other tool for their backend (say, Quit), they don't have to go fiddle wit... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 03ccb116376fd46e8ba2a4cdc541e35f13f70734 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width