René's URL Explorer Experiment


Title: [WiP] FIX/ENH: include (offset, on-off seq) as a valid pattern to the linestyle validator (fix #9792) by afvincent · Pull Request #9797 · matplotlib/matplotlib · GitHub

Open Graph Title: [WiP] FIX/ENH: include (offset, on-off seq) as a valid pattern to the linestyle validator (fix #9792) by afvincent · Pull Request #9797 · matplotlib/matplotlib

X Title: [WiP] FIX/ENH: include (offset, on-off seq) as a valid pattern to the linestyle validator (fix #9792) by afvincent · Pull Request #9797 · matplotlib/matplotlib

Description: PR Summary Currently, the linestyle validation considers the pattern (offset, on-off sequence) as invalid, which can raise issues as linestyle can be converted internally to such a pattern. See for example the issue #9792 for an example where it occurs when existing a style context manager. To be honest, I do not remember exactly why I chose not to support this kind of linestyle patterns in _validate_linestyle when I made it stricter in #8040 🐑... This PR: adds a bit of extra logic in _validate_linestyle to accept inputs of the form (offset, (valid...) on-off sequence); update the relevant test in test_rcparams, notably because such inputs were formerly raising exceptions; tries to preserve the former behavior with other corner cases (mainly something like ["1.23", "4.56"], which was OK before, as unfortunate it may be). With this PR, the example given in #7972 now goes smoothly and as expected. Should I add an (non image) test in test_style inspired from this issue, or are the updates that I made in test_rcparams enough? PR Checklist Has Pytest style unit tests (at least locally with Python 3) [?] Code is PEP 8 compliant (waiting for CI to decide) New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) [?] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way Should I add an entry in api_changes?

Open Graph Description: PR Summary Currently, the linestyle validation considers the pattern (offset, on-off sequence) as invalid, which can raise issues as linestyle can be converted internally to such a pattern. See for...

X Description: PR Summary Currently, the linestyle validation considers the pattern (offset, on-off sequence) as invalid, which can raise issues as linestyle can be converted internally to such a pattern. See for...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/9797

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1426949e-0ee4-b624-a14e-f4e0cf489b61
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF86:333E4B:100B63D:15783A5:6A541F6C
html-safe-nonceebed19ef61e1fe9130303fb1004ce7c97dd3ed65192afa2a2bd0a668b3657acd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjg2OjMzM0U0QjoxMDBCNjNEOjE1NzgzQTU6NkE1NDFGNkMiLCJ2aXNpdG9yX2lkIjoiNzc1MjQwMzEyMDUyMTc0ODMzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca906066129e7a96e3140ed0590425f3384f05a4806fa70430bbf49ae812a7e1c
hovercard-subject-tagpull_request:152972367
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/9797/files
twitter:imagehttps://avatars.githubusercontent.com/u/17270724?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17270724?s=400&v=4
og:image:altPR Summary Currently, the linestyle validation considers the pattern (offset, on-off sequence) as invalid, which can raise issues as linestyle can be converted internally to such a pattern. See for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/9797/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F9797%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F9797%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/9797/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/9797/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/9797/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
afvincenthttps://github.com/afvincent
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
afvincent:fix_add_none_onoff_to_ls_validatorhttps://github.com/afvincent/matplotlib/tree/fix_add_none_onoff_to_ls_validator
Conversation 10 https://github.com/matplotlib/matplotlib/pull/9797
Commits 2 https://github.com/matplotlib/matplotlib/pull/9797/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/9797/checks
Files changed https://github.com/matplotlib/matplotlib/pull/9797/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
[WiP] FIX/ENH: include (offset, on-off seq) as a valid pattern to the linestyle validator (fix #9792) https://github.com/matplotlib/matplotlib/pull/9797/files#top
Show all changes 2 commits https://github.com/matplotlib/matplotlib/pull/9797/files
612d6d0 add offset-onoffseq pattern to ls validation afvincent Nov 16, 2017 https://github.com/matplotlib/matplotlib/pull/9797/commits/612d6d0c27cff76bbcda3cf4bdcd4844f10ed95f
ffd3434 update the relevant test afvincent Nov 16, 2017 https://github.com/matplotlib/matplotlib/pull/9797/commits/ffd3434891a779c3a43c3edc54352739cb61ad3d
Clear filters https://github.com/matplotlib/matplotlib/pull/9797/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
rcsetup.py https://github.com/matplotlib/matplotlib/pull/9797/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
test_rcparams.py https://github.com/matplotlib/matplotlib/pull/9797/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
lib/matplotlib/rcsetup.pyhttps://github.com/matplotlib/matplotlib/pull/9797/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
View file https://github.com/afvincent/matplotlib/blob/ffd3434891a779c3a43c3edc54352739cb61ad3d/lib/matplotlib/rcsetup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/9797/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/9797/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/9797/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/9797/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
Kojoleyhttps://github.com/Kojoley
Nov 17, 2017https://github.com/matplotlib/matplotlib/pull/9797/files#r151730894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
afvincenthttps://github.com/afvincent
Nov 17, 2017https://github.com/matplotlib/matplotlib/pull/9797/files#r151750230
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
tacaswellhttps://github.com/tacaswell
Nov 19, 2017https://github.com/matplotlib/matplotlib/pull/9797/files#r151877431
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
afvincenthttps://github.com/afvincent
Nov 21, 2017https://github.com/matplotlib/matplotlib/pull/9797/files#r152175353
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@tacaswellhttps://github.com/tacaswell
@Kojoleyhttps://github.com/Kojoley
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
tacaswellhttps://github.com/tacaswell
Nov 19, 2017https://github.com/matplotlib/matplotlib/pull/9797/files#r151877583
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
afvincenthttps://github.com/afvincent
Nov 21, 2017https://github.com/matplotlib/matplotlib/pull/9797/files#r152176000
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Kojoleyhttps://github.com/Kojoley
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
Kojoleyhttps://github.com/Kojoley
Nov 19, 2017https://github.com/matplotlib/matplotlib/pull/9797/files#r151875942
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
afvincenthttps://github.com/afvincent
Nov 21, 2017https://github.com/matplotlib/matplotlib/pull/9797/files#r152175877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9797/files
https://github.com/matplotlib/matplotlib/pull/9797/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
lib/matplotlib/tests/test_rcparams.pyhttps://github.com/matplotlib/matplotlib/pull/9797/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
View file https://github.com/afvincent/matplotlib/blob/ffd3434891a779c3a43c3edc54352739cb61ad3d/lib/matplotlib/tests/test_rcparams.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/9797/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/9797/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
https://github.com/matplotlib/matplotlib/pull/9797/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.