René's URL Explorer Experiment


Title: BUG: Fix weird behavior with mask and units (Fixes #8908) by dopplershift · Pull Request #9049 · matplotlib/matplotlib · GitHub

Open Graph Title: BUG: Fix weird behavior with mask and units (Fixes #8908) by dopplershift · Pull Request #9049 · matplotlib/matplotlib

X Title: BUG: Fix weird behavior with mask and units (Fixes #8908) by dopplershift · Pull Request #9049 · matplotlib/matplotlib

Description: Refactor many places that check for masked arrays, and fill the masked values with nans, with a helper to accomplish that. In the helper, replace the isinstance check with a attribute check for 'mask'. This allows libraries, like pint, that wrap mask arrays to pass the check and be converted appropriately. Also fix one spot using atleast_1d with _check_1d.

Open Graph Description: Refactor many places that check for masked arrays, and fill the masked values with nans, with a helper to accomplish that. In the helper, replace the isinstance check with a attribute check for ...

X Description: Refactor many places that check for masked arrays, and fill the masked values with nans, with a helper to accomplish that. In the helper, replace the isinstance check with a attribute check for &am...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/9049

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6b4a66a0-7baf-c40e-ce86-c0a057b9a949
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD144:12D35A:CB97D1:11254A1:6A52A439
html-safe-nonced190961a5238d8f0a61bf725c554c96935526bad5c5edc7d134fd8d7c2a32cc1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTQ0OjEyRDM1QTpDQjk3RDE6MTEyNTRBMTo2QTUyQTQzOSIsInZpc2l0b3JfaWQiOiIzNTAzNTQ3NzIyOTg3OTA2MTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb159d610c6e010b3321934e286703395e42aedb1d0788a5f3e96e2020d4b4caa
hovercard-subject-tagpull_request:136167677
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/9049/files
twitter:imagehttps://avatars.githubusercontent.com/u/221526?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/221526?s=400&v=4
og:image:altRefactor many places that check for masked arrays, and fill the masked values with nans, with a helper to accomplish that. In the helper, replace the isinstance check with a attribute check for ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/9049/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F9049%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F9049%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/9049/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/9049/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/9049/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9049/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9049/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
dstansbyhttps://github.com/dstansby
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
dopplershift:fix-8908https://github.com/dopplershift/matplotlib/tree/fix-8908
Conversation 10 https://github.com/matplotlib/matplotlib/pull/9049
Commits 4 https://github.com/matplotlib/matplotlib/pull/9049/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/9049/checks
Files changed https://github.com/matplotlib/matplotlib/pull/9049/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9049/files
BUG: Fix weird behavior with mask and units (Fixes #8908) https://github.com/matplotlib/matplotlib/pull/9049/files#top
Show all changes 4 commits https://github.com/matplotlib/matplotlib/pull/9049/files
acfd016 BUG: Fix weird behavior with mask and units (Fixes #8908) dopplershift Aug 17, 2017 https://github.com/matplotlib/matplotlib/pull/9049/commits/acfd0163a89f91069c205130590bc9f881696989
a90064e ENH: Add test for masked units behavior dopplershift Aug 17, 2017 https://github.com/matplotlib/matplotlib/pull/9049/commits/a90064ebac99a8a0f135a2b264de55e7d74dc3e4
6eb96c8 TST: Add test for pint (and alike) behavior (#8910) dopplershift Aug 18, 2017 https://github.com/matplotlib/matplotlib/pull/9049/commits/6eb96c80d107579c45f43f6912b9ad2530869a9c
0525c6b ENH: Update view limits on units change dopplershift Aug 23, 2017 https://github.com/matplotlib/matplotlib/pull/9049/commits/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb
Clear filters https://github.com/matplotlib/matplotlib/pull/9049/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9049/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9049/files
_base.py https://github.com/matplotlib/matplotlib/pull/9049/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
__init__.py https://github.com/matplotlib/matplotlib/pull/9049/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
lines.py https://github.com/matplotlib/matplotlib/pull/9049/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
path.py https://github.com/matplotlib/matplotlib/pull/9049/files#diff-732128c2653eae0f24d387b13fac9d2aed0a716c21e79e4ef68dcc7300c97562
plot_masked_units.png https://github.com/matplotlib/matplotlib/pull/9049/files#diff-f3a608a8e2279d13346ac7e1f59723fc311706ddb380682f3d9b5f799f998d03
plot_pint.png https://github.com/matplotlib/matplotlib/pull/9049/files#diff-1bcc08144fd898e3ed5bb75f9a839d483c785b6a88787199c7ad2d8554fcf0a5
test_units.py https://github.com/matplotlib/matplotlib/pull/9049/files#diff-944789d5a5e7410e170a0a5d899cd8db1464784f16acc1cab829b758e69bd025
axes3d.py https://github.com/matplotlib/matplotlib/pull/9049/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
lib/matplotlib/axes/_base.pyhttps://github.com/matplotlib/matplotlib/pull/9049/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
View file https://github.com/dopplershift/matplotlib/blob/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb/lib/matplotlib/axes/_base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/9049/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
lib/matplotlib/cbook/__init__.pyhttps://github.com/matplotlib/matplotlib/pull/9049/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
View file https://github.com/dopplershift/matplotlib/blob/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb/lib/matplotlib/cbook/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/9049/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
tacaswellhttps://github.com/tacaswell
Aug 17, 2017https://github.com/matplotlib/matplotlib/pull/9049/files#r133618208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9049/files
dopplershifthttps://github.com/dopplershift
Aug 17, 2017https://github.com/matplotlib/matplotlib/pull/9049/files#r133773472
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/9049/files
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
lib/matplotlib/lines.pyhttps://github.com/matplotlib/matplotlib/pull/9049/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
View file https://github.com/dopplershift/matplotlib/blob/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb/lib/matplotlib/lines.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/9049/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
lib/matplotlib/path.pyhttps://github.com/matplotlib/matplotlib/pull/9049/files#diff-732128c2653eae0f24d387b13fac9d2aed0a716c21e79e4ef68dcc7300c97562
View file https://github.com/dopplershift/matplotlib/blob/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb/lib/matplotlib/path.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/9049/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-732128c2653eae0f24d387b13fac9d2aed0a716c21e79e4ef68dcc7300c97562
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-732128c2653eae0f24d387b13fac9d2aed0a716c21e79e4ef68dcc7300c97562
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-732128c2653eae0f24d387b13fac9d2aed0a716c21e79e4ef68dcc7300c97562
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-732128c2653eae0f24d387b13fac9d2aed0a716c21e79e4ef68dcc7300c97562
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-732128c2653eae0f24d387b13fac9d2aed0a716c21e79e4ef68dcc7300c97562
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-732128c2653eae0f24d387b13fac9d2aed0a716c21e79e4ef68dcc7300c97562
lib/matplotlib/tests/baseline_images/test_units/plot_masked_units.pnghttps://github.com/matplotlib/matplotlib/pull/9049/files#diff-f3a608a8e2279d13346ac7e1f59723fc311706ddb380682f3d9b5f799f998d03
View file https://github.com/dopplershift/matplotlib/blob/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb/lib/matplotlib/tests/baseline_images/test_units/plot_masked_units.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/9049/files
lib/matplotlib/tests/baseline_images/test_units/plot_pint.pnghttps://github.com/matplotlib/matplotlib/pull/9049/files#diff-1bcc08144fd898e3ed5bb75f9a839d483c785b6a88787199c7ad2d8554fcf0a5
View file https://github.com/dopplershift/matplotlib/blob/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb/lib/matplotlib/tests/baseline_images/test_units/plot_pint.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/9049/files
lib/matplotlib/tests/test_units.pyhttps://github.com/matplotlib/matplotlib/pull/9049/files#diff-944789d5a5e7410e170a0a5d899cd8db1464784f16acc1cab829b758e69bd025
View file https://github.com/dopplershift/matplotlib/blob/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb/lib/matplotlib/tests/test_units.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/9049/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-944789d5a5e7410e170a0a5d899cd8db1464784f16acc1cab829b758e69bd025
lib/mpl_toolkits/mplot3d/axes3d.pyhttps://github.com/matplotlib/matplotlib/pull/9049/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
View file https://github.com/dopplershift/matplotlib/blob/0525c6bb46d7ce4850b8fb75c06c4b390f2f9ffb/lib/mpl_toolkits/mplot3d/axes3d.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/9049/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
https://github.com/matplotlib/matplotlib/pull/9049/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.