Title: FIX: if bins input to hist is str, treat like no bins by tacaswell · Pull Request #8638 · matplotlib/matplotlib · GitHub
Open Graph Title: FIX: if bins input to hist is str, treat like no bins by tacaswell · Pull Request #8638 · matplotlib/matplotlib
X Title: FIX: if bins input to hist is str, treat like no bins by tacaswell · Pull Request #8638 · matplotlib/matplotlib
Description: PR Summary This change causes the range of all data sets to be computed and passed to numpy (which in turn uses the total range to compute the 'best' bins). The existing code 'latches' the bins from the first data set to use for the rest so this is can still lead to poor binning (if the data sets are widely different). closes #8636 This still needs some tests and possibly a more through thinking of how to deal with the 'string' bins and multiple data sets. Computing the histogram once with all of the data and the using those bins may be a better option (but involves computing the histograms twice). PR Checklist Has Pytest style unit tests Code is PEP 8 compliant
Open Graph Description: PR Summary This change causes the range of all data sets to be computed and passed to numpy (which in turn uses the total range to compute the 'best' bins). The existing code 'latches&#...
X Description: PR Summary This change causes the range of all data sets to be computed and passed to numpy (which in turn uses the total range to compute the 'best' bins). The existing code &#...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/8638
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a7a86afd-0947-b8fd-b1d3-1af6f427acaf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8810:153FD3:27BBA0B:3622D5B:6A53AEDC |
| html-safe-nonce | fd6a558f8921b0d2fcc8fa7da5f660118b6d337a4cbcf52dfa801598b9e4b318 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODEwOjE1M0ZEMzoyN0JCQTBCOjM2MjJENUI6NkE1M0FFREMiLCJ2aXNpdG9yX2lkIjoiMjM3MjcwODI4NTkyNzM3MDQ2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1765b35c841b2d84a37f032d5861c7a515ddfbb6bcddf5d98731c936c56b63ba |
| hovercard-subject-tag | pull_request:121187132 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/8638/files |
| twitter:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| og:image:alt | PR Summary This change causes the range of all data sets to be computed and passed to numpy (which in turn uses the total range to compute the 'best' bins). The existing code 'latches&#... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width