Title: Axes.__init__ speedup by QuLogic · Pull Request #8626 · matplotlib/matplotlib · GitHub
Open Graph Title: Axes.__init__ speedup by QuLogic · Pull Request #8626 · matplotlib/matplotlib
X Title: Axes.__init__ speedup by QuLogic · Pull Request #8626 · matplotlib/matplotlib
Description: PR Summary As noted in #6664, Axes.__init__ is fairly slow due to the eventual call to Axis.reset_ticks. @efiring suggested lazy instantiation and @Kojoley was implementing, but I'm unsure of the status. In the meantime though, we still speed things up by avoiding calling cla too many times. Using the example from #6664 with v2.0.x: $ python3 -m timeit \ -s "from matplotlib.figure import Figure; from matplotlib.axes import Axes; fig = Figure()" \ "Axes(fig, (0, 0, 1 ,1))" 10 loops, best of 3: 29.7 msec per loop and master is already a bit faster: $ python -m timeit \ -s "from matplotlib.figure import Figure; from matplotlib.axes import Axes; fig = Figure()" \ "Axes(fig, (0, 0, 1 ,1))" 100 loops, best of 3: 17.7 msec per loop The trouble with Axes.__init__ is that it does a bit too much clearing; Axes.__init__ calls: Axes._init_axis Creates self.xaxis and self.yaxis Axis.__init__ -> Axis.cla (2 calls per Axes) Registers each Axis with two spines via Spine.register_axis Axis.cla is called on the registered Axis (2 Spine * 2 Axis = 4 calls per Axes) Axes.cla - Necessary to finish initializing the Axes in a clean state, though it's generic for any caller. self.xaxis.cla() / self.yaxis.cla() (2 calls per Axes) self.spines[:].cla() (2 spines per Axis = 4 calls per Axes) That makes 12 calls to Axis.cla for only 2 Axis objects. Adding some hidden argument to skip these calls as in this PR would reduce those calls by 6, though the speedup is only approximately 4 times: $ python -m timeit \ -s "from matplotlib.figure import Figure; from matplotlib.axes import Axes; fig = Figure()" \ "Axes(fig, (0, 0, 1 ,1))" 100 loops, best of 3: 4.45 msec per loop PR Checklist [N/A] Has Pytest style unit tests Code is PEP 8 compliant [N/A] New features are documented, with examples if plot related [N/A] Documentation is sphinx and numpydoc compliant [N/A] Added an entry to doc/users/whats_new.rst if major new feature [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary As noted in #6664, Axes.__init__ is fairly slow due to the eventual call to Axis.reset_ticks. @efiring suggested lazy instantiation and @Kojoley was implementing, but I'm unsure of t...
X Description: PR Summary As noted in #6664, Axes.__init__ is fairly slow due to the eventual call to Axis.reset_ticks. @efiring suggested lazy instantiation and @Kojoley was implementing, but I'm unsure ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/8626
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5168325e-4399-62fa-8b6b-e099b3cc2a0c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE30:17A244:970739:CBC98B:6A5310BB |
| html-safe-nonce | 4d166f79ad9f571a4738303eb5a196e00da6db2a72ba7c089c7d6d8053e8db63 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTMwOjE3QTI0NDo5NzA3Mzk6Q0JDOThCOjZBNTMxMEJCIiwidmlzaXRvcl9pZCI6Ijg3NDk3MDAwMDI3MzYxODE0MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c60a3eb779e0a1bc85e5794b567b6938347a520de73fc566bd1afda1264893a7 |
| hovercard-subject-tag | pull_request:120727278 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/8626/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR Summary As noted in #6664, Axes.__init__ is fairly slow due to the eventual call to Axis.reset_ticks. @efiring suggested lazy instantiation and @Kojoley was implementing, but I'm unsure of t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width