René's URL Explorer Experiment


Title: Legend hatching fixes by QuLogic · Pull Request #8575 · matplotlib/matplotlib · GitHub

Open Graph Title: Legend hatching fixes by QuLogic · Pull Request #8575 · matplotlib/matplotlib

X Title: Legend hatching fixes by QuLogic · Pull Request #8575 · matplotlib/matplotlib

Description: Two fixes for hatching in legends: PolyCollections don't show hatching when the default colour is used. This is because the set edge colour is copied which means the default behaviour of finding the hatch colour from rcParams is not done. Instead copy the "original" edge colour which triggers any other processing when setting the edge colour on the legend patch. Patchs show the wrong colour when an explicit one is set; this is simply because the hatching colour is not copied with other settings. I added tests for both these types of artists; are there any others that might work differently that should be added?

Open Graph Description: Two fixes for hatching in legends: PolyCollections don't show hatching when the default colour is used. This is because the set edge colour is copied which means the default behaviour of find...

X Description: Two fixes for hatching in legends: PolyCollections don't show hatching when the default colour is used. This is because the set edge colour is copied which means the default behaviour of ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/8575

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:db8c76bf-8568-6f14-0d99-9c99056258c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB048:33711E:81C059:ACF868:6A51A8E3
html-safe-nonce47ef6bbd5cfe3d7b33d246551764c883a3da5a18cd59494a7a1f69e0f31ee948
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDQ4OjMzNzExRTo4MUMwNTk6QUNGODY4OjZBNTFBOEUzIiwidmlzaXRvcl9pZCI6IjY1MTAxMjgyMzE1MjU0OTI5NjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf726155ecdfcb6637f2bd57f51c640d6fbc279a70ea9d8aaf30b4a8f93b12b7f
hovercard-subject-tagpull_request:119107308
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/8575/files
twitter:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
og:image:altTwo fixes for hatching in legends: PolyCollections don't show hatching when the default colour is used. This is because the set edge colour is copied which means the default behaviour of find...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/8575/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F8575%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F8575%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/8575/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/8575/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/8575/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8575/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8575/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
phobsonhttps://github.com/phobson
matplotlib:v2.0.xhttps://github.com/matplotlib/matplotlib/tree/v2.0.x
QuLogic:legend-hatchinghttps://github.com/QuLogic/matplotlib/tree/legend-hatching
Conversation 2 https://github.com/matplotlib/matplotlib/pull/8575
Commits 3 https://github.com/matplotlib/matplotlib/pull/8575/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/8575/checks
Files changed https://github.com/matplotlib/matplotlib/pull/8575/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8575/files
Legend hatching fixes https://github.com/matplotlib/matplotlib/pull/8575/files#top
Show all changes 3 commits https://github.com/matplotlib/matplotlib/pull/8575/files
4c46381 Use original face/edge color to create Poly legend. QuLogic May 5, 2017 https://github.com/matplotlib/matplotlib/pull/8575/commits/4c463813a3c0b56e07fb10b6ff4704d6e5efde8c
122bf46 Also copy hatch color when updating Patches. QuLogic May 5, 2017 https://github.com/matplotlib/matplotlib/pull/8575/commits/122bf46ed130177cc31ff11d2fa28bf298ce6870
ae5bb59 Add test that hatching works in legends. QuLogic May 5, 2017 https://github.com/matplotlib/matplotlib/pull/8575/commits/ae5bb59ebc03b3b90a2f369f20c41c1363a11d8f
Clear filters https://github.com/matplotlib/matplotlib/pull/8575/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8575/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8575/files
legend_handler.py https://github.com/matplotlib/matplotlib/pull/8575/files#diff-bf161cdba7927d70f74280599f230645a986d47e57821a961a2dd768dc403a05
patches.py https://github.com/matplotlib/matplotlib/pull/8575/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
hatching.pdf https://github.com/matplotlib/matplotlib/pull/8575/files#diff-fa3fc41ba4a8ec233c5e035f06ee5fbbdf83b7e7e330b06fcb2515b771f4479f
hatching.png https://github.com/matplotlib/matplotlib/pull/8575/files#diff-27a30c20ab2a4d9b65d77e93c8592c606eb4f3808167953eed0a44455ed0a3bf
hatching.svg https://github.com/matplotlib/matplotlib/pull/8575/files#diff-f555253baf422ac16244b2633362aac532771abce92e1d87d70ed41b15defb19
test_legend.py https://github.com/matplotlib/matplotlib/pull/8575/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
lib/matplotlib/legend_handler.pyhttps://github.com/matplotlib/matplotlib/pull/8575/files#diff-bf161cdba7927d70f74280599f230645a986d47e57821a961a2dd768dc403a05
View file https://github.com/QuLogic/matplotlib/blob/ae5bb59ebc03b3b90a2f369f20c41c1363a11d8f/lib/matplotlib/legend_handler.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/8575/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/8575/files#diff-bf161cdba7927d70f74280599f230645a986d47e57821a961a2dd768dc403a05
https://github.com/matplotlib/matplotlib/pull/8575/files#diff-bf161cdba7927d70f74280599f230645a986d47e57821a961a2dd768dc403a05
https://github.com/matplotlib/matplotlib/pull/8575/files#diff-bf161cdba7927d70f74280599f230645a986d47e57821a961a2dd768dc403a05
lib/matplotlib/patches.pyhttps://github.com/matplotlib/matplotlib/pull/8575/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
View file https://github.com/QuLogic/matplotlib/blob/ae5bb59ebc03b3b90a2f369f20c41c1363a11d8f/lib/matplotlib/patches.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/8575/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/8575/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/8575/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
lib/matplotlib/tests/baseline_images/test_legend/hatching.pdfhttps://github.com/matplotlib/matplotlib/pull/8575/files#diff-fa3fc41ba4a8ec233c5e035f06ee5fbbdf83b7e7e330b06fcb2515b771f4479f
View file https://github.com/QuLogic/matplotlib/blob/ae5bb59ebc03b3b90a2f369f20c41c1363a11d8f/lib/matplotlib/tests/baseline_images/test_legend/hatching.pdf
Open in desktop https://desktop.github.com
lib/matplotlib/tests/baseline_images/test_legend/hatching.pnghttps://github.com/matplotlib/matplotlib/pull/8575/files#diff-27a30c20ab2a4d9b65d77e93c8592c606eb4f3808167953eed0a44455ed0a3bf
View file https://github.com/QuLogic/matplotlib/blob/ae5bb59ebc03b3b90a2f369f20c41c1363a11d8f/lib/matplotlib/tests/baseline_images/test_legend/hatching.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/8575/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8575/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.