René's URL Explorer Experiment


Title: ENH: Stricter validation of line style rcParams (and extended accepted types for `grid.linestyle`) by afvincent · Pull Request #8040 · matplotlib/matplotlib · GitHub

Open Graph Title: ENH: Stricter validation of line style rcParams (and extended accepted types for `grid.linestyle`) by afvincent · Pull Request #8040 · matplotlib/matplotlib

X Title: ENH: Stricter validation of line style rcParams (and extended accepted types for `grid.linestyle`) by afvincent · Pull Request #8040 · matplotlib/matplotlib

Description: A possible “solution” to #7991 (suggested by @tacaswell on Gitter, February 7, 2017 12:09 PM) . The user could now use a sequence like [1.0, 3.0] for the rcParam grid.linestyle. The validation is not extensive, partly because I was not sure it should be performed here. For example, one can perfectly pass a value like u'Hello world' without the new function validate_grid_linestyle raising an error. Should I set the only accepted strings to be in cbook.ls_mapper and cbook.ls_mapper_r? Edit: typo + link to Gitter.

Open Graph Description: A possible “solution” to #7991 (suggested by @tacaswell on Gitter, February 7, 2017 12:09 PM) . The user could now use a sequence like [1.0, 3.0] for the rcParam grid.linestyle. The validation is n...

X Description: A possible “solution” to #7991 (suggested by @tacaswell on Gitter, February 7, 2017 12:09 PM) . The user could now use a sequence like [1.0, 3.0] for the rcParam grid.linestyle. The validation is n...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/8040

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bce05d9e-b0dc-26f3-26d1-6938ec4d31e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA624:1A6FEB:1414EE7:1B9544A:6A53D6A7
html-safe-nonce485b4600bf90faf33354d3bed7a45f806ce4b1d306b3aa85af0d81838f2b4331
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjI0OjFBNkZFQjoxNDE0RUU3OjFCOTU0NEE6NkE1M0Q2QTciLCJ2aXNpdG9yX2lkIjoiNzc1MzkyMjc0NDM3NTU2Mzk0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0867a6082dd81b2005f74952a1bde291a97d554f66a7275fd8e26e7e8bd32ba2
hovercard-subject-tagpull_request:105035263
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/8040/files
twitter:imagehttps://avatars.githubusercontent.com/u/17270724?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17270724?s=400&v=4
og:image:altA possible “solution” to #7991 (suggested by @tacaswell on Gitter, February 7, 2017 12:09 PM) . The user could now use a sequence like [1.0, 3.0] for the rcParam grid.linestyle. The validation is n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/8040/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F8040%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F8040%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/8040/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/8040/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/8040/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8040/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8040/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
NelleVhttps://github.com/NelleV
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
afvincent:wip_relax_grid_ls_validationhttps://github.com/afvincent/matplotlib/tree/wip_relax_grid_ls_validation
Conversation 32 https://github.com/matplotlib/matplotlib/pull/8040
Commits 15 https://github.com/matplotlib/matplotlib/pull/8040/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/8040/checks
Files changed https://github.com/matplotlib/matplotlib/pull/8040/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8040/files
ENH: Stricter validation of line style rcParams (and extended accepted types for grid.linestyle) https://github.com/matplotlib/matplotlib/pull/8040/files#top
Show all changes 15 commits https://github.com/matplotlib/matplotlib/pull/8040/files
061061b extend 'grid.linestyle' valid types to on-off ink sequences afvincent Feb 7, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/061061b564de2f93ef2c870c0d99bd51259ca963
5be29b5 extend 'add test for the new function 'validate_grid_linestyle' afvincent Feb 7, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/5be29b5015c110bc8bbe57ad152d7d85c64198a1
25efd07 fix a small typo afvincent Feb 8, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/25efd07d7f6c766171dab01f5da5370cd8c18e35
5cb183c Relax validation for all ls-related rcParams but contour.negative_lin… afvincent Feb 9, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/5cb183c6ff7d67b7fda81b7cddf34b5dc9f7a0bf
d9ff6a8 Check that strings are valid line styles afvincent Feb 9, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/d9ff6a8fa85186af19d06553ad823d4cf47b8c50
44c3fde fix PEP8 afvincent Feb 9, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/44c3fde4a070731c8fb1db8aa6422b5f0be59461
e8032df use validate_linestyle even for rcParam 'contour.negative_linestyle' afvincent Feb 10, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/e8032dff30c077a6e3afece034b59c9294ee4df0
2673585 Reintroduce former public validators for negative contours (but they … afvincent Feb 13, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/2673585f66e838175b1406b24dd22d898e1d189e
7bd9bfe make validate_linestyle private and case insensitive (+ adapt relevan… afvincent Feb 13, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/7bd9bfe54cf2568ac0df2013e7f322454227abda
ad21964 Remove deprecation warning in 'validate_negative_linestyle_legacy' afvincent Feb 13, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/ad219649e0d0e5de6abb1e2ab552db900f76813f
7ab75f5 Deprecate former validation schemes used by 'contour.negative_linestyle' afvincent Feb 14, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/7ab75f5eddf02007f90ff694a94ed19a9f1630e5
59328e6 Fix typo (a forgotten 'return' statement...) afvincent Feb 14, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/59328e6fb11808e67cb1e74edb17ffe978fe0753
70e87c8 Fix the deprecation decorators afvincent Feb 17, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/70e87c81945ec1fbb1d5871af13d30fe498b48ec
c060842 Add a what's new entry afvincent Feb 17, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/c060842c8352d41822958f3db8c122dff1b1cc37
aabf385 Fix a typo with the example in the what's new entry afvincent Feb 17, 2017 https://github.com/matplotlib/matplotlib/pull/8040/commits/aabf385f53d049d6dbd80ec7236d52845b303a6a
Clear filters https://github.com/matplotlib/matplotlib/pull/8040/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8040/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/8040/files
validation_of_linestyle_rcparams.rst https://github.com/matplotlib/matplotlib/pull/8040/files#diff-7beb36e386b36061f88ff75e6b780dd2624213eb980c03c5a551bf8e48f52b2b
rcsetup.py https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
test_rcparams.py https://github.com/matplotlib/matplotlib/pull/8040/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
matplotlibrc.template https://github.com/matplotlib/matplotlib/pull/8040/files#diff-9eaf38a8a7b9d20d5719447762f60b98c69bb8503da6bfa40df69bd2844458cf
doc/users/whats_new/validation_of_linestyle_rcparams.rsthttps://github.com/matplotlib/matplotlib/pull/8040/files#diff-7beb36e386b36061f88ff75e6b780dd2624213eb980c03c5a551bf8e48f52b2b
View file https://github.com/afvincent/matplotlib/blob/aabf385f53d049d6dbd80ec7236d52845b303a6a/doc/users/whats_new/validation_of_linestyle_rcparams.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/8040/{{ revealButtonHref }}
lib/matplotlib/rcsetup.pyhttps://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
View file https://github.com/afvincent/matplotlib/blob/aabf385f53d049d6dbd80ec7236d52845b303a6a/lib/matplotlib/rcsetup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/8040/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
lib/matplotlib/tests/test_rcparams.pyhttps://github.com/matplotlib/matplotlib/pull/8040/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
View file https://github.com/afvincent/matplotlib/blob/aabf385f53d049d6dbd80ec7236d52845b303a6a/lib/matplotlib/tests/test_rcparams.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/8040/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
matplotlibrc.templatehttps://github.com/matplotlib/matplotlib/pull/8040/files#diff-9eaf38a8a7b9d20d5719447762f60b98c69bb8503da6bfa40df69bd2844458cf
View file https://github.com/afvincent/matplotlib/blob/aabf385f53d049d6dbd80ec7236d52845b303a6a/matplotlibrc.template
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/8040/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-9eaf38a8a7b9d20d5719447762f60b98c69bb8503da6bfa40df69bd2844458cf
https://github.com/matplotlib/matplotlib/pull/8040/files#diff-9eaf38a8a7b9d20d5719447762f60b98c69bb8503da6bfa40df69bd2844458cf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.