René's URL Explorer Experiment


Title: Avoid comparing numpy array to strings in two places by dstansby · Pull Request #7658 · matplotlib/matplotlib · GitHub

Open Graph Title: Avoid comparing numpy array to strings in two places by dstansby · Pull Request #7658 · matplotlib/matplotlib

X Title: Avoid comparing numpy array to strings in two places by dstansby · Pull Request #7658 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: Fixes #5806

X Description: Fixes #5806

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/7658

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:31b9d553-e8da-4ba2-5f68-18098fcaa2ef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id948A:6E56C:22A0B1C:2EA71E2:6A546C21
html-safe-nonce03dd40451ea30ad1edb0750ef63f3f5599fd118ee8217d252c33f7ccc663e8de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDhBOjZFNTZDOjIyQTBCMUM6MkVBNzFFMjo2QTU0NkMyMSIsInZpc2l0b3JfaWQiOiIyMzQyNzMzODgwOTY3MzI2NzUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf7cdf997f183d4de1ca8c18e7e5d28ef2186fdf14ad232b900345171e9b3402e
hovercard-subject-tagpull_request:98977321
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/7658/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0de910147c35a1bbc75558b5049188557e1d1f6685dd28bdec8ce4b8b058babd/matplotlib/matplotlib/pull/7658
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0de910147c35a1bbc75558b5049188557e1d1f6685dd28bdec8ce4b8b058babd/matplotlib/matplotlib/pull/7658
og:image:altFixes #5806
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedstansby
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6d28624802c2f7d9500239dd6870ed7031b7353b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/7658#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F7658
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F7658
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/7658
Reloadhttps://github.com/matplotlib/matplotlib/pull/7658
Reloadhttps://github.com/matplotlib/matplotlib/pull/7658
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
dstansby:aspect-array-warninghttps://github.com/dstansby/matplotlib/tree/aspect-array-warning
Conversationhttps://github.com/matplotlib/matplotlib/pull/7658
Commits3 (3)https://github.com/matplotlib/matplotlib/pull/7658/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/7658/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/7658/files
Avoid comparing numpy array to strings in two placeshttps://github.com/matplotlib/matplotlib/pull/7658#top
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
dstansby:aspect-array-warninghttps://github.com/dstansby/matplotlib/tree/aspect-array-warning
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Dec 21, 2016https://github.com/matplotlib/matplotlib/pull/7658#issue-196994876
#5806https://github.com/matplotlib/matplotlib/issues/5806
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
https://github.com/dstansby
Check if aspect is a string to avoid comparing numpy array to tuple o…https://github.com/matplotlib/matplotlib/pull/7658/commits/a33be777cb70af994964009f101b8fd8cae32935
a33be77https://github.com/matplotlib/matplotlib/pull/7658/commits/a33be777cb70af994964009f101b8fd8cae32935
https://github.com/efiring
efiringhttps://github.com/efiring
Dec 21, 2016 https://github.com/matplotlib/matplotlib/pull/7658#pullrequestreview-14020464
View reviewed changes https://github.com/matplotlib/matplotlib/pull/7658/files/a33be777cb70af994964009f101b8fd8cae32935
efiringhttps://github.com/efiring
https://github.com/matplotlib/matplotlib/pull/7658#pullrequestreview-14020464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
lib/matplotlib/axes/_base.pyhttps://github.com/matplotlib/matplotlib/pull/7658/files/a33be777cb70af994964009f101b8fd8cae32935#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
efiringhttps://github.com/efiring
Dec 21, 2016https://github.com/matplotlib/matplotlib/pull/7658#discussion_r93491265
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
dstansbyhttps://github.com/dstansby
December 22, 2016 12:07https://github.com/matplotlib/matplotlib/pull/7658#commits-pushed-abcef5a
https://github.com/dstansby
Use cbook string class checkerhttps://github.com/matplotlib/matplotlib/pull/7658/commits/abcef5afd54ec54029732660397c820c14fe063c
abcef5ahttps://github.com/matplotlib/matplotlib/pull/7658/commits/abcef5afd54ec54029732660397c820c14fe063c
https://github.com/dstansby
Avoid comparing numpy array to string when marker is an arrayhttps://github.com/matplotlib/matplotlib/pull/7658/commits/42786e378cd78fdd9b2ff4722b7b3fe769190d5d
42786e3https://github.com/matplotlib/matplotlib/pull/7658/commits/42786e378cd78fdd9b2ff4722b7b3fe769190d5d
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#event-902911630
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#issuecomment-268789105
#5806https://github.com/matplotlib/matplotlib/issues/5806
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
https://github.com/efiring
efiringhttps://github.com/efiring
Dec 22, 2016 https://github.com/matplotlib/matplotlib/pull/7658#pullrequestreview-14197010
View reviewed changes https://github.com/matplotlib/matplotlib/pull/7658/files/42786e378cd78fdd9b2ff4722b7b3fe769190d5d
https://github.com/efiring
efiringhttps://github.com/efiring
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#event-903266039
https://github.com/efiring
efiringhttps://github.com/efiring
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#issuecomment-268848748
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
https://github.com/NelleV
NelleVhttps://github.com/NelleV
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#event-903298990
https://github.com/NelleV
NelleVhttps://github.com/NelleV
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#issuecomment-268854727
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#event-903565201
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
b8568f9https://github.com/matplotlib/matplotlib/commit/b8568f93e530ec99e13d28949bb136f60d6920b0
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#event-903565255
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Dec 22, 2016https://github.com/matplotlib/matplotlib/pull/7658#event-903565324
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
December 22, 2016 22:41https://github.com/matplotlib/matplotlib/pull/7658#event-903590571
fix a warning when the aspect is a number #6279 https://github.com/matplotlib/matplotlib/pull/6279
FIX: Remove type checking for strings in '_validate_linestyle' #8165 https://github.com/matplotlib/matplotlib/pull/8165
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F7658
https://github.com/efiring
efiring https://github.com/efiring
https://github.com/matplotlib/matplotlib/pull/7658/files/42786e378cd78fdd9b2ff4722b7b3fe769190d5d
v2.1 https://github.com/matplotlib/matplotlib/milestone/12
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7658
https://github.com/dstansby
https://github.com/efiring
https://github.com/NelleV
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.