René's URL Explorer Experiment


Title: Axisartist testing + bugfixes by QuLogic · Pull Request #7545 · matplotlib/matplotlib · GitHub

Open Graph Title: Axisartist testing + bugfixes by QuLogic · Pull Request #7545 · matplotlib/matplotlib

X Title: Axisartist testing + bugfixes by QuLogic · Pull Request #7545 · matplotlib/matplotlib

Description: The axisartist toolkit does not appear to have any testing done at all; it was still importing matplotlib.externals.six! There were a lot of tests written into the files themselves, so I just pulled them out and made them into real tests. There are some bugfixes in 2316a07, a7dde13, and 8062fe5; not sure if they're worth backporting. I also simplified the format of FormatterDMS/FormatterHMS; it didn't make any sense to me that the decimal place would go before the symbol and the fractional part after. This will likely fail to pass due to some tick clipping bug that I haven't fixed yet; it's also possible that the flaky comparisons will arise here as well. I have an idea of how to fix that, but I thought I'd write the tests first.

Open Graph Description: The axisartist toolkit does not appear to have any testing done at all; it was still importing matplotlib.externals.six! There were a lot of tests written into the files themselves, so I just pulle...

X Description: The axisartist toolkit does not appear to have any testing done at all; it was still importing matplotlib.externals.six! There were a lot of tests written into the files themselves, so I just pulle...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/7545

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a820219d-18d4-b596-932e-27c9f17066a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD5E:2CE7AA:12CFA6B:18DDA0D:6A5428C2
html-safe-nonced63c27d78999338e18acba913349e0fa0259e8b28176a559f6dc4f12f3628b3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDVFOjJDRTdBQToxMkNGQTZCOjE4RERBMEQ6NkE1NDI4QzIiLCJ2aXNpdG9yX2lkIjoiODU1Mjc4NzIzNjk1NzIwMjYyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac92e820870a93dc9e0d926b8f7a26072a27729c85e95e5c0acf065e6debbe6cdb
hovercard-subject-tagpull_request:96180988
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/7545/files
twitter:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
og:image:altThe axisartist toolkit does not appear to have any testing done at all; it was still importing matplotlib.externals.six! There were a lot of tests written into the files themselves, so I just pulle...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/7545/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F7545%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F7545%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/7545/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/7545/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/7545/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7545/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7545/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
efiringhttps://github.com/efiring
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:axisartist-testinghttps://github.com/QuLogic/matplotlib/tree/axisartist-testing
Conversation 35 https://github.com/matplotlib/matplotlib/pull/7545
Commits 16 https://github.com/matplotlib/matplotlib/pull/7545/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/7545/checks
Files changed https://github.com/matplotlib/matplotlib/pull/7545/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7545/files
Axisartist testing + bugfixes https://github.com/matplotlib/matplotlib/pull/7545/files#top
Show all changes 16 commits https://github.com/matplotlib/matplotlib/pull/7545/files
5458d4e Use @property decorator in axisartist. QuLogic Dec 1, 2016 https://github.com/matplotlib/matplotlib/pull/7545/commits/5458d4ea76369571912346689a10c4621dcdb63d
51e5434 Simplify FormatterDMS/FormatterHMS tick strings. QuLogic Dec 1, 2016 https://github.com/matplotlib/matplotlib/pull/7545/commits/51e54340047ede4f086a3b50cbe85ba35418a31d
e50c059 Fix bug in signs of FormatterDMS/HMS. QuLogic Dec 1, 2016 https://github.com/matplotlib/matplotlib/pull/7545/commits/e50c05941a3968c8d2186d276fb0a8e05af40c23
7a64b79 Make axisartist.angle_helper pseudo-tests real. QuLogic Dec 1, 2016 https://github.com/matplotlib/matplotlib/pull/7545/commits/7a64b797c0c31d5fc5aa8bd4d5ff765553deea4e
15fb901 Add sign when FormatterDMS emits only seconds. QuLogic Dec 1, 2016 https://github.com/matplotlib/matplotlib/pull/7545/commits/15fb901f30b1fcf18d3b084609350362266be769
f467768 Also test FormatterHMS and select_step24. QuLogic Dec 1, 2016 https://github.com/matplotlib/matplotlib/pull/7545/commits/f46776827bfec0fc03e744d2c4f65e93aeeb7768
bc1bfab Make axisartist.clip_path pseudo-tests real. QuLogic Dec 1, 2016 https://github.com/matplotlib/matplotlib/pull/7545/commits/bc1bfab12150feaad88f0944dc1cda977452f577
bcd41e4 Fix axisartist.floating_axes error with new NumPy. QuLogic Dec 1, 2016 https://github.com/matplotlib/matplotlib/pull/7545/commits/bcd41e48893b1ae30cbb24fb53bb5026c25f89a2
ffb5461 Don't double-strike axis artist Ticks. QuLogic Mar 24, 2017 https://github.com/matplotlib/matplotlib/pull/7545/commits/ffb54613eacf85d1bffb26818e4331d1c22e312d
7ecf80f Fix clipping of axis artist Ticks. QuLogic Mar 24, 2017 https://github.com/matplotlib/matplotlib/pull/7545/commits/7ecf80ff6f49b98129c6cb173cbacef6c34fa163
bf25cf6 Make axisartist.axislines pseudo-tests real. QuLogic Mar 24, 2017 https://github.com/matplotlib/matplotlib/pull/7545/commits/bf25cf61ee57769bd69d9ced00b6fdb0922d127d
e0556d1 Make axisartist.grid_helper_curvelinear pseudo-tests real. QuLogic Mar 24, 2017 https://github.com/matplotlib/matplotlib/pull/7545/commits/e0556d17b85e9b9d5139bf8aef301e3dedbe18ae
ff53c3f Make axisartist.floating_axes pseudo-tests real. QuLogic Mar 24, 2017 https://github.com/matplotlib/matplotlib/pull/7545/commits/ff53c3fb291204e8ead9bd441b28aa5270e27328
07ed9c5 Make axisartist.axis_artist pseudo-tests real. QuLogic Mar 24, 2017 https://github.com/matplotlib/matplotlib/pull/7545/commits/07ed9c5cdb410a43390124790fdb2e9782e63344
9488d1c Make axisartist.grid_finder pseudo-tests real. QuLogic Feb 6, 2018 https://github.com/matplotlib/matplotlib/pull/7545/commits/9488d1c82da00c04f6f4c5e2805175370c966fd7
b614316 Fix minor typos. QuLogic Feb 6, 2018 https://github.com/matplotlib/matplotlib/pull/7545/commits/b6143163d57627358450ee5b22b219b7b6fb4c32
Clear filters https://github.com/matplotlib/matplotlib/pull/7545/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7545/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7545/files
angle_helper.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
axis_artist.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-01aadf87231fd89bcf103f9ccb1c762fc9ab2d53b01780bfb28024ed7225ce69
axislines.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-986f31d8bd974a705366038f88c95c35be9276fd9e58d3dcebc865db655a1ff4
clip_path.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-5185e82238e583233e87b99795597a493ac6a67fe24a9ff4da04a148c1d57bbf
floating_axes.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-4b7ecc89d502fd1b134f3f277a596d058566ca4239d3bd6f1689c8e85f8dda67
grid_finder.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-344f91bac53bac81de78dcd5b49bb5dab9b95962c5b77ee67cb8abe3b256b6dd
grid_helper_curvelinear.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-c4f4e055cb5807462d3db93ae9f51e6d934880255d74b3e0c81aebd2f07d2f20
axis_artist.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-e9e5d6878568dc3cfb6b639e8420223938e862d1327952f5f5830a538a85157a
axis_artist_labelbase.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-6cc2354b72ac9bba791f39b1b87be82b89192a58e9025e58e5e020df13b12775
axis_artist_ticklabels.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-9e0f17904f02fe40510644728d87943777ba6618832722177b3239c24c4938a4
axis_artist_ticks.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-0b2b13d12eedbd9901d750d95d28af4adbd2ebf7174b4bbe6d2345dfbea76a48
Subplot.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-1d65a4615ab5b0aebe2663f51e70a5219021ea1acf06dc4ae543244b2592ae2c
SubplotZero.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-a5de75ad93d0d6c531ec7ee7221fd833a6ac60eb2f5a5dc487b6d36f0ad3f1fa
clip_path.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-c3cc493a2f996b6993bb502dd72ac570be507ea20c6476ac14d9ea85acc2f3cd
curvelinear3.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-7a84583ce8d63a00d005893929dbdea3dd4eac0c0a810c5939c26e2f9700f45d
curvelinear4.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-cb960d88712f818a7f3ad20751a8347ca09d9c14e05309f244ef9871de8427cb
axis_direction.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-53eeaa6bacef11485a85e19626635f355695d9b13e4c397721cf06e28b23b15e
custom_transform.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-853bf2cdbc0f39a80fe707ff357969e504952f9dcdc1719fb8bb44673d78a98f
polar_box.png https://github.com/matplotlib/matplotlib/pull/7545/files#diff-9981273a6ef27c9400b21f3bc5ff2e9ec9ed024a46b0db06c602ee13dc83c455
test_axisartist_angle_helper.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-623494dcaacdc3bfd60c343a536a6fa9722e4ef7b98848f718399253e01a774c
test_axisartist_axis_artist.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-00e3cd5675173b94b0e0f1b255b4239b51a13c7ba8dd347bd18377e42563e29a
test_axisartist_axislines.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-07b16192bb43453cd49d39ba678e8706ac66432cba24b403aabf5fb670bcd4db
test_axisartist_clip_path.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-12376263dcf689a6947faf6e9d1d95e57db3cd0e22dd4724415bc5bfb2f30b0b
test_axisartist_floating_axes.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-fa516f8b3a83a30eb8464fd69544937e6e6a219ba667c477b98e073974832b06
test_axisartist_grid_finder.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-94490cda050827181c0024efb8c053b3c18b7caf478ec9a8deb72fd02b8cc770
test_axisartist_grid_helper_curvelinear.py https://github.com/matplotlib/matplotlib/pull/7545/files#diff-85a1edb71b84f4fe3dc687bde8e6b78f11d2cb9354dee3f17c629a33f8fff8ad
lib/mpl_toolkits/axisartist/angle_helper.pyhttps://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
View file https://github.com/QuLogic/matplotlib/blob/b6143163d57627358450ee5b22b219b7b6fb4c32/lib/mpl_toolkits/axisartist/angle_helper.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/7545/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
https://github.com/matplotlib/matplotlib/pull/7545/files#diff-28c0021f28431aa93f7d51275e1c2b45761885f3bd405599b70369769038ada4
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/7545/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.