Title: improve snapping algorithm by leejjoon · Pull Request #726 · matplotlib/matplotlib · GitHub
Open Graph Title: improve snapping algorithm by leejjoon · Pull Request #726 · matplotlib/matplotlib
X Title: improve snapping algorithm by leejjoon · Pull Request #726 · matplotlib/matplotlib
Description: I think the current snapping gives somewhat wrong result. *x = mpl_round(*x) + m_snap_value; *y = mpl_round(*y) + m_snap_value; For example, consider m_snap_value=0.5 and (x, y) = (0.45, 0.55). This is supposed to be snapped to (0.5, 0.5) but the above code gives (0.5, 1.5). And I think the right thing to do is subtract m_snap_value before rounding. *x = mpl_round(*x-m_snap_value) + m_snap_value; *y = mpl_round(*y-m_snap_value) + m_snap_value;
Open Graph Description: I think the current snapping gives somewhat wrong result. *x = mpl_round(*x) + m_snap_value; *y = mpl_round(*y) + m_snap_value; For example, consider m_snap_value=0.5 ...
X Description: I think the current snapping gives somewhat wrong result. *x = mpl_round(*x) + m_snap_value; *y = mpl_round(*y) + m_snap_value; For example, consider m_snap_value=0.5 ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/726
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9d730955-d604-630d-d6e5-c2fbb25a8aee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 922E:230914:2368FE4:3020272:6A54286E |
| html-safe-nonce | 10a8347c5fe2c1b4245994bbcb7b54944c7693fb3f572d1061224beda3f64e05 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjJFOjIzMDkxNDoyMzY4RkU0OjMwMjAyNzI6NkE1NDI4NkUiLCJ2aXNpdG9yX2lkIjoiODk5MDEzNjkxOTEyMDk0NzMxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9e837c0f49903c31a6e9f72d60d4e68129938cb1a29b2220fffb8113116195e5 |
| hovercard-subject-tag | pull_request:895241 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/726/files |
| twitter:image | https://avatars.githubusercontent.com/u/95962?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/95962?s=400&v=4 |
| og:image:alt | I think the current snapping gives somewhat wrong result. *x = mpl_round(*x) + m_snap_value; *y = mpl_round(*y) + m_snap_value; For example, consider m_snap_value=0.5 ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width