René's URL Explorer Experiment


Title: Fix cn bugs by tacaswell · Pull Request #6374 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix cn bugs by tacaswell · Pull Request #6374 · matplotlib/matplotlib

X Title: Fix cn bugs by tacaswell · Pull Request #6374 · matplotlib/matplotlib

Description: Fixes two bugs: as was noted by @anntzer that the caching mechanism in to_rgb meant that the CN mapping is only done once tweak validation in rcsetup for colors that go into prop_cycle to forbid setting CN style values (due to circularness)

Open Graph Description: Fixes two bugs: as was noted by @anntzer that the caching mechanism in to_rgb meant that the CN mapping is only done once tweak validation in rcsetup for colors that go into prop_cycle to forbid s...

X Description: Fixes two bugs: as was noted by @anntzer that the caching mechanism in to_rgb meant that the CN mapping is only done once tweak validation in rcsetup for colors that go into prop_cycle to forbid s...

Mail addresses
notifications@github.com

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/6374

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:81e082a6-9eb4-431a-c552-13ff7d4f888d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECB0:1CCBDE:30E6585:42732F9:6A53E543
html-safe-nonce89be5d9208e72f2c6b7d7aeee80a0f18fe878ea128d501e7ac972fe0cea7e789
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0IwOjFDQ0JERTozMEU2NTg1OjQyNzMyRjk6NkE1M0U1NDMiLCJ2aXNpdG9yX2lkIjoiODc3MTkyNDA5OTQzMTA2ODgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac00cd93d5851f18ff36df45cb83462b0f1f2412242f8b6e8b535e3fec5254cb82
hovercard-subject-tagpull_request:69100773
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/6374/files
twitter:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
og:image:altFixes two bugs: as was noted by @anntzer that the caching mechanism in to_rgb meant that the CN mapping is only done once tweak validation in rcsetup for colors that go into prop_cycle to forbid s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/6374/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F6374%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F6374%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/6374/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/6374/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/6374/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
efiringhttps://github.com/efiring
matplotlib:v2.xhttps://github.com/matplotlib/matplotlib/tree/v2.x
tacaswell:fix_cn_bugshttps://github.com/tacaswell/matplotlib/tree/fix_cn_bugs
Conversation 26 https://github.com/matplotlib/matplotlib/pull/6374
Commits 5 https://github.com/matplotlib/matplotlib/pull/6374/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/6374/checks
Files changed https://github.com/matplotlib/matplotlib/pull/6374/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
Fix cn bugs https://github.com/matplotlib/matplotlib/pull/6374/files#top
Show all changes 5 commits https://github.com/matplotlib/matplotlib/pull/6374/files
6f47e3e FIX: do not allow CN color spec in prop_cycle tacaswell May 6, 2016 https://github.com/matplotlib/matplotlib/pull/6374/commits/6f47e3ec2b213421ddba37307fe583b0adca66ad
6db04da FIX: do not directly cache 'CN' color values tacaswell May 6, 2016 https://github.com/matplotlib/matplotlib/pull/6374/commits/6db04da9abce975b1c452be23acdf56c00bf0dba
c9f38ce TST: fix alias collision test tacaswell May 6, 2016 https://github.com/matplotlib/matplotlib/pull/6374/commits/c9f38ced429f5adc089a957a9cdb73ad67b7d63f
eb86ed1 PEP8 tacaswell May 6, 2016 https://github.com/matplotlib/matplotlib/pull/6374/commits/eb86ed14e27b2b10ff8cb3161c4137950ee30591
e3165c5 MNT: fix LPy issue tacaswell May 7, 2016 https://github.com/matplotlib/matplotlib/pull/6374/commits/e3165c5050a6f6844a944e38a255b456fdab71b4
Clear filters https://github.com/matplotlib/matplotlib/pull/6374/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
colors.py https://github.com/matplotlib/matplotlib/pull/6374/files#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6
rcsetup.py https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
property_collision_plot.png https://github.com/matplotlib/matplotlib/pull/6374/files#diff-4bc32ae0b7bcf9b954c3c5c222481889962bfa5d7da0261305516b9e0dc93eeb
test_colors.py https://github.com/matplotlib/matplotlib/pull/6374/files#diff-0b4e2edcbe7e1f81d3c7e56ac45d89a3aa1c8481d9204b2c0f497b3261006a87
test_cycles.py https://github.com/matplotlib/matplotlib/pull/6374/files#diff-463c39f191845b72680276e27729cea7d9c7eb3a2be5da5bcf8e428721a7c748
test_rcparams.py https://github.com/matplotlib/matplotlib/pull/6374/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
lib/matplotlib/colors.pyhttps://github.com/matplotlib/matplotlib/pull/6374/files#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6
View file https://github.com/tacaswell/matplotlib/blob/e3165c5050a6f6844a944e38a255b456fdab71b4/lib/matplotlib/colors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/6374/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6
lib/matplotlib/rcsetup.pyhttps://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
View file https://github.com/tacaswell/matplotlib/blob/e3165c5050a6f6844a944e38a255b456fdab71b4/lib/matplotlib/rcsetup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/6374/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-cbdeb0e4217c66c0eab3ff5027da14906cb705419722f8269bc9ccaadd2422b1
lib/matplotlib/tests/baseline_images/test_cycles/property_collision_plot.pnghttps://github.com/matplotlib/matplotlib/pull/6374/files#diff-4bc32ae0b7bcf9b954c3c5c222481889962bfa5d7da0261305516b9e0dc93eeb
View file https://github.com/tacaswell/matplotlib/blob/e3165c5050a6f6844a944e38a255b456fdab71b4/lib/matplotlib/tests/baseline_images/test_cycles/property_collision_plot.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/6374/files
lib/matplotlib/tests/test_colors.pyhttps://github.com/matplotlib/matplotlib/pull/6374/files#diff-0b4e2edcbe7e1f81d3c7e56ac45d89a3aa1c8481d9204b2c0f497b3261006a87
View file https://github.com/tacaswell/matplotlib/blob/e3165c5050a6f6844a944e38a255b456fdab71b4/lib/matplotlib/tests/test_colors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/6374/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-0b4e2edcbe7e1f81d3c7e56ac45d89a3aa1c8481d9204b2c0f497b3261006a87
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-0b4e2edcbe7e1f81d3c7e56ac45d89a3aa1c8481d9204b2c0f497b3261006a87
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-0b4e2edcbe7e1f81d3c7e56ac45d89a3aa1c8481d9204b2c0f497b3261006a87
lib/matplotlib/tests/test_cycles.pyhttps://github.com/matplotlib/matplotlib/pull/6374/files#diff-463c39f191845b72680276e27729cea7d9c7eb3a2be5da5bcf8e428721a7c748
View file https://github.com/tacaswell/matplotlib/blob/e3165c5050a6f6844a944e38a255b456fdab71b4/lib/matplotlib/tests/test_cycles.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/6374/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-463c39f191845b72680276e27729cea7d9c7eb3a2be5da5bcf8e428721a7c748
WeatherGodhttps://github.com/WeatherGod
May 6, 2016https://github.com/matplotlib/matplotlib/pull/6374/files#r62330416
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
tacaswellhttps://github.com/tacaswell
May 6, 2016https://github.com/matplotlib/matplotlib/pull/6374/files#r62380569
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
WeatherGodhttps://github.com/WeatherGod
May 6, 2016https://github.com/matplotlib/matplotlib/pull/6374/files#r62388023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
tacaswellhttps://github.com/tacaswell
May 6, 2016https://github.com/matplotlib/matplotlib/pull/6374/files#r62397019
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#6374 (comment)https://github.com/matplotlib/matplotlib/pull/6374#discussion_r62388023
https://github.com/matplotlib/matplotlib/pull/6374/files/faae5069bb987fd5447652860a8d1fb602c3289d#r62388023https://github.com/matplotlib/matplotlib/pull/6374/files/faae5069bb987fd5447652860a8d1fb602c3289d#r62388023
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
WeatherGodhttps://github.com/WeatherGod
May 7, 2016https://github.com/matplotlib/matplotlib/pull/6374/files#r62416123
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#6380https://github.com/matplotlib/matplotlib/issues/6380
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/6374/files
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-463c39f191845b72680276e27729cea7d9c7eb3a2be5da5bcf8e428721a7c748
lib/matplotlib/tests/test_rcparams.pyhttps://github.com/matplotlib/matplotlib/pull/6374/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
View file https://github.com/tacaswell/matplotlib/blob/e3165c5050a6f6844a944e38a255b456fdab71b4/lib/matplotlib/tests/test_rcparams.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/6374/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
https://github.com/matplotlib/matplotlib/pull/6374/files#diff-35afbf0e26422afdfbd0c9f7c7d30f8a4d4e30072785b33e2914f08c7e3315bc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.