Title: fixed issue #5456 by CrazyKsv · Pull Request #6167 · matplotlib/matplotlib · GitHub
Open Graph Title: fixed issue #5456 by CrazyKsv · Pull Request #6167 · matplotlib/matplotlib
X Title: fixed issue #5456 by CrazyKsv · Pull Request #6167 · matplotlib/matplotlib
Description: bugfix for bug-#5456 This is a simple fix by adding a value check. If you need testing cases, please let me know In this scenario, bottom and top are the margins(white space) that are set between the figure and the top/bottom of the image. If the y-axis label is set to a long string, it causes the calculations of these margins in tight_layout() to be greater than their max length 0.5, which then raises the ValueError as mentioned before. The size of the figure should be in the range 0.0-1.0 for both x and y lengths. If one of the margins exceed 0.5, then the image produced would have too much empty space on one half. If margins top and bottom exceed 0.5, then the figure will be left with no space to be displayed, which causes the program to crash. Also, We fixed the same problem that appear in horizontal label. Through investigation, it was discovered that a similar bug happens when the label assigned to the x-axis exceeds the allotted space for the figure. Namely, the error that occurs is ValueError: left cannot be >= right and crashes the python program. We have implemented the same fix to apply for the x-axis as well. Our initial commit for bug #5456 passed the check.. For the commit and revert of bug #4414, please ignore the commit of 2a02dfc and 7902d5d Those will be committed by my teammates.
Open Graph Description: bugfix for bug-#5456 This is a simple fix by adding a value check. If you need testing cases, please let me know In this scenario, bottom and top are the margins(white space) that are set between t...
X Description: bugfix for bug-#5456 This is a simple fix by adding a value check. If you need testing cases, please let me know In this scenario, bottom and top are the margins(white space) that are set between t...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/6167
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c225ba5d-38c3-2603-b7d7-ffb75f832203 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8762:116767:5955D4:7C3DDA:6A5853B1 |
| html-safe-nonce | 4cc443c90323ac2524be2169e24575bcdd2e319c47614390ded50e1c81a67631 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzYyOjExNjc2Nzo1OTU1RDQ6N0MzRERBOjZBNTg1M0IxIiwidmlzaXRvcl9pZCI6IjM5NDkwNzAzNDk5NTkxODk0MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 820268b55c1d01beb0657dbaefba574c76ba51230dadb99e04a9c0585cabdaeb |
| hovercard-subject-tag | pull_request:63143544 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/6167/files |
| twitter:image | https://avatars.githubusercontent.com/u/14336655?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14336655?s=400&v=4 |
| og:image:alt | bugfix for bug-#5456 This is a simple fix by adding a value check. If you need testing cases, please let me know In this scenario, bottom and top are the margins(white space) that are set between t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width