| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:313da13f-c8b2-0029-ca23-81a045d7ff07 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB98:6ED1:24038E:306F58:6A558F92 |
| html-safe-nonce | 3655751c3587f4192e8fdeb8b2b241a450f18188d7689de540c9b7d3b5aac60c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjk4OjZFRDE6MjQwMzhFOjMwNkY1ODo2QTU1OEY5MiIsInZpc2l0b3JfaWQiOiI5MDcyMzU4MjYxMjA3MTc1MDU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f75d8afcd13fa04014c8ac517525b1d7d557d8707e8290bf9744427ad6b3d887 |
| hovercard-subject-tag | pull_request:39711630 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/4619/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a9b772a8547ddab00d5386022e12c94bad1bc25e2dc90903661c9bae7ed9613c/matplotlib/matplotlib/pull/4619 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a9b772a8547ddab00d5386022e12c94bad1bc25e2dc90903661c9bae7ed9613c/matplotlib/matplotlib/pull/4619 |
| og:image:alt | While fixing #4613 I noticed some warnings in the tests.
This silences some of them by making sure that the files are closed probably when reading files using PIL
It seems like PIL doesn't pro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jenshnielsen |
| hostname | github.com |
| expected-hostname | github.com |
| None | b5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | aa21baa44893467b0b640d0300538f84ca8c475b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/4619#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4619 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4619 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/4619 |
| Reload | https://github.com/matplotlib/matplotlib/pull/4619 |
| Reload | https://github.com/matplotlib/matplotlib/pull/4619 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| jenshnielsen | https://github.com/jenshnielsen |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jenshnielsen:test_pil_close | https://github.com/jenshnielsen/matplotlib/tree/test_pil_close |
| Conversation | https://github.com/matplotlib/matplotlib/pull/4619 |
| Commits1 (1) | https://github.com/matplotlib/matplotlib/pull/4619/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/4619/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/4619/files |
| Make sure pil files are closed correctly | https://github.com/matplotlib/matplotlib/pull/4619#top |
| jenshnielsen | https://github.com/jenshnielsen |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jenshnielsen:test_pil_close | https://github.com/jenshnielsen/matplotlib/tree/test_pil_close |
|
| https://github.com/jenshnielsen |
| jenshnielsen | https://github.com/jenshnielsen |
| Jul 10, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#issue-94365642 |
| #4613 | https://github.com/matplotlib/matplotlib/issues/4613 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
|
| https://github.com/jenshnielsen |
| Make sure pil files are closed correctly | https://github.com/matplotlib/matplotlib/pull/4619/commits/b8070d388f2b044491bd00c56074dea760b745a9 |
| b8070d3 | https://github.com/matplotlib/matplotlib/pull/4619/commits/b8070d388f2b044491bd00c56074dea760b745a9 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
status: needs review
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20review%22 |
| Jul 10, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#event-353202408 |
| https://github.com/WeatherGod |
| WeatherGod | https://github.com/WeatherGod |
| Jul 10, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#issuecomment-120527948 |
| #4613 | https://github.com/matplotlib/matplotlib/issues/4613 |
| #4613 | https://github.com/matplotlib/matplotlib/issues/4613 |
| #4619 | https://github.com/matplotlib/matplotlib/pull/4619 |
| https://github.com/matplotlib/matplotlib/pull/4619/files#diff-0 | https://github.com/matplotlib/matplotlib/pull/4619/files#diff-0 |
| https://github.com/matplotlib/matplotlib/pull/4619.patch | https://github.com/matplotlib/matplotlib/pull/4619.patch |
| https://github.com/matplotlib/matplotlib/pull/4619.diff | https://github.com/matplotlib/matplotlib/pull/4619.diff |
| #4619 | https://github.com/matplotlib/matplotlib/pull/4619 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
| https://github.com/jenshnielsen |
| jenshnielsen | https://github.com/jenshnielsen |
| Jul 10, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#issuecomment-120529049 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
| https://github.com/jenshnielsen |
| jenshnielsen | https://github.com/jenshnielsen |
|
status: needs revision
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20revision%22 |
|
status: needs review
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20review%22 |
| Jul 10, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#event-353338561 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Jul 11, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#issuecomment-120646542 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
| https://github.com/jenshnielsen |
| jenshnielsen | https://github.com/jenshnielsen |
| Jul 11, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#issuecomment-120653186 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
| https://github.com/jenshnielsen |
| jenshnielsen | https://github.com/jenshnielsen |
| Jul 12, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#issuecomment-120730524 |
| #4485 | https://github.com/matplotlib/matplotlib/pull/4485 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
| https://github.com/blink1073 |
| blink1073 | https://github.com/blink1073 |
|
Jul 12, 2015
| https://github.com/matplotlib/matplotlib/pull/4619#ref-pullrequest-94595419 |
|
Do not let PIL manage the file handle
scikit-image/scikit-image#1604
| https://github.com/scikit-image/scikit-image/pull/1604 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Jul 17, 2015 | https://github.com/matplotlib/matplotlib/pull/4619#event-358484546 |
| https://github.com/jenshnielsen |
| jenshnielsen | https://github.com/jenshnielsen |
|
Oct 31, 2015
| https://github.com/matplotlib/matplotlib/pull/4619#ref-issue-114321721 |
|
Unclosed file warning in test_image.test_imread_pil_uint16
#5364
| https://github.com/matplotlib/matplotlib/issues/5364 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Jun 26, 2017 | https://github.com/matplotlib/matplotlib/pull/4619#issuecomment-310995996 |
| #5515 | https://github.com/matplotlib/matplotlib/pull/5515 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Jun 26, 2017 | https://github.com/matplotlib/matplotlib/pull/4619#event-1138226894 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4619 |
|
status: needs revision
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20revision%22 |
|
v2.1
| https://github.com/matplotlib/matplotlib/milestone/12 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/4619 |
|
| https://github.com/jenshnielsen |
|
| https://github.com/WeatherGod |
|
| https://github.com/tacaswell |
|
| https://github.com/anntzer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |