René's URL Explorer Experiment


Title: allow fillstyle 'none' option by cragm · Pull Request #447 · matplotlib/matplotlib · GitHub

Open Graph Title: allow fillstyle 'none' option by cragm · Pull Request #447 · matplotlib/matplotlib

X Title: allow fillstyle 'none' option by cragm · Pull Request #447 · matplotlib/matplotlib

Description: The fillstyle property currently allows full- and half-filling (top|bottom|left|right) of relevant markers. To the best of my understanding, creating an unfilled (i.e. just an outline) marker currently requires setting markerfacecolor to 'none' and markeredgecolor to the color of your choice (if you don't want black). In the interest of consistency, I added a fillstyle 'none' option to allow creation of unfilled markers using the same interface as the other filling options. In this implementation, when fillstyle=='none' and markerfacecolor == 'auto', the color returned by _get_markerfacecolor is 'none', as opposed to self._color in the original code. Similarly, when fillstyle=='none' and markeredgecolor == 'auto', the color returned by get_markeredgecolor is self._color, rather than 'k'. Note that this means setting markerfacecolor to something other than 'none' or 'auto' will generally result in a filled marker even when fillstyle=='none'. Giving fillstyle priority when returning markerfacecolor was another option, but I wasn't comfortable with masking a manual setting. There may exist better ways to handle this.

Open Graph Description: The fillstyle property currently allows full- and half-filling (top|bottom|left|right) of relevant markers. To the best of my understanding, creating an unfilled (i.e. just an outline) marker curr...

X Description: The fillstyle property currently allows full- and half-filling (top|bottom|left|right) of relevant markers. To the best of my understanding, creating an unfilled (i.e. just an outline) marker curr...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/447

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4375adc5-7214-2c6d-5c7b-a1e6c0ca33d3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD916:1352ED:D9DFA:12C926:6A512384
html-safe-noncec02648c43ee000ef5523a70730a9cdc8338afbc0a009332dbcf075843dc3a064
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTE2OjEzNTJFRDpEOURGQToxMkM5MjY6NkE1MTIzODQiLCJ2aXNpdG9yX2lkIjoiODA4NjIwNzA0Njc1ODc2OTU0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac05693ae51e81156f77564d6c580a0c9c942aa7cc5c56198fe08634d7db776dc4
hovercard-subject-tagpull_request:302130
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/447/files
twitter:imagehttps://avatars.githubusercontent.com/u/360669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/360669?s=400&v=4
og:image:altThe fillstyle property currently allows full- and half-filling (top|bottom|left|right) of relevant markers. To the best of my understanding, creating an unfilled (i.e. just an outline) marker curr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None689b683944b0d7f015d0e776452c970832fa81b82dc15284469b556ecced715b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release942b51ed3bd5feee3d5e2719f890a5fe286edbbb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/447/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F447%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F447%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/447/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/447/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/447/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/447/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/447/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
efiringhttps://github.com/efiring
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
Conversation 2 https://github.com/matplotlib/matplotlib/pull/447
Commits 10 https://github.com/matplotlib/matplotlib/pull/447/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/447/checks
Files changed https://github.com/matplotlib/matplotlib/pull/447/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/447/files
allow fillstyle 'none' option https://github.com/matplotlib/matplotlib/pull/447/files#top
Show all changes 10 commits https://github.com/matplotlib/matplotlib/pull/447/files
213459e first commit to allow fillstyle none Aug 31, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/213459eabb44b4b84bfafc51a9c6964f1e0494cf
785e66f auto markeredgecolor returns default color if fillstyle==none Aug 31, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/785e66fb94a0a2dcb5c8c8577ed7f980d8cd4dd3
5a2ced1 added missing fillstyle=='none' conditionals Sep 8, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/5a2ced18187a9b3d220b21e1369d68cca0a2d0f3
1982c51 trying to track down self._fillstyle error Sep 8, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/1982c51e74e52e27fcac116236a9d990ba4b7383
08de0bb Merge branch 'master' of git://github.com/matplotlib/matplotlib into … Oct 29, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/08de0bb645bf2eccb0e9c37c0e5b83bba9504136
392fe5d Merge branch 'master' into fillstyle_none cragm Nov 2, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/392fe5de0483c625fd3068375b65b22494591a62
9ac0f3d Use local function to check for half-filled markers. cragm Dec 7, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/9ac0f3d7bffdb8a74de7ff0838b65454df8feee3
9cff4e4 Merge branch 'master' from upstream into fillstyle_none. cragm Dec 8, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/9cff4e4d368f98ad68325785f199fd9ad4c1323b
c6e93d3 Fix missing 'self.'s in call of _half_fill method. cragm Dec 10, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/c6e93d3ed5f35a97a94ca3c522173290bdbfbc30
c40ba26 Merge branch 'master' into fillstyle_none cragm Dec 23, 2011 https://github.com/matplotlib/matplotlib/pull/447/commits/c40ba26d3f18e85b026779162232d3b3968dad87
Clear filters https://github.com/matplotlib/matplotlib/pull/447/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/447/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/447/files
lines.py https://github.com/matplotlib/matplotlib/pull/447/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
markers.py https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
lib/matplotlib/lines.pyhttps://github.com/matplotlib/matplotlib/pull/447/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
View file https://github.com/matplotlib/matplotlib/blob/c40ba26d3f18e85b026779162232d3b3968dad87/lib/matplotlib/lines.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/447/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/447/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
https://github.com/matplotlib/matplotlib/pull/447/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
https://github.com/matplotlib/matplotlib/pull/447/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
https://github.com/matplotlib/matplotlib/pull/447/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
https://github.com/matplotlib/matplotlib/pull/447/files#diff-be677869a88f58790f2387fb2ac0ae12e2e9610d7c7096e25d3087d5ed9645c8
lib/matplotlib/markers.pyhttps://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
View file https://github.com/matplotlib/matplotlib/blob/c40ba26d3f18e85b026779162232d3b3968dad87/lib/matplotlib/markers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/447/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com/matplotlib/matplotlib/pull/447/files#diff-0463a29ec8272d330266fc7f9314e6d1ee12dd8099a8b7184dd510823326991b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.