René's URL Explorer Experiment


Title: FIX : first pass at fixing nbagg close issue by tacaswell · Pull Request #4456 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX : first pass at fixing nbagg close issue by tacaswell · Pull Request #4456 · matplotlib/matplotlib

X Title: FIX : first pass at fixing nbagg close issue by tacaswell · Pull Request #4456 · matplotlib/matplotlib

Description: Add callback to destroy figure when the user hits the red x in the notebook. This is not the correct solution, but it (might) work for now. closes #4281 ?

Open Graph Description: Add callback to destroy figure when the user hits the red x in the notebook. This is not the correct solution, but it (might) work for now. closes #4281 ?

X Description: Add callback to destroy figure when the user hits the red x in the notebook. This is not the correct solution, but it (might) work for now. closes #4281 ?

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/4456

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d4f9dd4b-a821-5379-0c40-4d4fa983ce8e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C16:108FC:26DCC7F:345BF30:6A539C81
html-safe-nonce397aba3ddb255800c782527509c341eeda7272b62025ef147082798fe4f7c600
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzE2OjEwOEZDOjI2RENDN0Y6MzQ1QkYzMDo2QTUzOUM4MSIsInZpc2l0b3JfaWQiOiI0ODQwMjIwNzc5MDU5ODQ2MjczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac210b406dbd8de73c1203852e67abb8fe9d9f952bc071c60583735721ef3bd30a
hovercard-subject-tagpull_request:36042410
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/4456/files
twitter:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
og:image:altAdd callback to destroy figure when the user hits the red x in the notebook. This is not the correct solution, but it (might) work for now. closes #4281 ?
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/4456/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4456%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4456%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/4456/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/4456/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/4456/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4456/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4456/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
jenshnielsenhttps://github.com/jenshnielsen
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:fix_nbagg_closehttps://github.com/tacaswell/matplotlib/tree/fix_nbagg_close
Conversation 29 https://github.com/matplotlib/matplotlib/pull/4456
Commits 6 https://github.com/matplotlib/matplotlib/pull/4456/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/4456/checks
Files changed https://github.com/matplotlib/matplotlib/pull/4456/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4456/files
FIX : first pass at fixing nbagg close issue https://github.com/matplotlib/matplotlib/pull/4456/files#top
Show all changes 6 commits https://github.com/matplotlib/matplotlib/pull/4456/files
bd0a3f8 FIX : first pass at fixing nbagg close issue tacaswell May 22, 2015 https://github.com/matplotlib/matplotlib/pull/4456/commits/bd0a3f8de6e40bf595bf5fd2be7712d24df65f8c
b16fcf9 FIX: move logic where it should be tacaswell Jul 5, 2015 https://github.com/matplotlib/matplotlib/pull/4456/commits/b16fcf9d9f2b74afa560e03b98e4bed3d7abbd9a
6678e02 WIP: race condition? tacaswell Jul 23, 2015 https://github.com/matplotlib/matplotlib/pull/4456/commits/6678e029c566a9b0bb6e4261c8422dfd4795cc69
436dfdb FIX: destroy figs in python when destroyed in js tacaswell Aug 16, 2015 https://github.com/matplotlib/matplotlib/pull/4456/commits/436dfdbc4cb6b4a9cd9868b4dd36d60cdcc7da97
f1c9d78 MNT: suppress pending figure count in interactive tacaswell Aug 16, 2015 https://github.com/matplotlib/matplotlib/pull/4456/commits/f1c9d7881d690e42cce8dbe2931638330a705fad
3aa3909 TST: update UAT tacaswell Aug 17, 2015 https://github.com/matplotlib/matplotlib/pull/4456/commits/3aa39094d1a167dd233c17359fa7fa7a19fe9937
Clear filters https://github.com/matplotlib/matplotlib/pull/4456/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4456/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4456/files
backend_nbagg.py https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
backend_webagg_core.py https://github.com/matplotlib/matplotlib/pull/4456/files#diff-6d1e28fa9eb5254b30f1dd613881417bb4f173ea90669dc55c3bb4fe9b5ab73f
nbagg_mpl.js https://github.com/matplotlib/matplotlib/pull/4456/files#diff-66ec420eb4b11ded51214991905e71f57677f7169b256e2f7313e39ae2a4b86e
nbagg_uat.ipynb https://github.com/matplotlib/matplotlib/pull/4456/files#diff-74325e256dd0a931e0eead30b259119d7dedb408b3774f693f44fd0de4f4bcab
lib/matplotlib/backends/backend_nbagg.pyhttps://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
View file https://github.com/tacaswell/matplotlib/blob/3aa39094d1a167dd233c17359fa7fa7a19fe9937/lib/matplotlib/backends/backend_nbagg.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/4456/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
OceanWolfhttps://github.com/OceanWolf
Aug 17, 2015https://github.com/matplotlib/matplotlib/pull/4456/files#r37160507
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4456/files
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-7a496f2cfdd909d2c60b97b27d30b782910b350cb20bd3f4a05c4b9bf4865ce8
lib/matplotlib/backends/backend_webagg_core.pyhttps://github.com/matplotlib/matplotlib/pull/4456/files#diff-6d1e28fa9eb5254b30f1dd613881417bb4f173ea90669dc55c3bb4fe9b5ab73f
View file https://github.com/tacaswell/matplotlib/blob/3aa39094d1a167dd233c17359fa7fa7a19fe9937/lib/matplotlib/backends/backend_webagg_core.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/4456/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-6d1e28fa9eb5254b30f1dd613881417bb4f173ea90669dc55c3bb4fe9b5ab73f
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-6d1e28fa9eb5254b30f1dd613881417bb4f173ea90669dc55c3bb4fe9b5ab73f
lib/matplotlib/backends/web_backend/nbagg_mpl.jshttps://github.com/matplotlib/matplotlib/pull/4456/files#diff-66ec420eb4b11ded51214991905e71f57677f7169b256e2f7313e39ae2a4b86e
View file https://github.com/tacaswell/matplotlib/blob/3aa39094d1a167dd233c17359fa7fa7a19fe9937/lib/matplotlib/backends/web_backend/nbagg_mpl.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/4456/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-66ec420eb4b11ded51214991905e71f57677f7169b256e2f7313e39ae2a4b86e
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-66ec420eb4b11ded51214991905e71f57677f7169b256e2f7313e39ae2a4b86e
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-66ec420eb4b11ded51214991905e71f57677f7169b256e2f7313e39ae2a4b86e
https://github.com/matplotlib/matplotlib/pull/4456/files#diff-66ec420eb4b11ded51214991905e71f57677f7169b256e2f7313e39ae2a4b86e
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4456/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.