René's URL Explorer Experiment


Title: Implementation of Issue #4044. Added ScientificTable and ScientificCell subclasses. by dkua · Pull Request #4259 · matplotlib/matplotlib · GitHub

Open Graph Title: Implementation of Issue #4044. Added ScientificTable and ScientificCell subclasses. by dkua · Pull Request #4259 · matplotlib/matplotlib

X Title: Implementation of Issue #4044. Added ScientificTable and ScientificCell subclasses. by dkua · Pull Request #4259 · matplotlib/matplotlib

Description: This implements the requested feature in issue #4044 Two subclasses, ScientificTable and ScientificCell, were created of Table and Cell respectively. An extra kwarg was added to the table() factory function for choosing the type of Table to use. The factory function and the table types were tested with the test_table_types test in test_table.py. A new test image was also added. The test passes in Ubuntu 12.04 64-bit. The feature was implemented by having ScientificCell extend Cell with an additional method get_path() which simply returns a new Path instance that doesn't draw a line when moving between the vertices that make up a vertical line. This works because Cell.draw() calls Rectangle.draw() which calls self.get_path(). However Cell passes into Rectangle.draw() the arguments self, renderer. So the self.get_path() call is actually calling Cell but since it doesn't have that method it uses it's super class' definition which is Rectangle. By creating the new subclass with our own get_path() method we can implement this feature while following the same logic.

Open Graph Description: This implements the requested feature in issue #4044 Two subclasses, ScientificTable and ScientificCell, were created of Table and Cell respectively. An extra kwarg was added to the table() factory...

X Description: This implements the requested feature in issue #4044 Two subclasses, ScientificTable and ScientificCell, were created of Table and Cell respectively. An extra kwarg was added to the table() factory...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/4259

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f45c0a02-6de6-468e-1572-fae24139e34d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD964:3A796C:9BA6CC:D03F48:6A531655
html-safe-nonce6c917f2d93d0be35481221d2ec834bf2896850d2927bc01f9abfcad8d2cfd715
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTY0OjNBNzk2Qzo5QkE2Q0M6RDAzRjQ4OjZBNTMxNjU1IiwidmlzaXRvcl9pZCI6IjEwMjUzNTYzNzM0OTQ1MzU3NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfc0221fb8d1a53f8eea8bd6eb30ec9725b37c0c0331a3e86a0f0b8d78256a3fb
hovercard-subject-tagpull_request:31681789
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/4259/files
twitter:imagehttps://avatars.githubusercontent.com/u/1531139?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1531139?s=400&v=4
og:image:altThis implements the requested feature in issue #4044 Two subclasses, ScientificTable and ScientificCell, were created of Table and Cell respectively. An extra kwarg was added to the table() factory...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/4259/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4259%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4259%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/4259/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/4259/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/4259/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
dkua:feature_4044https://github.com/dkua/matplotlib/tree/feature_4044
Conversation 70 https://github.com/matplotlib/matplotlib/pull/4259
Commits 14 https://github.com/matplotlib/matplotlib/pull/4259/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/4259/checks
Files changed https://github.com/matplotlib/matplotlib/pull/4259/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
Implementation of Issue #4044. Added ScientificTable and ScientificCell subclasses. https://github.com/matplotlib/matplotlib/pull/4259/files#top
Show all changes 14 commits https://github.com/matplotlib/matplotlib/pull/4259/files
e893f58 Added ScientificTable type and option. Mar 21, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/e893f5843ea2a6c80bd483c6f8cb83044c6c7748
fffc63f Updated comments for the Scientific Table and Cell Mar 21, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/fffc63fff9f9a7d9f0f43d29d67b825a7da68c98
d2b8b27 Added test + test image for new Table types Mar 21, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/d2b8b276fe77ce10165302c7287db8f8fa41b794
d8a42dd Implemented different cell type selection method. dkua Mar 22, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/d8a42dda009236f49c0399aaec3fcda260d0dbe6
d2c3158 Fixed pep8 issues in table.py and test_table.py Mar 22, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/d2c31588bb6d910936a1ac261b748f99636e670e
4542ee7 Reworked feature 4044 so that all cell boundries can be toggled into … Mar 28, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/4542ee7bc879154923d7a8bc30914282673c7f98
39cecdc Tests for new Table Cell feature (4044) added Mar 28, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/39cecdc177fea0369f40123d503932f9f076eae5
7b32f5e Cleaned up test for test_table dkua Mar 31, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/7b32f5ef88853c16543983f45d72752a175e1e5a
6169f0c Cleaned up code to get it ready for PR. dkua Mar 31, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/6169f0cf133cbf63d2ea1264c6b32f4310deccb9
b68c05f Fixed issue with CustomCell's get_path() + setter for CustomCell's vi… Mar 31, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/b68c05ff71893d4d60104f727a82126cbbd8223b
9337be7 Updated tests to be more minimal. dkua Apr 1, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/9337be7d43785eaf4bda2161b452d60db4bf2030
ac6f471 Changed default edge type to be understandable dkua Apr 1, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/ac6f47146b145e822c264fd5780ad90c8be48099
842a5c4 Added tests for CustomCell Apr 7, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/842a5c45961844b7b60d15a2b09608766ceb9636
17576d8 Added What's New entry for Table edge feature dkua Apr 14, 2015 https://github.com/matplotlib/matplotlib/pull/4259/commits/17576d8e3d1ce3e96d4426e933e98146c4cbdcd1
Clear filters https://github.com/matplotlib/matplotlib/pull/4259/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
updated_table.rst https://github.com/matplotlib/matplotlib/pull/4259/files#diff-8c1c03d68b9e654a92f51f866906c83d45a6861d197a688732a256942dff140f
table.py https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
table_cell_manipulation.png https://github.com/matplotlib/matplotlib/pull/4259/files#diff-c6488d5fb5afc37ce9986fa8f85521130ce55db93c9cb9d11de6a995b181c88a
test_table.py https://github.com/matplotlib/matplotlib/pull/4259/files#diff-b9af05a8665bd98d5dcced0a855894381980d6092eb5ac294b6a12990d93521e
doc/users/whats_new/updated_table.rsthttps://github.com/matplotlib/matplotlib/pull/4259/files#diff-8c1c03d68b9e654a92f51f866906c83d45a6861d197a688732a256942dff140f
View file https://github.com/dkua/matplotlib/blob/17576d8e3d1ce3e96d4426e933e98146c4cbdcd1/doc/users/whats_new/updated_table.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/4259/{{ revealButtonHref }}
lib/matplotlib/table.pyhttps://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
View file https://github.com/dkua/matplotlib/blob/17576d8e3d1ce3e96d4426e933e98146c4cbdcd1/lib/matplotlib/table.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/4259/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
tacaswellhttps://github.com/tacaswell
Apr 12, 2015https://github.com/matplotlib/matplotlib/pull/4259/files#r28199478
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
dkuahttps://github.com/dkua
Apr 12, 2015https://github.com/matplotlib/matplotlib/pull/4259/files#r28204439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@tacaswellhttps://github.com/tacaswell
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
tacaswellhttps://github.com/tacaswell
Apr 13, 2015https://github.com/matplotlib/matplotlib/pull/4259/files#r28281513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
dkuahttps://github.com/dkua
Apr 13, 2015https://github.com/matplotlib/matplotlib/pull/4259/files#r28290371
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@tacaswellhttps://github.com/tacaswell
https://www.python.org/dev/peps/pep-0008/https://www.python.org/dev/peps/pep-0008/
http://stackoverflow.com/questions/13497793/python-alignment-of-assignments-stylehttp://stackoverflow.com/questions/13497793/python-alignment-of-assignments-style
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
tacaswellhttps://github.com/tacaswell
Apr 14, 2015https://github.com/matplotlib/matplotlib/pull/4259/files#r28295278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-308367839e736b66a5e3580bd42cc742a3ed0ac224549ab9240dc3b954bf0342
lib/matplotlib/tests/baseline_images/test_table/table_cell_manipulation.pnghttps://github.com/matplotlib/matplotlib/pull/4259/files#diff-c6488d5fb5afc37ce9986fa8f85521130ce55db93c9cb9d11de6a995b181c88a
View file https://github.com/dkua/matplotlib/blob/17576d8e3d1ce3e96d4426e933e98146c4cbdcd1/lib/matplotlib/tests/baseline_images/test_table/table_cell_manipulation.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/4259/files
lib/matplotlib/tests/test_table.pyhttps://github.com/matplotlib/matplotlib/pull/4259/files#diff-b9af05a8665bd98d5dcced0a855894381980d6092eb5ac294b6a12990d93521e
View file https://github.com/dkua/matplotlib/blob/17576d8e3d1ce3e96d4426e933e98146c4cbdcd1/lib/matplotlib/tests/test_table.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/4259/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-b9af05a8665bd98d5dcced0a855894381980d6092eb5ac294b6a12990d93521e
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-b9af05a8665bd98d5dcced0a855894381980d6092eb5ac294b6a12990d93521e
https://github.com/matplotlib/matplotlib/pull/4259/files#diff-b9af05a8665bd98d5dcced0a855894381980d6092eb5ac294b6a12990d93521e
efiringhttps://github.com/efiring
Apr 1, 2015https://github.com/matplotlib/matplotlib/pull/4259/files#r27602717
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
tacaswellhttps://github.com/tacaswell
Apr 12, 2015https://github.com/matplotlib/matplotlib/pull/4259/files#r28199485
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
efiringhttps://github.com/efiring
Apr 1, 2015https://github.com/matplotlib/matplotlib/pull/4259/files#r27603053
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4259/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.