René's URL Explorer Experiment


Title: [WIP] Fix annotation get window extent by itziakos · Pull Request #4023 · matplotlib/matplotlib · GitHub

Open Graph Title: [WIP] Fix annotation get window extent by itziakos · Pull Request #4023 · matplotlib/matplotlib

X Title: [WIP] Fix annotation get window extent by itziakos · Pull Request #4023 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: This PR reworks Annotation to provide a get_window_extent method that will return as bounding box the union of the contained text and arrow. Pending: more tests cleanup

X Description: This PR reworks Annotation to provide a get_window_extent method that will return as bounding box the union of the contained text and arrow. Pending: more tests cleanup

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/4023

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a14b1dea-2862-e5c9-099b-458600864d3d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87F0:20D7FA:1155ADA:1747D0D:6A544841
html-safe-nonce5141af3f1016943232cee0dd0fa45ffc119270b08db632a56f4faf9f08bc9ac7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0YwOjIwRDdGQToxMTU1QURBOjE3NDdEMEQ6NkE1NDQ4NDEiLCJ2aXNpdG9yX2lkIjoiNTc2MjA0MjMzNDEyNTc3MDgxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf351fd0720409cafef004c3786ed878b6dd0f7077f27500e49116299b2701c9f
hovercard-subject-tagpull_request:27756569
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/4023/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cdaf2ed23b29846cfb46c71e7e41432238bcc2346daa4ac720612fb0da8ade18/matplotlib/matplotlib/pull/4023
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cdaf2ed23b29846cfb46c71e7e41432238bcc2346daa4ac720612fb0da8ade18/matplotlib/matplotlib/pull/4023
og:image:altThis PR reworks Annotation to provide a get_window_extent method that will return as bounding box the union of the contained text and arrow. Pending: more tests cleanup
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameitziakos
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/4023#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4023
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4023
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/4023
Reloadhttps://github.com/matplotlib/matplotlib/pull/4023
Reloadhttps://github.com/matplotlib/matplotlib/pull/4023
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
itziakoshttps://github.com/itziakos
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
itziakos:fix-annotation-get-window-extenthttps://github.com/itziakos/matplotlib/tree/fix-annotation-get-window-extent
Conversationhttps://github.com/matplotlib/matplotlib/pull/4023
Commits8 (8)https://github.com/matplotlib/matplotlib/pull/4023/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/4023/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/4023/files
[WIP] Fix annotation get window extenthttps://github.com/matplotlib/matplotlib/pull/4023#top
itziakoshttps://github.com/itziakos
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
itziakos:fix-annotation-get-window-extenthttps://github.com/itziakos/matplotlib/tree/fix-annotation-get-window-extent
https://github.com/itziakos
itziakoshttps://github.com/itziakos
Jan 21, 2015https://github.com/matplotlib/matplotlib/pull/4023#issue-55013685
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
itziakoshttps://github.com/itziakos
December 13, 2014 01:06https://github.com/matplotlib/matplotlib/pull/4023#commits-pushed-acde5eb
https://github.com/itziakos
Add draft implementation of the get_window_extent methodhttps://github.com/matplotlib/matplotlib/pull/4023/commits/acde5eb1040a25e6aac583cf3de698014f3bc1b9
acde5ebhttps://github.com/matplotlib/matplotlib/pull/4023/commits/acde5eb1040a25e6aac583cf3de698014f3bc1b9
https://github.com/itziakos
add tests for empty and arrow only annotationhttps://github.com/matplotlib/matplotlib/pull/4023/commits/36522f809412be925f18bb65b4a057e6ce34819d
36522f8https://github.com/matplotlib/matplotlib/pull/4023/commits/36522f809412be925f18bb65b4a057e6ce34819d
https://github.com/itziakos
add test for annotation having only a texthttps://github.com/matplotlib/matplotlib/pull/4023/commits/4d7b131873d8779d1ee865cb664cec36693a608b
4d7b131https://github.com/matplotlib/matplotlib/pull/4023/commits/4d7b131873d8779d1ee865cb664cec36693a608b
https://github.com/itziakos
make sure that we use Text.get_window_extent when we only want the texthttps://github.com/matplotlib/matplotlib/pull/4023/commits/634251d0e04a48a2457c9503761e26bf9bf80e06
634251dhttps://github.com/matplotlib/matplotlib/pull/4023/commits/634251d0e04a48a2457c9503761e26bf9bf80e06
https://github.com/itziakos
add test for annotation with text and arrowhttps://github.com/matplotlib/matplotlib/pull/4023/commits/689c0192f734e844a859f2b5fe9e04514724d2c6
689c019https://github.com/matplotlib/matplotlib/pull/4023/commits/689c0192f734e844a859f2b5fe9e04514724d2c6
https://github.com/itziakos
fix bad mergehttps://github.com/matplotlib/matplotlib/pull/4023/commits/000cd2b4e3691780fa6aca57b7d6abe433893d0a
000cd2bhttps://github.com/matplotlib/matplotlib/pull/4023/commits/000cd2b4e3691780fa6aca57b7d6abe433893d0a
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
status: needs review https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20review%22
Jan 21, 2015https://github.com/matplotlib/matplotlib/pull/4023#event-222274864
https://github.com/itziakos
itziakoshttps://github.com/itziakos
Jan 21, 2015 https://github.com/matplotlib/matplotlib/pull/4023#ref-issue-49394909
savefig with bbox_inches='tight' ignores annotation without text #3816 https://github.com/matplotlib/matplotlib/issues/3816
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 21, 2015https://github.com/matplotlib/matplotlib/pull/4023#issuecomment-70875617
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
https://github.com/itziakos
itziakoshttps://github.com/itziakos
Jan 21, 2015https://github.com/matplotlib/matplotlib/pull/4023#issuecomment-70883639
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
https://github.com/itziakos
Merge branch 'master' into fix-annotation-get-window-extenthttps://github.com/matplotlib/matplotlib/pull/4023/commits/a9017046eb8b96999c530544a73216239be71c89
a901704https://github.com/matplotlib/matplotlib/pull/4023/commits/a9017046eb8b96999c530544a73216239be71c89
https://github.com/itziakos
itziakoshttps://github.com/itziakos
Jan 21, 2015https://github.com/matplotlib/matplotlib/pull/4023#issuecomment-70898527
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
tacaswellhttps://github.com/tacaswell
Jan 21, 2015 https://github.com/matplotlib/matplotlib/pull/4023#discussion-diff-23326314
View reviewed changes https://github.com/matplotlib/matplotlib/pull/4023/files/a9017046eb8b96999c530544a73216239be71c89#diff-48a87c3198fe994a8e31c16272b931d7dc307a88deba61086ca483ff44bacaa4
lib/matplotlib/tests/test_text.pyhttps://github.com/matplotlib/matplotlib/pull/4023/files#diff-48a87c3198fe994a8e31c16272b931d7dc307a88deba61086ca483ff44bacaa4
tacaswellhttps://github.com/tacaswell
Jan 21, 2015https://github.com/matplotlib/matplotlib/pull/4023#discussion_r23326314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
tacaswellhttps://github.com/tacaswell
Jan 21, 2015https://github.com/matplotlib/matplotlib/pull/4023#discussion_r23326578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v1.4.3https://github.com/matplotlib/matplotlib/milestone/17
Jan 26, 2015https://github.com/matplotlib/matplotlib/pull/4023#event-224418752
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 27, 2015 https://github.com/matplotlib/matplotlib/pull/4023#ref-pullrequest-54841707
[WIP] Quad mesh extent #3095 #4017 https://github.com/matplotlib/matplotlib/pull/4017
https://github.com/itziakos
remove duplicate imports and pyflakes cleanuphttps://github.com/matplotlib/matplotlib/pull/4023/commits/316b1847ead98e9eaba44f7bad39425e321f43e3
316b184https://github.com/matplotlib/matplotlib/pull/4023/commits/316b1847ead98e9eaba44f7bad39425e321f43e3
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Release critical https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22
Jan 31, 2015https://github.com/matplotlib/matplotlib/pull/4023#event-228010644
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 31, 2015https://github.com/matplotlib/matplotlib/pull/4023#issuecomment-72332814
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
tacaswellhttps://github.com/tacaswell
Jan 31, 2015 https://github.com/matplotlib/matplotlib/pull/4023#ref-commit-26c7d65
https://github.com/tacaswell
Merge Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/26c7d656de106534b1871433c965dac9789ef264
#4023https://github.com/matplotlib/matplotlib/pull/4023
from itziakos/fix-annotation-get-windo…https://github.com/matplotlib/matplotlib/commit/26c7d656de106534b1871433c965dac9789ef264
26c7d65https://github.com/matplotlib/matplotlib/commit/26c7d656de106534b1871433c965dac9789ef264
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 31, 2015https://github.com/matplotlib/matplotlib/pull/4023#issuecomment-72338989
26c7d65https://github.com/matplotlib/matplotlib/commit/26c7d656de106534b1871433c965dac9789ef264
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 31, 2015https://github.com/matplotlib/matplotlib/pull/4023#event-228048011
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
status: needs review https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20review%22
Jan 31, 2015https://github.com/matplotlib/matplotlib/pull/4023#event-228048013
https://github.com/itziakos
itziakoshttps://github.com/itziakos
Feb 1, 2015https://github.com/matplotlib/matplotlib/pull/4023#issuecomment-72363806
@tacaswellhttps://github.com/tacaswell
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Feb 1, 2015https://github.com/matplotlib/matplotlib/pull/4023#issuecomment-72386199
@itziakoshttps://github.com/itziakos
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
https://github.com/itziakos
itziakoshttps://github.com/itziakos
Feb 2, 2015https://github.com/matplotlib/matplotlib/pull/4023#issuecomment-72442144
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
https://github.com/jenshnielsen
jenshnielsenhttps://github.com/jenshnielsen
Feb 21, 2015 https://github.com/matplotlib/matplotlib/pull/4023#ref-issue-58465861
Annotation text bbox calculated incorrectly in matplotlib>=1.4.3? #4139 https://github.com/matplotlib/matplotlib/issues/4139
https://github.com/cimarronm
cimarronmhttps://github.com/cimarronm
Feb 22, 2015 https://github.com/matplotlib/matplotlib/pull/4023#ref-pullrequest-58514404
Fixed Annotation draw method #4145 https://github.com/matplotlib/matplotlib/pull/4145
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jun 15, 2023 https://github.com/matplotlib/matplotlib/pull/4023#ref-pullrequest-1759231585
Tst/restore old tests #26131 https://github.com/matplotlib/matplotlib/pull/26131
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F4023
Release critical https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22
v1.4.3 https://github.com/matplotlib/matplotlib/milestone/17
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/4023
https://github.com/itziakos
https://github.com/tacaswell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.