Title: MNT: use more-inclusive language in _trirefine.py by dhananjaya-kularatne · Pull Request #32040 · matplotlib/matplotlib · GitHub
Open Graph Title: MNT: use more-inclusive language in _trirefine.py by dhananjaya-kularatne · Pull Request #32040 · matplotlib/matplotlib
X Title: MNT: use more-inclusive language in _trirefine.py by dhananjaya-kularatne · Pull Request #32040 · matplotlib/matplotlib
Description: PR summary Closes #32039. Renames master/slave terminology in _refine_triangulation_once (both in-line comments and variable names) to major/minor, which preserves the original meaning (the triangle with the higher vs. lower index at a shared edge) without using outdated terminology. This is a pure renaming change — no logic was modified. All existing tests in test_triangulation.py pass unchanged (50 passed), including test_trirefine, test_trirefine_masked, and test_trirefiner_fortran_contiguous_triangles, which exercise this function directly. Naming follows the discussion in #32039; happy to adjust if maintainers land on different terminology. AI Disclosure I used Claude (Anthropic) as a guide throughout this contribution — for identifying the issue, planning the rename scope, drafting the replacement code, and walking through the Git/build/test workflow. All code was reviewed, tested locally, and understood by me before submitting. PR checklist "closes #32039" is in the body of the PR description new and changed code is tested (existing tests pass; this is a pure rename with no behavior change) Plotting related features are demonstrated in an example (N/A — not a plotting feature) New Features and API Changes are noted (N/A — internal rename, no public API change) Documentation complies with general and docstring guidelines (N/A — no docstrings were touched, only internal comments/variables)
Open Graph Description: PR summary Closes #32039. Renames master/slave terminology in _refine_triangulation_once (both in-line comments and variable names) to major/minor, which preserves the original meaning (the triangl...
X Description: PR summary Closes #32039. Renames master/slave terminology in _refine_triangulation_once (both in-line comments and variable names) to major/minor, which preserves the original meaning (the triangl...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/32040
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:782c00f8-ecd4-f86f-4f13-d641d24d3375 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D906:18F1D7:4CBD11:69FD14:6A639C8D |
| html-safe-nonce | 531add51e13f43576f194a69d2c3c8543dcd1980e56f6beb388bc0a65bab9247 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTA2OjE4RjFENzo0Q0JEMTE6NjlGRDE0OjZBNjM5QzhEIiwidmlzaXRvcl9pZCI6IjE1NTY2MTc0NzgzODY0NTc3NDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | aae7423718d186787fbdf1b377dd429a105867b2a751d1c23b21b5d1ad1eb188 |
| hovercard-subject-tag | pull_request:4043543893 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/32040/files |
| twitter:image | https://avatars.githubusercontent.com/u/169973923?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/169973923?s=400&v=4 |
| og:image:alt | PR summary Closes #32039. Renames master/slave terminology in _refine_triangulation_once (both in-line comments and variable names) to major/minor, which preserves the original meaning (the triangl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ca676e17c4da4532dc68541e9fc874034ae840c26b5f34da7f1c42d9a600659 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3a0a9f049e072eb8e5795dfddcefdba9e277501d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width