Title: Fix PDF marker culling with translated master transform by Ayush-0918 · Pull Request #32003 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix PDF marker culling with translated master transform by Ayush-0918 · Pull Request #32003 · matplotlib/matplotlib
X Title: Fix PDF marker culling with translated master transform by Ayush-0918 · Pull Request #32003 · matplotlib/matplotlib
Description: closes #31999 PR summary This PR fixes incorrect marker culling in the PDF backend when master_transform includes a translation. The visibility check was using untranslated marker coordinates, which could incorrectly skip markers that become visible after the translation is applied. This could lead to missing markers in the generated PDF. This change applies the translated coordinates only for the visibility check, while keeping the existing rendering coordinates unchanged. This preserves the current rendering behavior and fixes the culling logic. Testing Reproduced the issue using the example from #31999. Verified that the generated PDF now matches the PNG output. Confirmed that markers that were previously missing are rendered correctly. AI Disclosure I used ChatGPT as a debugging assistant to help reason about the rendering logic and discuss possible approaches. I implemented the final solution myself, verified the behavior locally, and reviewed the final changes before submitting this pull request. PR checklist closes #31999 is in the body of the PR description new and changed code is tested Plotting related features are demonstrated in an example (N/A) New Features and API Changes are noted with a directive and release note (N/A) Documentation complies with general and docstring guidelines (N/A)
Open Graph Description: closes #31999 PR summary This PR fixes incorrect marker culling in the PDF backend when master_transform includes a translation. The visibility check was using untranslated marker coordinates, whic...
X Description: closes #31999 PR summary This PR fixes incorrect marker culling in the PDF backend when master_transform includes a translation. The visibility check was using untranslated marker coordinates, whic...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/32003
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2acf7f7c-df84-8259-9b86-e3b53a6ee176 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE68:2C2A02:198555A:22B6733:6A4F2CCE |
| html-safe-nonce | 720ee5f84a85cd20bddd1ee105ebb7d861389d461f566660f7c85f2d33a1a259 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTY4OjJDMkEwMjoxOTg1NTVBOjIyQjY3MzM6NkE0RjJDQ0UiLCJ2aXNpdG9yX2lkIjoiMzcyODQxMDkzMzMzODI1NDU0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f85238212954f75da2d66d4d9e610c6fa1422e119b858a48309d26f0c37ebc5e |
| hovercard-subject-tag | pull_request:3994653857 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/32003/files |
| twitter:image | https://avatars.githubusercontent.com/u/184804819?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/184804819?s=400&v=4 |
| og:image:alt | closes #31999 PR summary This PR fixes incorrect marker culling in the PDF backend when master_transform includes a translation. The visibility check was using untranslated marker coordinates, whic... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width