René's URL Explorer Experiment


Title: TST: Harden handling of Popen subprocesses by QuLogic · Pull Request #31503 · matplotlib/matplotlib · GitHub

Open Graph Title: TST: Harden handling of Popen subprocesses by QuLogic · Pull Request #31503 · matplotlib/matplotlib

X Title: TST: Harden handling of Popen subprocesses by QuLogic · Pull Request #31503 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR summary This PR does two things: Wrap _WaitForStringPopen in a context manager: We do attempt to kill the subprocess in all cases, but this should also ensure that file descriptors are closed. ...

X Description: PR summary This PR does two things: Wrap _WaitForStringPopen in a context manager: We do attempt to kill the subprocess in all cases, but this should also ensure that file descriptors are closed. ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/31503

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9aff939a-0433-a28e-9350-7d3b263fb5e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA456:291A44:B0C6C1:EFD3AC:6A51639E
html-safe-nonceeea7bf2ecfb04fd14b877b3c8ba1d78536128bf2cd8a1a7b0817149e7d1bf5c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDU2OjI5MUE0NDpCMEM2QzE6RUZEM0FDOjZBNTE2MzlFIiwidmlzaXRvcl9pZCI6IjUyMzYwNTg1OTI5OTAyOTA4NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacca5d8b8f1590e3a44749986aa858a355614ce9704847264f96104d27159f5be2
hovercard-subject-tagpull_request:3537317575
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/31503/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3703c94dec48f3bd25a2bed3a41336676a300a02d628bc795cbd82bc7870b1f3/matplotlib/matplotlib/pull/31503
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3703c94dec48f3bd25a2bed3a41336676a300a02d628bc795cbd82bc7870b1f3/matplotlib/matplotlib/pull/31503
og:image:altPR summary This PR does two things: Wrap _WaitForStringPopen in a context manager: We do attempt to kill the subprocess in all cases, but this should also ensure that file descriptors are closed. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameQuLogic
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2eeb434949a926fad21064b4d395a54759f7a0b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/31503/#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31503%2F
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31503%2F
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/31503/
Reloadhttps://github.com/matplotlib/matplotlib/pull/31503/
Reloadhttps://github.com/matplotlib/matplotlib/pull/31503/
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31503/
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31503/
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
tacaswellhttps://github.com/tacaswell
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
QuLogic:popen-contextshttps://github.com/QuLogic/matplotlib/tree/popen-contexts
Conversationhttps://github.com/matplotlib/matplotlib/pull/31503
Commits4 (4)https://github.com/matplotlib/matplotlib/pull/31503/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/31503/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/31503/files
TST: Harden handling of Popen subprocesseshttps://github.com/matplotlib/matplotlib/pull/31503/#top
tacaswellhttps://github.com/tacaswell
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
QuLogic:popen-contextshttps://github.com/QuLogic/matplotlib/tree/popen-contexts
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Apr 16, 2026https://github.com/matplotlib/matplotlib/pull/31503/#issue-4272998632
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31503/
link the related issuehttps://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
testedhttps://matplotlib.org/devdocs/devel/testing.html
examplehttps://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials
directive and release notehttps://matplotlib.org/devdocs/devel/api_changes.html#announce-changes-deprecations-and-new-features
generalhttps://matplotlib.org/devdocs/devel/document.html#write-rest-pages
docstringhttps://matplotlib.org/devdocs/devel/document.html#write-docstrings
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31503/
QuLogichttps://github.com/QuLogic
April 15, 2026 22:46https://github.com/matplotlib/matplotlib/pull/31503/#commits-pushed-c8b3e18
https://github.com/QuLogic
TST: Wrap _WaitForStringPopen in a context managerhttps://github.com/matplotlib/matplotlib/pull/31503/commits/c8b3e18e18ca3004c05e6ec48fd23cb5086dfcf8
c8b3e18https://github.com/matplotlib/matplotlib/pull/31503/commits/c8b3e18e18ca3004c05e6ec48fd23cb5086dfcf8
https://github.com/QuLogic
TST: Avoid hard-coded port in test_webagghttps://github.com/matplotlib/matplotlib/pull/31503/commits/4890369effce45ddd00a279cad9ef4ee91560097
4890369https://github.com/matplotlib/matplotlib/pull/31503/commits/4890369effce45ddd00a279cad9ef4ee91560097
https://github.com/QuLogic
TST: Wrap urlopen in a context manager as wellhttps://github.com/matplotlib/matplotlib/pull/31503/commits/6b5bc461bdfc88624f4f788fcaa4561d6989ad80
6b5bc46https://github.com/matplotlib/matplotlib/pull/31503/commits/6b5bc461bdfc88624f4f788fcaa4561d6989ad80
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
topic: testing https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22
GUI: webagg https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20webagg%22
Apr 16, 2026https://github.com/matplotlib/matplotlib/pull/31503/#event-24551780998
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
GUI: webagg https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20webagg%22
Apr 16, 2026https://github.com/matplotlib/matplotlib/pull/31503/#event-24551783984
https://github.com/ksunden
ksundenhttps://github.com/ksunden
Apr 16, 2026 https://github.com/matplotlib/matplotlib/pull/31503/#pullrequestreview-4118202477
View reviewed changes https://github.com/matplotlib/matplotlib/pull/31503/files/6b5bc461bdfc88624f4f788fcaa4561d6989ad80
lib/matplotlib/tests/test_backends_interactive.pyhttps://github.com/matplotlib/matplotlib/pull/31503/files/6b5bc461bdfc88624f4f788fcaa4561d6989ad80#diff-b5dab748133c9dd713a6516d6a45072cedb7b587dfa23d57838d7ed17fe5283d
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31503/
https://github.com/QuLogic
https://github.com/ksunden
TST: Tweak timeout setup in test_webagghttps://github.com/matplotlib/matplotlib/pull/31503/commits/eebd8546b9f9c8f37b5e93118ab52a3af15d63ff
eebd854https://github.com/matplotlib/matplotlib/pull/31503/commits/eebd8546b9f9c8f37b5e93118ab52a3af15d63ff
https://github.com/ksunden
ksundenhttps://github.com/ksunden
Apr 16, 2026 https://github.com/matplotlib/matplotlib/pull/31503/#pullrequestreview-4118474162
View reviewed changes https://github.com/matplotlib/matplotlib/pull/31503/files/eebd8546b9f9c8f37b5e93118ab52a3af15d63ff
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
328ee38https://github.com/matplotlib/matplotlib/commit/328ee38d2dfddd7d89b25ca28f7bb74c67f653d1
Apr 16, 2026https://github.com/matplotlib/matplotlib/pull/31503#event-24572991568
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31503/
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v3.11.0https://github.com/matplotlib/matplotlib/milestone/96
Apr 16, 2026https://github.com/matplotlib/matplotlib/pull/31503/#event-24572995108
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
April 16, 2026 18:15https://github.com/matplotlib/matplotlib/pull/31503/#event-24578444416
https://github.com/rcomer
rcomerhttps://github.com/rcomer
Apr 23, 2026 https://github.com/matplotlib/matplotlib/pull/31503/#ref-issue-3725741643
[Bug]: Random timeout failures in CI #30851 https://github.com/matplotlib/matplotlib/issues/30851
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/31503/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31503%2F
https://github.com/ksunden
ksunden https://github.com/ksunden
https://github.com/matplotlib/matplotlib/pull/31503/files/eebd8546b9f9c8f37b5e93118ab52a3af15d63ff
topic: testing https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22
v3.11.0 https://github.com/matplotlib/matplotlib/milestone/96
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31503/
https://github.com/QuLogic
https://github.com/ksunden
https://github.com/tacaswell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.