René's URL Explorer Experiment


Title: MNT: Restrict webagg toolbar actions to valid actions by scottshambaugh · Pull Request #31294 · matplotlib/matplotlib · GitHub

Open Graph Title: MNT: Restrict webagg toolbar actions to valid actions by scottshambaugh · Pull Request #31294 · matplotlib/matplotlib

X Title: MNT: Restrict webagg toolbar actions to valid actions by scottshambaugh · Pull Request #31294 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR summary The WebAgg backend starts a local Tornado web server with no origin checking on its WebSocket handler and an open getattr dispatch for toolbar actions. This means any webpage a user visi...

X Description: PR summary The WebAgg backend starts a local Tornado web server with no origin checking on its WebSocket handler and an open getattr dispatch for toolbar actions. This means any webpage a user visi...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/31294

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76c85071-2108-7acc-1cda-76e02e355fd0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA49C:195DA5:B2B47D:F0A0B1:6A5163A2
html-safe-nonce2e68ece44faf4edecf0296483cd961d45fd498db928139b821c47e04fe6699d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDlDOjE5NURBNTpCMkI0N0Q6RjBBMEIxOjZBNTE2M0EyIiwidmlzaXRvcl9pZCI6Ijc2NTQwNzU4NTI5Mzg4OTYyOTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1ae5cdbf285b5e115f32c204c496b40d8f7dd13127e9d64210015fa8a03096c0
hovercard-subject-tagpull_request:3392133880
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/31294/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c81c3a5ca2454a4121fd47ba2e11597db57a68a324a2a8f3a15604306c0f7f2f/matplotlib/matplotlib/pull/31294
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c81c3a5ca2454a4121fd47ba2e11597db57a68a324a2a8f3a15604306c0f7f2f/matplotlib/matplotlib/pull/31294
og:image:altPR summary The WebAgg backend starts a local Tornado web server with no origin checking on its WebSocket handler and an open getattr dispatch for toolbar actions. This means any webpage a user visi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamescottshambaugh
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2eeb434949a926fad21064b4d395a54759f7a0b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/31294/#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31294%2F
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31294%2F
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/31294/
Reloadhttps://github.com/matplotlib/matplotlib/pull/31294/
Reloadhttps://github.com/matplotlib/matplotlib/pull/31294/
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
scottshambaugh:webagg_cross_originhttps://github.com/scottshambaugh/matplotlib/tree/webagg_cross_origin
Conversationhttps://github.com/matplotlib/matplotlib/pull/31294
Commits3 (3)https://github.com/matplotlib/matplotlib/pull/31294/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/31294/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/31294/files
MNT: Restrict webagg toolbar actions to valid actionshttps://github.com/matplotlib/matplotlib/pull/31294/#top
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
scottshambaugh:webagg_cross_originhttps://github.com/scottshambaugh/matplotlib/tree/webagg_cross_origin
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
Mar 12, 2026https://github.com/matplotlib/matplotlib/pull/31294/#issue-4067609177
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
@tacaswellhttps://github.com/tacaswell
link the related issuehttps://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
testedhttps://matplotlib.org/devdocs/devel/testing.html
examplehttps://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials
directive and release notehttps://matplotlib.org/devdocs/devel/api_changes.html#announce-changes-deprecations-and-new-features
generalhttps://matplotlib.org/devdocs/devel/document.html#write-rest-pages
docstringhttps://matplotlib.org/devdocs/devel/document.html#write-docstrings
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
Security Hardening https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Security%20Hardening%22
Mar 12, 2026https://github.com/matplotlib/matplotlib/pull/31294/#event-23525692315
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
GUI: webagg https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20webagg%22
Mar 12, 2026https://github.com/matplotlib/matplotlib/pull/31294/#event-23525695419
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
force-pushedhttps://github.com/matplotlib/matplotlib/compare/ba73df8aaafa820472962c822f6c664b9a06320e..f1f0da8f30b2c65c82a13928ff7664a84352c616
ba73df8https://github.com/matplotlib/matplotlib/commit/ba73df8aaafa820472962c822f6c664b9a06320e
f1f0da8https://github.com/matplotlib/matplotlib/commit/f1f0da8f30b2c65c82a13928ff7664a84352c616
Compare https://github.com/matplotlib/matplotlib/compare/ba73df8aaafa820472962c822f6c664b9a06320e..f1f0da8f30b2c65c82a13928ff7664a84352c616
March 13, 2026 00:59https://github.com/matplotlib/matplotlib/pull/31294/#event-23528824152
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 13, 2026 https://github.com/matplotlib/matplotlib/pull/31294/#pullrequestreview-3941021374
View reviewed changes https://github.com/matplotlib/matplotlib/pull/31294/files
lib/matplotlib/backends/backend_webagg.pyhttps://github.com/matplotlib/matplotlib/pull/31294/files#diff-d09b3ce6f78962aceac2a3a030f6536a55c062fb8ca55bc98b4b5d517a59f6c4
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v3.11.0https://github.com/matplotlib/matplotlib/milestone/96
Mar 13, 2026https://github.com/matplotlib/matplotlib/pull/31294/#event-23529458587
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 13, 2026https://github.com/matplotlib/matplotlib/pull/31294/#issuecomment-4051642238
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
Security Hardening https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Security%20Hardening%22
Mar 13, 2026https://github.com/matplotlib/matplotlib/pull/31294/#event-23529902810
scottshambaughhttps://github.com/scottshambaugh
March 12, 2026 20:10https://github.com/matplotlib/matplotlib/pull/31294/#commits-pushed-545f974
https://github.com/scottshambaugh
Restrict webagg toolbar events to the actual toolbar itemshttps://github.com/matplotlib/matplotlib/pull/31294/commits/545f974ad8ed83ca7d828eacb3d9e998b5959e7f
545f974https://github.com/matplotlib/matplotlib/pull/31294/commits/545f974ad8ed83ca7d828eacb3d9e998b5959e7f
https://github.com/scottshambaugh
Add test verifying Tornado rejects cross-origin WebSocket connectionshttps://github.com/matplotlib/matplotlib/pull/31294/commits/dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee
dff2887https://github.com/matplotlib/matplotlib/pull/31294/commits/dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
force-pushedhttps://github.com/matplotlib/matplotlib/compare/f1f0da8f30b2c65c82a13928ff7664a84352c616..dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee
f1f0da8https://github.com/matplotlib/matplotlib/commit/f1f0da8f30b2c65c82a13928ff7664a84352c616
dff2887https://github.com/matplotlib/matplotlib/commit/dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee
Compare https://github.com/matplotlib/matplotlib/compare/f1f0da8f30b2c65c82a13928ff7664a84352c616..dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee
March 13, 2026 02:10https://github.com/matplotlib/matplotlib/pull/31294/#event-23530017530
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
Mar 13, 2026https://github.com/matplotlib/matplotlib/pull/31294/#event-23530034704
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 13, 2026 https://github.com/matplotlib/matplotlib/pull/31294/#pullrequestreview-3941185636
View reviewed changes https://github.com/matplotlib/matplotlib/pull/31294/files/dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 13, 2026 https://github.com/matplotlib/matplotlib/pull/31294/#pullrequestreview-3941199863
View reviewed changes https://github.com/matplotlib/matplotlib/pull/31294/files/dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee
lib/matplotlib/backends/backend_webagg_core.pyhttps://github.com/matplotlib/matplotlib/pull/31294/files/dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee#diff-6d1e28fa9eb5254b30f1dd613881417bb4f173ea90669dc55c3bb4fe9b5ab73f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
lib/matplotlib/tests/test_backend_webagg.pyhttps://github.com/matplotlib/matplotlib/pull/31294/files/dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee#diff-f4f309539f850ed35fe15c8cb63abeac4c118d1971e3cd7074a6f0f02fddd415
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
https://github.com/scottshambaugh
https://github.com/QuLogic
Apply suggestions from code reviewhttps://github.com/matplotlib/matplotlib/pull/31294/commits/81e0be742cfb1dfd208f4b1945f6cb74b3cf7a22
81e0be7https://github.com/matplotlib/matplotlib/pull/31294/commits/81e0be742cfb1dfd208f4b1945f6cb74b3cf7a22
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 13, 2026 https://github.com/matplotlib/matplotlib/pull/31294/#pullrequestreview-3946488920
View reviewed changes https://github.com/matplotlib/matplotlib/pull/31294/files/81e0be742cfb1dfd208f4b1945f6cb74b3cf7a22
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
32805b1https://github.com/matplotlib/matplotlib/commit/32805b17915236a9d9b1144f2a948f78e47ae39e
Mar 13, 2026https://github.com/matplotlib/matplotlib/pull/31294#event-23557667633
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
andreas16700https://github.com/andreas16700
Mar 16, 2026 https://github.com/matplotlib/matplotlib/pull/31294/#ref-commit-8211630
https://github.com/andreas16700
Runhttps://github.com/andreas16700/matplotlib/commit/821163076df8ea0a20ebaf1aca3953d6b2f196ca
32805b1https://github.com/andreas16700/matplotlib/commit/32805b17915236a9d9b1144f2a948f78e47ae39e
: Merge pull requesthttps://github.com/andreas16700/matplotlib/commit/821163076df8ea0a20ebaf1aca3953d6b2f196ca
matplotlib#31294https://github.com/matplotlib/matplotlib/pull/31294
from scottshambaugh/…https://github.com/andreas16700/matplotlib/commit/821163076df8ea0a20ebaf1aca3953d6b2f196ca
8211630https://github.com/andreas16700/matplotlib/commit/821163076df8ea0a20ebaf1aca3953d6b2f196ca
andreas16700https://github.com/andreas16700
Mar 16, 2026 https://github.com/matplotlib/matplotlib/pull/31294/#ref-commit-07e4f2c
https://github.com/andreas16700
Runhttps://github.com/andreas16700/matplotlib/commit/07e4f2c5395ea13e7a18391da40b1d56a571920c
32805b1https://github.com/andreas16700/matplotlib/commit/32805b17915236a9d9b1144f2a948f78e47ae39e
: Merge pull requesthttps://github.com/andreas16700/matplotlib/commit/07e4f2c5395ea13e7a18391da40b1d56a571920c
matplotlib#31294https://github.com/matplotlib/matplotlib/pull/31294
from scottshambaugh/…https://github.com/andreas16700/matplotlib/commit/07e4f2c5395ea13e7a18391da40b1d56a571920c
07e4f2chttps://github.com/andreas16700/matplotlib/commit/07e4f2c5395ea13e7a18391da40b1d56a571920c
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/31294/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31294%2F
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/31294/files/dff28876bb1a7df2a06cf0fe37ee56b8479bf6ee
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/31294/files/81e0be742cfb1dfd208f4b1945f6cb74b3cf7a22
GUI: webagg https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20webagg%22
v3.11.0 https://github.com/matplotlib/matplotlib/milestone/96
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/31294/
https://github.com/scottshambaugh
https://github.com/tacaswell
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.