Title: SEC: Block shell escapes in latex and ps commands by scottshambaugh · Pull Request #31282 · matplotlib/matplotlib · GitHub
Open Graph Title: SEC: Block shell escapes in latex and ps commands by scottshambaugh · Pull Request #31282 · matplotlib/matplotlib
X Title: SEC: Block shell escapes in latex and ps commands by scottshambaugh · Pull Request #31282 · matplotlib/matplotlib
Description: PR summary See the discussion in #31249 This blocks our LaTeX and ps commands from arbitrary code execution in the shell: --no-shell-escape added to all latex commands dvips flag changed from -R0 to -R1 to disallow shell execution. -R1 is the default, so is there a reason we had this manually set to a lower security level? See the docs here: https://www.tug.org/texinfohtml/dvips.html#Option-details-1 -dSAFER flag added to two ghostscript / ps calls which were missing it. May be the default, but now it's explicit, see the docs here: https://ghostscript.readthedocs.io/en/latest/Use.html#dsafer AI Disclosure Claude used for the audit (found a few more spots to hit!), code manually reviewed PR checklist [n/a] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines
Open Graph Description: PR summary See the discussion in #31249 This blocks our LaTeX and ps commands from arbitrary code execution in the shell: --no-shell-escape added to all latex commands dvips flag changed from -R0 ...
X Description: PR summary See the discussion in #31249 This blocks our LaTeX and ps commands from arbitrary code execution in the shell: --no-shell-escape added to all latex commands dvips flag changed from -R0 ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/31282
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:547928bb-4db4-e552-e033-c18341ae97d1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D914:1B3289:D83089:125F902:6A51F902 |
| html-safe-nonce | 8bb2d76b4b5abb41279460911da4a59c7c22d6c0febb6ca3e263672d70748be9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTE0OjFCMzI4OTpEODMwODk6MTI1RjkwMjo2QTUxRjkwMiIsInZpc2l0b3JfaWQiOiIyNTgxMDkyOTY1MTg4NDk5NzE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1bae8b8b43b54ab57a7b6274723d9d0c71f2229c17b1bc4f57dfce1af661e5ba |
| hovercard-subject-tag | pull_request:3385838661 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/31282/files |
| twitter:image | https://avatars.githubusercontent.com/u/14363975?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14363975?s=400&v=4 |
| og:image:alt | PR summary See the discussion in #31249 This blocks our LaTeX and ps commands from arbitrary code execution in the shell: --no-shell-escape added to all latex commands dvips flag changed from -R0 ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width