| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:014d94ea-9d75-9c82-7aa7-619527f1d784 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C13A:ADAC7:6B67:8BB3:6A521B80 |
| html-safe-nonce | 1c1f703fe32c95338b42c6d07bbcc4a7588cc831580b1295625ff441c0b1b194 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTNBOkFEQUM3OjZCNjc6OEJCMzo2QTUyMUI4MCIsInZpc2l0b3JfaWQiOiIyNzY4MjA1ODYxMTM4NjAyODgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f55a66eb1309e664d48e4c11e0cbd103921802e0aab07569fb61f2da6b7fbe71 |
| hovercard-subject-tag | pull_request:3214766252 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/31041/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bc29f9e16004f6f63185fb91493013e115c6669a8d23c5f30ae737110c01f45d/matplotlib/matplotlib/pull/31041 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc29f9e16004f6f63185fb91493013e115c6669a8d23c5f30ae737110c01f45d/matplotlib/matplotlib/pull/31041 |
| og:image:alt | PR Summary
As mentioned in #30979, set is not tested directly even though it is used in many places.
These tests lock in the current behaviour:
-passing an invalid property name raises an Attribute... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aditya-singh597 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/31041#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31041 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31041 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/31041 |
| Reload | https://github.com/matplotlib/matplotlib/pull/31041 |
| Reload | https://github.com/matplotlib/matplotlib/pull/31041 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| rcomer | https://github.com/rcomer |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| aditya-singh597:test-setp-invalid-property | https://github.com/aditya-singh597/matplotlib/tree/test-setp-invalid-property |
| Conversation | https://github.com/matplotlib/matplotlib/pull/31041 |
| Commits4 (4) | https://github.com/matplotlib/matplotlib/pull/31041/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/31041/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/31041/files |
| Add tests for invalid properties and duplicate aliases in Artist.set | https://github.com/matplotlib/matplotlib/pull/31041#top |
| rcomer | https://github.com/rcomer |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| aditya-singh597:test-setp-invalid-property | https://github.com/aditya-singh597/matplotlib/tree/test-setp-invalid-property |
|
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| Jan 27, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issue-3860789769 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| #30979 | https://github.com/matplotlib/matplotlib/pull/30979 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| January 27, 2026 18:55 | https://github.com/matplotlib/matplotlib/pull/31041#commits-pushed-4008630 |
| Add test for invalid property names passed to setp | https://github.com/matplotlib/matplotlib/pull/31041/commits/4008630d32e90eff8e23e0a3b470d46346beddfd |
| 4008630 | https://github.com/matplotlib/matplotlib/pull/31041/commits/4008630d32e90eff8e23e0a3b470d46346beddfd |
| Fix blank line spacing for ruff | https://github.com/matplotlib/matplotlib/pull/31041/commits/6333c046a22267d8b775769eab06467a0d9e4bc8 |
| 6333c04 | https://github.com/matplotlib/matplotlib/pull/31041/commits/6333c046a22267d8b775769eab06467a0d9e4bc8 |
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| Jan 27, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3806898712 |
| @story645 | https://github.com/story645 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/story645 |
| story645 | https://github.com/story645 |
| Jan 27, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3806908703 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| Jan 27, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3806992782 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/rcomer |
| rcomer | https://github.com/rcomer |
| Jan 28, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3810387666 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| #30979 | https://github.com/matplotlib/matplotlib/pull/30979 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| Jan 28, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3810496657 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/rcomer |
| rcomer | https://github.com/rcomer |
| Jan 29, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3817763801 |
| @aditya-singh597 | https://github.com/aditya-singh597 |
| incubator chat | https://discourse.matplotlib.org/chat/c/incubator/4 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/rcomer |
| rcomer | https://github.com/rcomer |
| January 29, 2026 13:41 | https://github.com/matplotlib/matplotlib/pull/31041#event-22377166114 |
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| Jan 29, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3818080135 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| Jan 29, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#event-22385289440 |
| Add tests for error handling in Artist.set | https://github.com/matplotlib/matplotlib/pull/31041/commits/99c36fdd2461e7bd72af7d7fc48282323f057c7b |
| 99c36fd | https://github.com/matplotlib/matplotlib/pull/31041/commits/99c36fdd2461e7bd72af7d7fc48282323f057c7b |
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| January 29, 2026 22:31 | https://github.com/matplotlib/matplotlib/pull/31041#event-22390042159 |
| Fix trailing whitespace in test_artist | https://github.com/matplotlib/matplotlib/pull/31041/commits/7ba8a792db09e752d630e5c01943da5dc93ba82c |
| 7ba8a79 | https://github.com/matplotlib/matplotlib/pull/31041/commits/7ba8a792db09e752d630e5c01943da5dc93ba82c |
| https://github.com/melissawm |
| melissawm | https://github.com/melissawm |
|
topic: testing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22 |
| Jan 30, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#event-22415393682 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Feb 2, 2026
| https://github.com/matplotlib/matplotlib/pull/31041#pullrequestreview-3738066417 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/31041/files/7ba8a792db09e752d630e5c01943da5dc93ba82c |
| https://github.com/rcomer |
| rcomer | https://github.com/rcomer |
|
Feb 2, 2026
| https://github.com/matplotlib/matplotlib/pull/31041#pullrequestreview-3738997137 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/31041/files/7ba8a792db09e752d630e5c01943da5dc93ba82c |
| https://github.com/rcomer |
| rcomer | https://github.com/rcomer |
| v3.11.0 | https://github.com/matplotlib/matplotlib/milestone/96 |
| Feb 2, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#event-22463498926 |
| https://github.com/rcomer |
| rcomer | https://github.com/rcomer |
| 01fdf1b | https://github.com/matplotlib/matplotlib/commit/01fdf1bbd9136f63c46b2eefa4097605d3e80dba |
| Feb 2, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#event-22463507694 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/rcomer |
| rcomer | https://github.com/rcomer |
| Feb 2, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3834733774 |
| @aditya-singh597 | https://github.com/aditya-singh597 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| Feb 2, 2026 | https://github.com/matplotlib/matplotlib/pull/31041#issuecomment-3834876493 |
| @rcomer | https://github.com/rcomer |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
| https://github.com/aditya-singh597 |
| aditya-singh597 | https://github.com/aditya-singh597 |
| February 2, 2026 12:43 | https://github.com/matplotlib/matplotlib/pull/31041#event-22464426773 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F31041 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/31041/files/7ba8a792db09e752d630e5c01943da5dc93ba82c |
|
| https://github.com/rcomer |
|
rcomer
| https://github.com/rcomer |
|
| https://github.com/matplotlib/matplotlib/pull/31041/files/7ba8a792db09e752d630e5c01943da5dc93ba82c |
|
topic: testing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22 |
|
v3.11.0
| https://github.com/matplotlib/matplotlib/milestone/96 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/31041 |
|
| https://github.com/aditya-singh597 |
|
| https://github.com/story645 |
|
| https://github.com/rcomer |
|
| https://github.com/timhoffm |
|
| https://github.com/melissawm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |