Title: Add Windows-specific CREATE_NO_WINDOW flag for test subprocesses by sanrishi · Pull Request #30879 · matplotlib/matplotlib · GitHub
Open Graph Title: Add Windows-specific CREATE_NO_WINDOW flag for test subprocesses by sanrishi · Pull Request #30879 · matplotlib/matplotlib
X Title: Add Windows-specific CREATE_NO_WINDOW flag for test subprocesses by sanrishi · Pull Request #30879 · matplotlib/matplotlib
Description: This pull request makes the test subprocess helper a bit smarter on Windows to avoid spurious timeouts. Added subprocess section in subprocess_run_for_testing function Modified subprocess section This change updates subprocess_run_for_testing so that, on Windows, it runs test subprocesses with the CREATE_NO_WINDOW flag. This prevents console windows from being created for every subprocess, which can contribute to the hanging and timeout behavior seen in the Windows test runs. The new behavior is guarded by sys.platform == "win32" and merges CREATE_NO_WINDOW with any existing creationflags, so non‑Windows platforms and callers that already pass creationflags keep their current behavior. PR checklist closes #30851 is in the body of the PR description to link the related issue new and changed code is tested Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines
Open Graph Description: This pull request makes the test subprocess helper a bit smarter on Windows to avoid spurious timeouts. Added subprocess section in subprocess_run_for_testing function Modified subprocess section ...
X Description: This pull request makes the test subprocess helper a bit smarter on Windows to avoid spurious timeouts. Added subprocess section in subprocess_run_for_testing function Modified subprocess section ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/30879
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e92cf66a-2d2c-8862-3769-4d0e4bacf1aa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B14C:28F606:A32C8F:DBB2BC:6A529831 |
| html-safe-nonce | f2a62250e27a0e5e061caaf4f8e98bd848aa1fed2d27b7b72de87506e67d9d96 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTRDOjI4RjYwNjpBMzJDOEY6REJCMkJDOjZBNTI5ODMxIiwidmlzaXRvcl9pZCI6IjE3MDQ4NDU2NDMxMDc5NjQ5NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 11ca8d8d0cdf66ee80caa706fc4f1773d483ad30cd6e0f31515ea8780bb48bec |
| hovercard-subject-tag | pull_request:3112996227 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/30879/files |
| twitter:image | https://avatars.githubusercontent.com/u/220483717?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/220483717?s=400&v=4 |
| og:image:alt | This pull request makes the test subprocess helper a bit smarter on Windows to avoid spurious timeouts. Added subprocess section in subprocess_run_for_testing function Modified subprocess section ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width