René's URL Explorer Experiment

Title: Fixed bilinear interpolation for `SegmentedBivarColormap` by ayshih · Pull Request #30824 · matplotlib/matplotlib · GitHub

Open Graph Title: Fixed bilinear interpolation for `SegmentedBivarColormap` by ayshih · Pull Request #30824 · matplotlib/matplotlib

X Title: Fixed bilinear interpolation for `SegmentedBivarColormap` by ayshih · Pull Request #30824 · matplotlib/matplotlib

Description: PR summary The lookup table generated by SegmentedBivarColormap is slightly inaccurate. Most notably, the darkest color in the lookup table is not as dark as the darkest color in the input, and the same goes for the brightest color. This has been glossed over in the tests due to the liberal use of atol. >>> from matplotlib.cm import bivar_cmaps >>> cmap = bivar_cmaps['BiOrangeBlue'] >>> print(cmap.patch[0, 0, :]) [0. 0. 0.] >>> print(cmap.patch[-1, 0, :]) [1. 0.5 0. ] >>> print(cmap.patch[-1, -1, :]) [1. 1. 1.] >>> print(cmap.lut[0, 0, :]) [0.00244141 0.00242224 0.00244141 1. ] >>> print(cmap.lut[-1, 0, :]) [0.99853516 0.50048437 0.00244141 1. ] >>> print(cmap.lut[-1, -1, :]) [0.99853516 0.99854675 0.99853516 1. ] SegmentedBivarColormap uses the image-plotting resampler (Agg) to perform bilinear interpolation, and these inaccuracies result from a bug in the transform definition plus a second bug that would be fixed by #30184. However, just fixing these two bugs is not a good solution. The Agg resampler – which is intended for producing good-enough images for visual display – is problematic because it divides each pixel into 256 subpixels, which means it internally calculates 256 * M - 1 intermediate color candidates between the end colors, but the color table wants 254 intermediate colors between the end colors (to get 256 colors in total). That means fixing the aforementioned two bugs results in a non-smooth color table because 254 does not divide into 256 * M - 1 cleanly. So, this PR instead takes the approach of eschewing the Agg resampler entirely and performing the bilinear interpolation using straight NumPy. Now the extreme colors are exactly what they should be. I'll note that the tests still need to use a bit of atol because the definition of BiOrangeBlue uses input that is rounded to 3 decimal places. Update: now fixed. >>> from matplotlib.cm import bivar_cmaps >>> cmap = bivar_cmaps['BiOrangeBlue'] >>> print(cmap.patch[0, 0, :]) [0. 0. 0.] >>> print(cmap.patch[-1, 0, :]) [1. 0.5 0. ] >>> print(cmap.patch[-1, -1, :]) [1. 1. 1.] >>> print(cmap.lut[0, 0, :]) [0. 0. 0. 1.] >>> print(cmap.lut[-1, 0, :]) [1. 0.5 0. 1. ] >>> print(cmap.lut[-1, -1, :]) [1. 1. 1. 1.] PR checklist [] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [] Plotting related features are demonstrated in an example [] New Features and API Changes are noted with a directive and release note [] Documentation complies with general and docstring guidelines

Open Graph Description: PR summary The lookup table generated by SegmentedBivarColormap is slightly inaccurate. Most notably, the darkest color in the lookup table is not as dark as the darkest color in the input, and t...

X Description: PR summary The lookup table generated by SegmentedBivarColormap is slightly inaccurate. Most notably, the darkest color in the lookup table is not as dark as the darkest color in the input, and t...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/30824

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width